diff --git a/.github/workflows/build-linux-arm64-installer.yml b/.github/workflows/build-linux-arm64-installer.yml index 13c600f001..8e3ec8032a 100644 --- a/.github/workflows/build-linux-arm64-installer.yml +++ b/.github/workflows/build-linux-arm64-installer.yml @@ -185,7 +185,7 @@ jobs: - name: Configure AWS Credentials if: steps.check_secrets.outputs.HAS_AWS_SECRET - uses: aws-actions/configure-aws-credentials@v1-node16 + uses: aws-actions/configure-aws-credentials@v1 with: aws-access-key-id: ${{ secrets.INSTALLER_UPLOAD_KEY }} aws-secret-access-key: ${{ secrets.INSTALLER_UPLOAD_SECRET }} diff --git a/.github/workflows/build-linux-installer-deb.yml b/.github/workflows/build-linux-installer-deb.yml index de343382c7..2a851919a8 100644 --- a/.github/workflows/build-linux-installer-deb.yml +++ b/.github/workflows/build-linux-installer-deb.yml @@ -185,7 +185,7 @@ jobs: - name: Configure AWS Credentials if: steps.check_secrets.outputs.HAS_AWS_SECRET - uses: aws-actions/configure-aws-credentials@v1-node16 + uses: aws-actions/configure-aws-credentials@v1 with: aws-access-key-id: ${{ secrets.INSTALLER_UPLOAD_KEY }} aws-secret-access-key: ${{ secrets.INSTALLER_UPLOAD_SECRET }} diff --git a/.github/workflows/build-linux-installer-rpm.yml b/.github/workflows/build-linux-installer-rpm.yml index 23a9cb1256..18fe3456a7 100644 --- a/.github/workflows/build-linux-installer-rpm.yml +++ b/.github/workflows/build-linux-installer-rpm.yml @@ -184,7 +184,7 @@ jobs: - name: Configure AWS Credentials if: steps.check_secrets.outputs.HAS_AWS_SECRET - uses: aws-actions/configure-aws-credentials@v1-node16 + uses: aws-actions/configure-aws-credentials@v1 with: aws-access-key-id: ${{ secrets.INSTALLER_UPLOAD_KEY }} aws-secret-access-key: ${{ secrets.INSTALLER_UPLOAD_SECRET }} diff --git a/.github/workflows/build-windows-installer.yml b/.github/workflows/build-windows-installer.yml index 8bd165d6f6..a60c8f8cea 100644 --- a/.github/workflows/build-windows-installer.yml +++ b/.github/workflows/build-windows-installer.yml @@ -242,7 +242,7 @@ jobs: - name: Configure AWS Credentials if: steps.check_secrets.outputs.HAS_AWS_SECRET - uses: aws-actions/configure-aws-credentials@v1-node16 + uses: aws-actions/configure-aws-credentials@v1 with: aws-access-key-id: ${{ secrets.INSTALLER_UPLOAD_KEY }} aws-secret-access-key: ${{ secrets.INSTALLER_UPLOAD_SECRET }} diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml index 0116a7800f..166631b493 100644 --- a/.github/workflows/dependency-review.yml +++ b/.github/workflows/dependency-review.yml @@ -17,4 +17,4 @@ jobs: - name: 'Checkout Repository' uses: actions/checkout@v3 - name: 'Dependency Review' - uses: actions/dependency-review-action@v2 + uses: actions/dependency-review-action@v3 diff --git a/.github/workflows/require-labels.yml b/.github/workflows/require-labels.yml index 5f2f3b1996..92c16147d5 100644 --- a/.github/workflows/require-labels.yml +++ b/.github/workflows/require-labels.yml @@ -13,7 +13,7 @@ jobs: status: ${{ steps.check-labels.outputs.status }} steps: - id: check-labels - uses: mheap/github-action-required-labels@v2 + uses: mheap/github-action-required-labels@v3 with: mode: exactly count: 1 diff --git a/.github/workflows/snyk-python-scan.yml b/.github/workflows/snyk-python-scan.yml index f0956f1ab3..68a722c58d 100644 --- a/.github/workflows/snyk-python-scan.yml +++ b/.github/workflows/snyk-python-scan.yml @@ -46,7 +46,7 @@ jobs: - name: Setup Python environment if: steps.check_secrets.outputs.HAS_SNYK_SECRET - uses: actions/setup-python@v3 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} diff --git a/.github/workflows/super-linter.yml b/.github/workflows/super-linter.yml index cd155de16d..799f010ed0 100644 --- a/.github/workflows/super-linter.yml +++ b/.github/workflows/super-linter.yml @@ -57,7 +57,7 @@ jobs: # Run Linter against code base # ################################ - name: Lint Code Base - uses: github/super-linter@v4.9.3 + uses: github/super-linter@v4 # uses: docker://github/super-linter:v3.10.2 env: VALIDATE_ALL_CODEBASE: true diff --git a/build_scripts/build_macos-2-installer.sh b/build_scripts/build_macos-2-installer.sh index 3e639ea778..1f2818f606 100644 --- a/build_scripts/build_macos-2-installer.sh +++ b/build_scripts/build_macos-2-installer.sh @@ -75,10 +75,10 @@ cd ../../../build_scripts || exit 1 mkdir final_installer DMG_NAME="chia-${CHIA_INSTALLER_VERSION}.dmg" if [ "$(arch)" = "arm64" ]; then - mv dist/${DMG_NAME} dist/chia-${CHIA_INSTALLER_VERSION}-arm64.dmg + mv dist/"${DMG_NAME}" dist/chia-"${CHIA_INSTALLER_VERSION}"-arm64.dmg DMG_NAME=chia-${CHIA_INSTALLER_VERSION}-arm64.dmg fi -mv dist/$DMG_NAME final_installer/ +mv dist/"$DMG_NAME" final_installer/ ls -lh final_installer diff --git a/install-timelord.sh b/install-timelord.sh index 9e0722f9c4..1683c025c9 100644 --- a/install-timelord.sh +++ b/install-timelord.sh @@ -54,6 +54,7 @@ ubuntu_cmake_install() { sudo apt-get remove --purge cmake -y hash -r sudo snap install cmake --classic + # shellcheck disable=SC1091 . /etc/profile else echo "Ubuntu 20.04LTS and newer support CMake 3.16+" @@ -87,7 +88,7 @@ if [ -e "$THE_PATH" ]; then echo "$THE_PATH" echo "vdf_client already exists, no action taken" else - if [ -e venv/bin/python ] && test $UBUNTU_DEBIAN; then + if [ -e venv/bin/python ] && test "$UBUNTU_DEBIAN"; then echo "Installing chiavdf dependencies on Ubuntu/Debian" # If Ubuntu version is older than 20.04LTS then upgrade CMake ubuntu_cmake_install @@ -98,7 +99,7 @@ else echo venv/bin/python -m pip install --force --no-binary chiavdf "$CHIAVDF_VERSION" venv/bin/python -m pip install --force --no-binary chiavdf "$CHIAVDF_VERSION" symlink_vdf_bench "$PYTHON_VERSION" - elif [ -e venv/bin/python ] && test $RHEL_BASED; then + elif [ -e venv/bin/python ] && test "$RHEL_BASED"; then echo "Installing chiavdf dependencies on RedHat/CentOS/Fedora" # Install remaining needed development tools - assumes venv and prior run of install.sh echo "yum install gcc gcc-c++ gmp-devel $PYTHON_DEV_DEPENDENCY libtool make autoconf automake openssl-devel libevent-devel boost-devel python3 cmake -y" @@ -107,7 +108,7 @@ else echo venv/bin/python -m pip install --force --no-binary chiavdf "$CHIAVDF_VERSION" venv/bin/python -m pip install --force --no-binary chiavdf "$CHIAVDF_VERSION" symlink_vdf_bench "$PYTHON_VERSION" - elif [ -e venv/bin/python ] && test $MACOS; then + elif [ -e venv/bin/python ] && test "$MACOS"; then echo "Installing chiavdf dependencies for MacOS." brew install boost cmake gmp echo "Installing chiavdf from source."