oxen-io/lokinet
1
1
Fork 0
mirror of https://github.com/oxen-io/lokinet synced 2023-12-14 06:53:00 +01:00
Code Issues Projects Releases Wiki Activity

Fix broken config-related test cases

Browse source
This commit is contained in:
Stephen Shelton 2020-05-08 08:43:25 -06:00
parent aee96e53a3
commit bcf473757d
No known key found for this signature in database
GPG key ID: EE4BADACCE8B631C
2 changed files with 2 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
test/config/test_llarp_config_definition.cpp
View file

@ -275,9 +275,7 @@ TEST_CASE("ConfigDefinition undeclared add/remove test", "[config]")
// ...then remove...
REQUIRE_NOTHROW(config.removeUndeclaredHandler("foo"));
CHECK_THROWS_WITH(
config.addConfigValue("foo", "bar", "val"),
"no declared section [foo]");
CHECK_THROWS_WITH(config.addConfigValue("foo", "bar", "val"), "unrecognized section [foo]");
// ...then add again
REQUIRE_NOTHROW(config.addUndeclaredHandler("foo", [&](std::string_view, std::string_view, std::string_view) {
@ -308,7 +306,7 @@ TEST_CASE("ConfigDefinition undeclared handler wrong section", "[config]")
throw std::runtime_error("FAIL");
});
REQUIRE_THROWS_WITH(config.addConfigValue("argle", "bar", "val"), "no declared section [argle]");
REQUIRE_THROWS_WITH(config.addConfigValue("argle", "bar", "val"), "unrecognized section [argle]");
}
TEST_CASE("ConfigDefinition undeclared handler duplicate names", "[config]")

17
test/config/test_llarp_config_output.cpp
View file

@ -150,20 +150,3 @@ baz=1
)raw");
}
TEST_CASE("ConfigDefinition should print comments for missing keys")
{
// TODO: this currently fails: how to implement?
llarp::ConfigDefinition config;
config.addSectionComments("foo", {"foo section comment"});
config.addOptionComments("foo", "bar", {"foo bar option comment"});
std::string output = config.generateINIConfig();
CHECK(output == R"raw(# foo section comment
[foo]
# foo bar option comment
bar=
)raw");
}