1
1
Fork 0
mirror of https://github.com/oxen-io/lokinet synced 2023-12-14 06:53:00 +01:00

use std::shared_ptr not a bare pointer to prevent memleak

This commit is contained in:
Jeff Becker 2020-02-01 09:31:53 -05:00
parent 227926a525
commit c014d21f84
No known key found for this signature in database
GPG key ID: F357B3B42F6F9B05
2 changed files with 3 additions and 4 deletions

View file

@ -473,7 +473,7 @@ namespace llarp
}
else
{
auto *replyMsg = new dns::Message(std::move(msg));
auto replyMsg = std::make_shared<dns::Message>(std::move(msg));
using service::Address;
using service::OutboundContext;
return EnsurePathToService(
@ -493,7 +493,7 @@ namespace llarp
}
else
{
auto *replyMsg = new dns::Message(std::move(msg));
auto replyMsg = std::make_shared<dns::Message>(std::move(msg));
return EnsurePathToSNode(
addr.as_array(),
[=](const RouterID &, exit::BaseSession_ptr s) {

View file

@ -271,7 +271,7 @@ namespace llarp
template < typename Addr_t, typename Endpoint_t >
void
SendDNSReply(Addr_t addr, Endpoint_t ctx, dns::Message* query,
SendDNSReply(Addr_t addr, Endpoint_t ctx, std::shared_ptr<dns::Message> query,
std::function< void(dns::Message) > reply, bool snode,
bool sendIPv6)
{
@ -283,7 +283,6 @@ namespace llarp
else
query->AddNXReply();
reply(*query);
delete query;
}
/// our dns resolver
std::shared_ptr< dns::Proxy > m_Resolver;