oxen-io/oxen-core
2
1
Fork 0
mirror of https://github.com/oxen-io/oxen-core.git synced 2023-12-14 02:22:56 +01:00
Code Issues Projects Releases Wiki Activity
oxen-core/src/device/device_ledger.hpp

334 lines
16 KiB
C++
Raw Normal View History

Update monero copyright to 2019 pre-emptively to make merge simpler
2019-04-12 06:36:43 +02:00
// Copyright (c) 2017-2019, The Monero Project
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without modification, are
// permitted provided that the following conditions are met:
//
// 1. Redistributions of source code must retain the above copyright notice, this list of
// conditions and the following disclaimer.
//
// 2. Redistributions in binary form must reproduce the above copyright notice, this list
// of conditions and the following disclaimer in the documentation and/or other
// materials provided with the distribution.
//
// 3. Neither the name of the copyright holder nor the names of its contributors may be
// used to endorse or promote products derived from this software without specific
// prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY
// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
//
#pragma once
Add cmd response time to debugging log output
2020-11-27 22:55:46 +01:00
#include <chrono>
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
#include <cstddef>
#include <string>
#include "device.hpp"
Add LedgerTCP hardware wallet support This communicates with the Ledger over TCP, which is what the ledger emulator requires. To use, specify: --hw-device LedgerTCP --hw-device-address localhost:9999 to the wallet command-line arguments.
2021-06-25 22:14:00 +02:00
#include "device/io_ledger_tcp.hpp"
Add get_tx_proof support, needed for new sanity check Enhance debug info
2019-03-21 17:22:43 +01:00
#include "log.hpp"
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
#include "io_hid.hpp"
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
namespace hw::ledger {
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
Ledger support updates Loki-side updates for Ledger Nano S support: - Add a get-network command (and bump protocol version) so that we can verify that the Ledger is set to the correct network type (i.e. mainnet or testnet). Previously there was no check at all, so you could have a testnet wallet on desktop using mainnet keys on the Ledger. Now they get checked and an error occurs on mismatch. - Reset required version to 0.9.0
2020-07-12 04:36:07 +02:00
using namespace std::literals;
// Required coin value as returned by INS_GET_NETWORK during connection
executable names changed
2021-01-04 04:19:42 +01:00
constexpr auto COIN_NETWORK = "OXEN"sv;
Ledger support updates Loki-side updates for Ledger Nano S support: - Add a get-network command (and bump protocol version) so that we can verify that the Ledger is set to the correct network type (i.e. mainnet or testnet). Previously there was no check at all, so you could have a testnet wallet on desktop using mainnet keys on the Ledger. Now they get checked and an error occurs on mismatch. - Reset required version to 0.9.0
2020-07-12 04:36:07 +02:00
Add application version compatibility check.
2019-03-07 23:34:53 +01:00
/* Minimal supported version */
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
constexpr std::array<uint8_t, 3> MINIMUM_APP_VERSION{0,9,0};
Add application version compatibility check.
2019-03-07 23:34:53 +01:00
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
void register_all(std::map<std::string, std::unique_ptr<device>> &registry);
#ifdef WITH_DEVICE_LEDGER
device_ledger: include status code name in error message
2020-02-07 15:20:38 +01:00
#define SW_OK 0x9000
Fix buggy, wrong command IDs Monero's codes are extremely broken (relative to Monero's own ledger app code) with wrong codes, omissions, and status codes that don't exist at all.
2020-11-29 23:27:34 +01:00
#define SW_WRONG_LENGTH 0x6700
#define SW_SECURITY_PIN_LOCKED 0x6910
#define SW_SECURITY_LOAD_KEY 0x6911
#define SW_SECURITY_COMMITMENT_CONTROL 0x6912
#define SW_SECURITY_AMOUNT_CHAIN_CONTROL 0x6913
#define SW_SECURITY_COMMITMENT_CHAIN_CONTROL 0x6914
#define SW_SECURITY_OUTKEYS_CHAIN_CONTROL 0x6915
#define SW_SECURITY_MAXOUTPUT_REACHED 0x6916
#define SW_SECURITY_HMAC 0x6917
#define SW_SECURITY_RANGE_VALUE 0x6918
#define SW_SECURITY_INTERNAL 0x6919
#define SW_SECURITY_MAX_SIGNATURE_REACHED 0x691A
#define SW_SECURITY_PREFIX_HASH 0x691B
#define SW_SECURITY_LOCKED 0x69EE
#define SW_COMMAND_NOT_ALLOWED 0x6980
#define SW_SUBCOMMAND_NOT_ALLOWED 0x6981
#define SW_DENY 0x6982
#define SW_KEY_NOT_SET 0x6983
#define SW_WRONG_DATA 0x6984
#define SW_WRONG_DATA_RANGE 0x6985
#define SW_IO_FULL 0x6986
#define SW_CLIENT_NOT_SUPPORTED 0x6A30
#define SW_WRONG_P1P2 0x6B00
#define SW_INS_NOT_SUPPORTED 0x6D00
#define SW_PROTOCOL_NOT_SUPPORTED 0x6E00
#define SW_UNKNOWN 0x6F00
device_ledger: include status code name in error message
2020-02-07 15:20:38 +01:00
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
void set_apdu_verbose(bool verbose);
class ABPkeys {
public:
rct::key Aout;
rct::key Bout;
Ledger HW Bug fixes Fix the way the REAL mode is handle: Let create_transactions_2 and create_transactions_from construct the vector of transactions. Then iterate on it and resign. We just need to add 'outs' list in the TX struct for that. Fix default secret keys value when DEBUG_HWDEVICE mode is off The magic value (00...00 for view key and FF..FF for spend key) was not correctly set when DEBUG_HWDEVICE was off. Both was set to 00...00. Add sub-address info in ABP map in order to correctly display destination sub-address on device Fix DEBUG_HWDEVICE mode: - Fix compilation errors. - Fix control device init in ledger device. - Add more log. Fix sub addr control Fix debug Info
2018-03-05 14:46:15 +01:00
bool is_subaddress;
New scheme key destination contrfol Implies protocol version management.
2018-12-11 10:20:21 +01:00
bool is_change_address;
bool additional_key ;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
size_t index;
rct::key Pout;
rct::key AKout;
New scheme key destination contrfol Implies protocol version management.
2018-12-11 10:20:21 +01:00
ABPkeys(const rct::key& A, const rct::key& B, const bool is_subaddr, bool is_subaddress, bool is_change_address, size_t index, const rct::key& P,const rct::key& AK);
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
ABPkeys(const ABPkeys& keys) ;
device_ledger: fix uninitialized additional_key Coverity 200185
2019-07-03 15:52:40 +02:00
ABPkeys() {index=0;is_subaddress=false;is_change_address=false;additional_key=false;}
Fix GCC 9.1 build warnings GCC wants operator= aand copy ctor to be both defined, or neither
2019-06-08 17:58:33 +02:00
ABPkeys &operator=(const ABPkeys &keys);
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
};
class Keymap {
public:
std::vector<ABPkeys> ABP;
bool find(const rct::key& P, ABPkeys& keys) const;
void add(const ABPkeys& keys);
void clear();
void log();
};
Add hmac over encrypted value during transaction
2019-09-25 14:31:14 +02:00
class SecHMAC {
public:
uint32_t sec[32];
uint32_t hmac[32];
SecHMAC(const uint8_t s[32], const uint8_t m[32]);
};
class HMACmap {
public:
std::vector<SecHMAC> hmacs;
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
void find_mac(const unsigned char sec[32], unsigned char hmac[32]) ;
void add_mac(const unsigned char sec[32], const unsigned char hmac[32]) ;
Add hmac over encrypted value during transaction
2019-09-25 14:31:14 +02:00
void clear() ;
};
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
#define BUFFER_SEND_SIZE 262
#define BUFFER_RECV_SIZE 262
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
class device_ledger : public device {
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
private:
Change mutex lock model to avoid dead lock and ensure locks are always released. Additional cosmetic fixes: move 'name' as protected remove unnecessary local var Fix debug log
2018-03-26 12:38:38 +02:00
// Locker for concurrent access
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
mutable std::recursive_mutex device_locker;
mutable std::mutex command_locker;
Change mutex lock model to avoid dead lock and ensure locks are always released. Additional cosmetic fixes: move 'name' as protected remove unnecessary local var Fix debug log
2018-03-26 12:38:38 +02:00
Replace USB-CCID (smartcard) by USB-HID Remove PCSC dependencies which is a bit hard (not user friendly) to install on linux and Mac Split Ledger logic and device IO
2018-08-01 09:24:53 +02:00
//IO
Add LedgerTCP hardware wallet support This communicates with the Ledger over TCP, which is what the ledger emulator requires. To use, specify: --hw-device LedgerTCP --hw-device-address localhost:9999 to the wallet command-line arguments.
2021-06-25 22:14:00 +02:00
std::unique_ptr<io::device> hw_device;
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
unsigned int length_send;
Replace USB-CCID (smartcard) by USB-HID Remove PCSC dependencies which is a bit hard (not user friendly) to install on linux and Mac Split Ledger logic and device IO
2018-08-01 09:24:53 +02:00
unsigned char buffer_send[BUFFER_SEND_SIZE];
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
unsigned int length_recv;
Replace USB-CCID (smartcard) by USB-HID Remove PCSC dependencies which is a bit hard (not user friendly) to install on linux and Mac Split Ledger logic and device IO
2018-08-01 09:24:53 +02:00
unsigned char buffer_recv[BUFFER_RECV_SIZE];
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
unsigned int sw;
unsigned int id;
Add cmd response time to debugging log output
2020-11-27 22:55:46 +01:00
std::chrono::steady_clock::time_point last_cmd;
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
void logCMD();
void logRESP();
unsigned int exchange(bool wait_on_input = false);
void reset_buffer();
int set_command_header(unsigned char ins, unsigned char p1 = 0x00, unsigned char p2 = 0x00);
int set_command_header_noopt(unsigned char ins, unsigned char p1 = 0x00, unsigned char p2 = 0x00);
Replace USB-CCID (smartcard) by USB-HID Remove PCSC dependencies which is a bit hard (not user friendly) to install on linux and Mac Split Ledger logic and device IO
2018-08-01 09:24:53 +02:00
void send_simple(unsigned char ins, unsigned char p1 = 0x00);
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
void send_bytes(const void* buf, size_t size, int& offset);
void receive_bytes(void* dest, size_t size, int& offset);
void receive_bytes(void* dest, size_t size);
Fix extracted txversion/txtype
2020-12-07 04:19:20 +01:00
void send_u16(uint16_t x, int& offset);
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
void send_u32(uint32_t x, int& offset);
uint32_t receive_u32(int& offset);
uint32_t receive_u32();
Add hmac over encrypted value during transaction
2019-09-25 14:31:14 +02:00
void send_secret(const unsigned char sec[32], int &offset);
Clean up more nasty C code
2020-11-28 00:34:49 +01:00
void send_secret(const char sec[32], int &offset) { send_secret(reinterpret_cast<const unsigned char*>(sec), offset); }
Add hmac over encrypted value during transaction
2019-09-25 14:31:14 +02:00
void receive_secret(unsigned char sec[32], int &offset);
Clean up more nasty C code
2020-11-28 00:34:49 +01:00
void receive_secret(char sec[32], int &offset) { receive_secret(reinterpret_cast<unsigned char*>(sec), offset); }
Ledger support updates Loki-side updates for Ledger Nano S support: - Add a get-network command (and bump protocol version) so that we can verify that the Ledger is set to the correct network type (i.e. mainnet or testnet). Previously there was no check at all, so you could have a testnet wallet on desktop using mainnet keys on the Ledger. Now they get checked and an error occurs on mismatch. - Reset required version to 0.9.0
2020-07-12 04:36:07 +02:00
void check_network_type();
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
void exchange_multipart_data(uint8_t ins, uint8_t p1, std::string_view data, uint8_t chunk_size);
void send_finish(int& offset);
unsigned int finish_and_exchange(int& offset, bool wait_on_input = false);
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
Add hmac over encrypted value during transaction
2019-09-25 14:31:14 +02:00
bool tx_in_progress;
Ledger support updates Loki-side updates for Ledger Nano S support: - Add a get-network command (and bump protocol version) so that we can verify that the Ledger is set to the correct network type (i.e. mainnet or testnet). Previously there was no check at all, so you could have a testnet wallet on desktop using mainnet keys on the Ledger. Now they get checked and an error occurs on mismatch. - Reset required version to 0.9.0
2020-07-12 04:36:07 +02:00
cryptonote::network_type nettype = cryptonote::network_type::UNDEFINED; // Set by the wallet before connecting
Add the possibility to export private view key for fast scan. On client startup the device asks for authorization to export the private view key. If user agree, the client hold the private view key allowing a fast blockchain scan. If the user does not agree, the blockchain scan is fully done via the device.
2018-03-26 12:55:48 +02:00
// map public destination key to ephemeral destination key
Keymap key_map;
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
bool add_output_key_mapping(
const crypto::public_key& Aout,
const crypto::public_key& Bout,
bool is_subaddress,
bool is_change,
bool need_additional,
size_t real_output_index,
const rct::key& amount_key,
const crypto::public_key& out_eph_public_key);
Add hmac over encrypted value during transaction
2019-09-25 14:31:14 +02:00
//hmac for some encrypted value
HMACmap hmac_map;
Add the possibility to export private view key for fast scan. On client startup the device asks for authorization to export the private view key. If user agree, the client hold the private view key allowing a fast blockchain scan. If the user does not agree, the blockchain scan is fully done via the device.
2018-03-26 12:55:48 +02:00
// To speed up blockchain parsing the view key maybe handle here.
crypto::secret_key viewkey;
bool has_view_key;
//extra debug
Ledger HW Bug fixes Fix the way the REAL mode is handle: Let create_transactions_2 and create_transactions_from construct the vector of transactions. Then iterate on it and resign. We just need to add 'outs' list in the TX struct for that. Fix default secret keys value when DEBUG_HWDEVICE mode is off The magic value (00...00 for view key and FF..FF for spend key) was not correctly set when DEBUG_HWDEVICE was off. Both was set to 00...00. Add sub-address info in ABP map in order to correctly display destination sub-address on device Fix DEBUG_HWDEVICE mode: - Fix compilation errors. - Fix control device init in ledger device. - Add more log. Fix sub addr control Fix debug Info
2018-03-05 14:46:15 +01:00
#ifdef DEBUG_HWDEVICE
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
device *debug_device;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
#endif
public:
Add LedgerTCP hardware wallet support This communicates with the Ledger over TCP, which is what the ledger emulator requires. To use, specify: --hw-device LedgerTCP --hw-device-address localhost:9999 to the wallet command-line arguments.
2021-06-25 22:14:00 +02:00
// Constructs a ledger device object that connects to a physical ledger device plugged into
// the system.
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
device_ledger();
Add LedgerTCP hardware wallet support This communicates with the Ledger over TCP, which is what the ledger emulator requires. To use, specify: --hw-device LedgerTCP --hw-device-address localhost:9999 to the wallet command-line arguments.
2021-06-25 22:14:00 +02:00
// Constructs a ledger device object that uses a TCP socket to communicate with the ledger
// device, typically for use with a Ledger emulator which doesn't emulated the USB layer.
explicit device_ledger(io::ledger_tcp&& tcp);
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
~device_ledger();
Add LedgerTCP hardware wallet support This communicates with the Ledger over TCP, which is what the ledger emulator requires. To use, specify: --hw-device LedgerTCP --hw-device-address localhost:9999 to the wallet command-line arguments.
2021-06-25 22:14:00 +02:00
device_ledger(const device_ledger&) = delete ;
device_ledger(device_ledger&&) = delete ;
device_ledger& operator=(const device_ledger&) = delete;
device_ledger&& operator=(device_ledger&&) = delete;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
bool is_hardware_device() const override { return connected(); }
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
bool reset();
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
/* ======================================================================= */
/* SETUP/TEARDOWN */
/* ======================================================================= */
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
bool set_name(std::string_view name) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
Add LedgerTCP hardware wallet support This communicates with the Ledger over TCP, which is what the ledger emulator requires. To use, specify: --hw-device LedgerTCP --hw-device-address localhost:9999 to the wallet command-line arguments.
2021-06-25 22:14:00 +02:00
void set_address(std::string_view addr) override;
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
std::string get_name() const override;
bool init() override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
bool release() override;
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
bool connect() override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
bool disconnect() override;
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
bool connected() const;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
bool set_mode(mode m) override;
query backing device
2018-08-16 10:31:48 +02:00
device: C++ cleanups and modernization - Clean up a bunch of not very nice C and older C++ code in the `device/` tree. - Rename device/device_io_* source files to io_*, and remove their `_io` suffix from the class names (since they are *already* inside an `io` namespace).
2021-06-25 17:07:57 +02:00
type get_type() const override { return type::LEDGER; };
protocol device_protocol() const override { return protocol::PROXY; };
Change mutex lock model to avoid dead lock and ensure locks are always released. Additional cosmetic fixes: move 'name' as protected remove unnecessary local var Fix debug log
2018-03-26 12:38:38 +02:00
/* ======================================================================= */
/* LOCKER */
/* ======================================================================= */
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
void lock() override;
void unlock() override;
bool try_lock() override;
Change mutex lock model to avoid dead lock and ensure locks are always released. Additional cosmetic fixes: move 'name' as protected remove unnecessary local var Fix debug log
2018-03-26 12:38:38 +02:00
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
/* ======================================================================= */
/* WALLET & ADDRESS */
/* ======================================================================= */
bool get_public_address(cryptonote::account_public_address &pubkey) override;
bool get_secret_keys(crypto::secret_key &viewkey , crypto::secret_key &spendkey) override;
wallet: allow adjusting number of rounds for the key derivation function
2018-07-06 08:42:08 +02:00
bool generate_chacha_key(const cryptonote::account_keys &keys, crypto::chacha_key &key, uint64_t kdf_rounds) override;
Post-merge updates: std::optional
2020-06-22 02:17:04 +02:00
void display_address(const cryptonote::subaddress_index& index, const std::optional<crypto::hash8> &payment_id) override;
Ledger support updates Loki-side updates for Ledger Nano S support: - Add a get-network command (and bump protocol version) so that we can verify that the Ledger is set to the correct network type (i.e. mainnet or testnet). Previously there was no check at all, so you could have a testnet wallet on desktop using mainnet keys on the Ledger. Now they get checked and an error occurs on mismatch. - Reset required version to 0.9.0
2020-07-12 04:36:07 +02:00
void set_network_type(cryptonote::network_type network_type) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
/* ======================================================================= */
/* SUB ADDRESS */
/* ======================================================================= */
bool derive_subaddress_public_key(const crypto::public_key &pub, const crypto::key_derivation &derivation, const std::size_t output_index, crypto::public_key &derived_pub) override;
device: made function prototypes consistent with pre-#3303 codebase
2018-03-05 06:24:48 +01:00
crypto::public_key get_subaddress_spend_public_key(const cryptonote::account_keys& keys, const cryptonote::subaddress_index& index) override;
std::vector<crypto::public_key> get_subaddress_spend_public_keys(const cryptonote::account_keys &keys, uint32_t account, uint32_t begin, uint32_t end) override;
cryptonote::account_public_address get_subaddress(const cryptonote::account_keys& keys, const cryptonote::subaddress_index &index) override;
crypto::secret_key get_subaddress_secret_key(const crypto::secret_key &sec, const cryptonote::subaddress_index &index) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
/* ======================================================================= */
/* DERIVATION & KEY */
/* ======================================================================= */
bool verify_keys(const crypto::secret_key &secret_key, const crypto::public_key &public_key) override;
bool scalarmultKey(rct::key & aP, const rct::key &P, const rct::key &a) override;
bool scalarmultBase(rct::key &aG, const rct::key &a) override;
bool sc_secret_add(crypto::secret_key &r, const crypto::secret_key &a, const crypto::secret_key &b) override;
device: made function prototypes consistent with pre-#3303 codebase
2018-03-05 06:24:48 +01:00
crypto::secret_key generate_keys(crypto::public_key &pub, crypto::secret_key &sec, const crypto::secret_key& recovery_key = crypto::secret_key(), bool recover = false) override;
Wallet3 squashed initial commit tx scanning for basic transactions working - TODO: subadresses. The scanning code is there, but it does not currently know/care about any subaddresses. daemon comms for basic syncing working (multi-)wallet sync more or less working properly - seem to have a dangling shared_ptr somewhere when removing a wallet from daemon comms, so not working perfectly yet. Lots of TODOs and cleanup needed, as well as further features of course.
2021-07-19 20:42:38 +02:00
crypto::key_derivation generate_key_derivation(const crypto::public_key &pub, const crypto::secret_key &sec) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
bool generate_key_derivation(const crypto::public_key &pub, const crypto::secret_key &sec, crypto::key_derivation &derivation) override;
device: add a one off override keyword where appropriate
2018-04-13 23:21:43 +02:00
bool conceal_derivation(crypto::key_derivation &derivation, const crypto::public_key &tx_pub_key, const std::vector<crypto::public_key> &additional_tx_pub_keys, const crypto::key_derivation &main_derivation, const std::vector<crypto::key_derivation> &additional_derivations) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
bool derivation_to_scalar(const crypto::key_derivation &derivation, const size_t output_index, crypto::ec_scalar &res) override;
bool derive_secret_key(const crypto::key_derivation &derivation, const std::size_t output_index, const crypto::secret_key &sec, crypto::secret_key &derived_sec) override;
bool derive_public_key(const crypto::key_derivation &derivation, const std::size_t output_index, const crypto::public_key &pub, crypto::public_key &derived_pub) override;
bool secret_key_to_public_key(const crypto::secret_key &sec, crypto::public_key &pub) override;
bool generate_key_image(const crypto::public_key &pub, const crypto::secret_key &sec, crypto::key_image &image) override;
Move key image signature generation into device We don't have access to output private keys, so without this we can't generate staking transactions.
2020-12-04 16:54:33 +01:00
bool generate_key_image_signature(const crypto::key_image& image, const crypto::public_key& pub, const crypto::secret_key& sec, crypto::signature& sig) override;
Ledger: Add stake unlock signature support
2020-12-07 04:17:07 +01:00
bool generate_unlock_signature(const crypto::public_key& pub, const crypto::secret_key& sec, crypto::signature& sig) override;
rebrand lns -> ons
2021-02-12 05:19:30 +01:00
bool generate_ons_signature(std::string_view sig_data, const cryptonote::account_keys& keys, const cryptonote::subaddress_index& index, crypto::signature& sig) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
/* ======================================================================= */
/* TRANSACTION */
/* ======================================================================= */
Add get_tx_proof support, needed for new sanity check Enhance debug info
2019-03-21 17:22:43 +01:00
void generate_tx_proof(const crypto::hash &prefix_hash,
boost::optional -> std::optional
2020-06-02 00:30:19 +02:00
const crypto::public_key &R, const crypto::public_key &A, const std::optional<crypto::public_key> &B, const crypto::public_key &D, const crypto::secret_key &r,
Add get_tx_proof support, needed for new sanity check Enhance debug info
2019-03-21 17:22:43 +01:00
crypto::signature &sig) override;
Fix extracted txversion/txtype
2020-12-07 04:19:20 +01:00
bool open_tx(crypto::secret_key &tx_key, cryptonote::txversion tx_version, cryptonote::txtype tx_type) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
Add timelock verification on device
2020-04-03 22:56:55 +02:00
void get_transaction_prefix_hash(const cryptonote::transaction_prefix& tx, crypto::hash& h) override;
device: made function prototypes consistent with pre-#3303 codebase
2018-03-05 06:24:48 +01:00
bool encrypt_payment_id(crypto::hash8 &payment_id, const crypto::public_key &public_key, const crypto::secret_key &secret_key) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
Add support for V11 protocol with BulletProofV2 and short amount. New scheme key destination contrfol Fix dummy decryption in debug mode
2018-12-11 10:20:21 +01:00
rct::key genCommitmentMask(const rct::key &amount_key) override;
ringct: encode 8 byte amount, saving 24 bytes per output Found by knaccc
2019-01-06 20:49:52 +01:00
bool ecdhEncode(rct::ecdhTuple & unmasked, const rct::key & sharedSec, bool short_format) override;
bool ecdhDecode(rct::ecdhTuple & masked, const rct::key & sharedSec, bool short_format) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
Reformat length function signatures Function signatures (especially in headers) should be readable! Also removes useless "const" on pass-by-value parameters from headers, and pass the bool argument by value instead of by const lvalue reference.
2020-11-26 00:49:42 +01:00
bool generate_output_ephemeral_keys(
size_t tx_version,
bool& found_change,
const cryptonote::account_keys& sender_account_keys,
const crypto::public_key& txkey_pub,
const crypto::secret_key& tx_key,
const cryptonote::tx_destination_entry& dst_entr,
const std::optional<cryptonote::tx_destination_entry>& change_addr,
size_t output_index,
bool need_additional_txkeys,
const std::vector<crypto::secret_key>& additional_tx_keys,
std::vector<crypto::public_key>& additional_tx_public_keys,
std::vector<rct::key>& amount_keys,
crypto::public_key& out_eph_public_key) override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
Remove mlsag generation The blockchain doesn't accept MLSAG txes anymore (since HF16 + 10 blocks), so there is no need to keep the generation code around. Also renames mlsag_prehash to clsag_prehash since that is where it is primarily used now.
2020-11-20 22:50:21 +01:00
bool clsag_prehash(const std::string &blob, size_t inputs_size, size_t outputs_size, const rct::keyV &hashes, const rct::ctkeyV &outPk, rct::key &prehash) override;
draft support of clsag
2020-03-31 17:11:51 +02:00
bool clsag_prepare(const rct::key &p, const rct::key &z, rct::key &I, rct::key &D, const rct::key &H, rct::key &a, rct::key &aG, rct::key &aH) override;
bool clsag_hash(const rct::keyV &data, rct::key &hash) override;
bool clsag_sign(const rct::key &c, const rct::key &a, const rct::key &p, const rct::key &z, const rct::key &mu_P, const rct::key &mu_C, rct::key &s) override;
Don't invoke cryptonote_core functions from device code We can't call cryptonote::add_tx_secret_key_to_tx_extra from `device` code because that isn't necessarily available in `device` (though for some odd reason this only actually showed up on the i386 build). This amends the call to just get the secret key, leaving the actual job of adding it to tx.extra to the caller (which is a cleaner way to do it anyway).
2020-12-14 16:47:46 +01:00
bool update_staking_tx_secret_key(crypto::secret_key& key) override;
draft support of clsag
2020-03-31 17:11:51 +02:00
Improve crappy ledger C++ code Fixes lots of crappy C++ code. I strongly get the impression from these changes that whoever wrote this code was a C programmer with very little C++ experience. Sadly no one in the upstream Monero PR review tried to help or seemed to care about the code quality. - Get rid of superfluous `this->` throughout the ledger code. - DRY: abstract away sending sequences of bytes, replacing: memmove(buffer, this->buffer_send+offset, 32); offset += 32 with: send_bytes(buffer, 32, offset); - DRY: abstract sending/receiving u32 - DRY: abstract receiving bytes/u32 - properly prefix memcpy/memmove with std:: - use std::string_view and std::string for setting/retrieving name - rename `this->controle_device` to `debug_device` - replace `f(void)` -> `f()` (on C++ methods, FFS!) - DRY: replace set-length-then-exchange dance with a function - DRY: merge nearly-identical exchange() and exchange_wait_for_input() - remove never-used ok/mask arguments from exchange() - Remove ASSERT_SW macro used only in one place - Replace dumb ASSERT_X macro that was just an alias for another macro - remove ASSERT_T0 macro that isn't used anywhere
2020-11-28 03:59:45 +01:00
bool close_tx() override;
Code modifications to integrate Ledger HW device into monero-wallet-cli. The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
2018-02-20 17:01:27 +01:00
};
#endif //WITH_DEVICE_LEDGER
}
Reference in a new issue Copy permalink