oxen-io
/
oxen-core
mirror of https://github.com/oxen-io/oxen-core.git
2
1
Fork 0
Code Issues Projects Releases Wiki Activity

Promote SN state change errors to MERROR 

These are quite serious: if they occur there's a good chance that the
local SN state data is wrong.  (At default logging they aren't printed
at all, and really should be).

This also fixes and adds more detail in the the "height is not stored"
error.
This commit is contained in:
Jason Rhinelander 2019-12-02 17:39:05 -04:00
parent f93a0bde3c
commit 20c07f8e8d
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cryptonote_core/service_node_list.cpp
View File

@ -474,14 +474,15 @@ namespace service_nodes
cryptonote::tx_extra_service_node_state_change state_change;
if (!cryptonote::get_service_node_state_change_from_tx_extra(tx.extra, state_change, hf_version))
{
LOG_PRINT_L1("Transaction: " << cryptonote::get_transaction_hash(tx) << ", did not have valid state change data in tx extra rejecting malformed tx");
MERROR("Transaction: " << cryptonote::get_transaction_hash(tx) << ", did not have valid state change data in tx extra rejecting malformed tx");
return false;
}
auto it = state_history.find(state_change.block_height);
if (it == state_history.end())
{
LOG_PRINT_L1("Transaction: " << cryptonote::get_transaction_hash(tx) << ", references quorum at height: " << cryptonote::get_block_hash(block) << ", that is not stored");
MERROR("Transaction: " << cryptonote::get_transaction_hash(tx) << " in block " << cryptonote::get_block_height(block) << " " << cryptonote::get_block_hash(block)
<< " references quorum height " << state_change.block_height << " but that height is not stored!");
return false;
}
@ -507,14 +508,14 @@ namespace service_nodes
if (!quorums)
{
LOG_PRINT_L1("Could not get a quorum that could completely validate the votes from state change in tx: " << get_transaction_hash(tx) << ", skipping transaction");
MERROR("Could not get a quorum that could completely validate the votes from state change in tx: " << get_transaction_hash(tx) << ", skipping transaction");
return false;
}
crypto::public_key key;
if (!get_pubkey_from_quorum(*quorums->obligations, quorum_group::worker, state_change.service_node_index, key))
{
LOG_PRINT_L1("Retrieving the public key from state change in tx: " << cryptonote::get_transaction_hash(tx) << " failed");
MERROR("Retrieving the public key from state change in tx: " << cryptonote::get_transaction_hash(tx) << " failed");
return false;
}

2
src/cryptonote_core/service_node_voting.cpp
View File

@ -223,7 +223,7 @@ namespace service_nodes
crypto::public_key const &key = quorum.validators[vote.validator_index];
if (!crypto::check_signature(hash, key, vote.signature))
{
LOG_PRINT_L1("Invalid signatures for votes");
LOG_PRINT_L1("Invalid signature for voter " << vote.validator_index << "/" << key);
vvc.m_signature_not_valid = true;
return bad_tx(tvc);
}