Add a virtual destructor to http_server_base

Clang warns about http_server having a non-virtual destructor; we aren't
actually doing anything that would cause problems, but the warning is
legit and a correct thing to fix.
This commit is contained in:
Jason Rhinelander 2021-04-19 01:22:50 -03:00
parent d205bc4400
commit 8e39c84e70
2 changed files with 3 additions and 1 deletions

View file

@ -63,7 +63,7 @@ namespace cryptonote::rpc {
std::vector<std::tuple<std::string, uint16_t, bool>> bind // {IP,port,required}
);
~http_server();
~http_server() override;
/// Starts the event loop in the thread handling http requests. Core must have been initialized
/// and OxenMQ started. Will propagate an exception from the thread if startup fails.

View file

@ -64,6 +64,8 @@ namespace cryptonote::rpc {
protected:
virtual ~http_server_base() = default;
virtual void create_rpc_endpoints(uWS::App& http) = 0;
/// handles cors headers by adding any needed headers to the given vector