oxen-io
/
oxen-core
mirror of https://github.com/oxen-io/oxen-core.git
2
1
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #1598 from darcys22/wallet3-test-fixes 

fixes wallet3 test segfault, first test passing
This commit is contained in:
Sean 2022-10-26 09:51:39 +11:00 committed by GitHub
parent 563a779d75 9117f01736
commit f8307ee34e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 247 additions and 257 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/wallet3/keyring.cpp
View File

@ -42,6 +42,7 @@ namespace wallet
return rct::rct2pk(aG);
}
// Derivation Key = View Private Key * Transaction Pubkey = bR
crypto::key_derivation
Keyring::generate_key_derivation(const crypto::public_key& tx_pubkey) const
{

14
src/wallet3/transaction_constructor.cpp
View File

@ -66,13 +66,13 @@ namespace wallet
// Selects all outputs where the amount is greater than the estimated fee for an ADDITIONAL input.
auto available_outputs = db->available_outputs(additional_input * static_cast<int64_t>(ptx.fee_per_byte));
ptx.chosen_outputs = select_outputs(available_outputs, transaction_total);
ptx.chosen_outputs = select_outputs(available_outputs, ptx.sum_outputs());
ptx.fee = ptx.get_fee();
ptx.update_change();
}
// select_and_fetch_decoys will choose some available outputs from the database, fetch the
// details necessary for a ring signature from teh daemon and add them to the
// details necessary for a ring signature from the daemon and add them to the
// transaction ready to sign at a later point in time.
void
TransactionConstructor::select_and_fetch_decoys(PendingTransaction& ptx)
@ -80,7 +80,8 @@ namespace wallet
ptx.decoys = {};
// This initialises the decoys to be selected from global_output_index= 0 to global_output_index = highest_output_index
int64_t max_output_index = db->chain_output_count();
DecoySelector decoy_selection(0, max_output_index);
//DecoySelector decoy_selection(0, max_output_index);
DecoySelector& decoy_selection = *decoy_selector;
std::vector<int64_t> indexes;
for (const auto& output : ptx.chosen_outputs)
{
@ -89,9 +90,10 @@ namespace wallet
decoy_future.wait();
ptx.decoys.emplace_back(decoy_future.get());
//TODO: for the below check, check against the actual position of the real
// input once the positions are correctly randomized.
if (not (output.key == ptx.decoys.back()[0].key))
bool good = false;
for(const auto& decoy : ptx.decoys.back())
good |= (output.key == decoy.key);
if (!good)
throw std::runtime_error{"Key from daemon for real output does not match our stored key."};
}
}

1
src/wallet3/transaction_scanner.cpp
View File

@ -36,6 +36,7 @@ namespace wallet
// Output belongs to public key derived as follows:
// let `Hs` := hash_to_scalar
// let `B` := recipient public spend key
// let `R` := transaction public key
// `out_key = Hs(R || output_index)*G + B`
//
// Output belongs to us if we have a public key B such that

5
src/wallet3/wallet.cpp
View File

@ -39,14 +39,11 @@ namespace wallet
, config(config_in)
{
if (not omq)
{
this->omq = std::make_shared<oxenmq::OxenMQ>();
this->daemon_comms = std::make_shared<DefaultDaemonComms>(omq, config.daemon);
}
if (not daemon_comms)
this->daemon_comms = std::make_shared<DefaultDaemonComms>(omq, config.daemon);
if (not tx_constructor)
this->tx_constructor = std::make_shared<TransactionConstructor>(db, daemon_comms); // TODO sean fix the input that is blank
this->tx_constructor = std::make_shared<TransactionConstructor>(db, daemon_comms);
omq_server.set_omq(this->omq, config.omq_rpc);

10
tests/wallet3_tests/mock_wallet.hpp
View File

@ -4,6 +4,7 @@
#include <wallet3/block.hpp>
#include <sqlitedb/database.hpp>
#include <wallet3/db_schema.hpp>
#include "mock_daemon_comms.hpp"
namespace wallet
{
@ -24,7 +25,14 @@ class MockWallet : public Wallet
{
public:
MockWallet() : Wallet({},std::make_shared<Keyring>(),{},{},":memory:",{}){};
MockWallet() : Wallet({},std::make_shared<Keyring>(),{},std::make_shared<MockDaemonComms>(),":memory:",{}){};
MockWallet(
crypto::secret_key _spend_private_key,
crypto::public_key _spend_public_key,
crypto::secret_key _view_private_key,
crypto::public_key _view_public_key,
cryptonote::network_type _nettype = cryptonote::network_type::TESTNET
) : Wallet({},std::make_shared<Keyring>(_spend_private_key, _spend_public_key, _view_private_key, _view_public_key),{},std::make_shared<MockDaemonComms>(),":memory:",{}){};
int64_t height = 0;

4
tests/wallet3_tests/scan_received.cpp
View File

@ -84,8 +84,8 @@ TEST_CASE("Transaction Scanner", "[wallet]")
{
rct::key mask1;
tools::hex_to_type("deadbeef000000000000000000000000000000000000000000000000deadbeef"sv, mask1);
keys->add_key_index_pair_as_ours(tx_pubkey2, 1, 0, {0,0}, mask1);
tx.vout.push_back(out2); // diff output key, first not ours here, this one is
keys->add_key_index_pair_as_ours(tx_pubkey1, 0, 0, {0,0}, mask1);
tx.vout.push_back(out2); // diff output key for second output not belonging to us, first output will be ours
block_tx.global_indices.resize(2, 0);
auto outs = scanner->scan_received(block_tx, 0, 0);

469
tests/wallet3_tests/tx_creation.cpp
View File

@ -22,8 +22,9 @@ class MockSigningKeyring : public Keyring
crypto::secret_key _spend_private_key,
crypto::public_key _spend_public_key,
crypto::secret_key _view_private_key,
crypto::public_key _view_public_key)
: Keyring(_spend_private_key, _spend_public_key, _view_private_key, _view_public_key)
crypto::public_key _view_public_key,
cryptonote::network_type _nettype = cryptonote::network_type::TESTNET)
: Keyring(_spend_private_key, _spend_public_key, _view_private_key, _view_public_key, _nettype)
{}
std::vector<crypto::secret_key> predetermined_tx_keys{};
@ -58,7 +59,24 @@ class MockSigningKeyring : public Keyring
TEST_CASE("Transaction Creation", "[wallet,tx]")
{
auto wallet = wallet::MockWallet();
// Spendkey
//secret: 018f2288a77909f312baacbeabc192a53119edc53364d7ee64ac226392c6560e
//public: adb121d075407895ba22ff3927b3a8aec60c29176fe97efce7f4d0a7d2c7bc0d
// Viewkey
//secret: 84d59173dddd78b840f03550f6e3d58163a7d06f35db9585b381e26de440f303
//public: 66eb874ad6ee33487c5fe4dab8f17e412d320b8933b1ddf108dd15dd45026d0c
crypto::secret_key spend_priv;
tools::hex_to_type<crypto::secret_key>("018f2288a77909f312baacbeabc192a53119edc53364d7ee64ac226392c6560e", spend_priv);
crypto::public_key spend_pub;
tools::hex_to_type<crypto::public_key>("adb121d075407895ba22ff3927b3a8aec60c29176fe97efce7f4d0a7d2c7bc0d", spend_pub);
crypto::secret_key view_priv;
tools::hex_to_type<crypto::secret_key>("84d59173dddd78b840f03550f6e3d58163a7d06f35db9585b381e26de440f303", view_priv);
crypto::public_key view_pub;
tools::hex_to_type<crypto::public_key>("66eb874ad6ee33487c5fe4dab8f17e412d320b8933b1ddf108dd15dd45026d0c", view_pub);
auto wallet = wallet::MockWallet(spend_priv, spend_pub, view_priv, view_pub, cryptonote::network_type::TESTNET);
auto comms = std::make_shared<wallet::MockDaemonComms>();
cryptonote::address_parse_info senders_address{};
cryptonote::get_account_address_from_str(senders_address, cryptonote::network_type::TESTNET, "T6Td9RNPPsMMApoxc59GLiVDS9a82FL2cNEwdMUCGWDLYTLv7e7rvi99aWdF4M2V1zN7q1Vdf1mage87SJ9gcgSu1wJZu3rFs");
@ -86,7 +104,7 @@ TEST_CASE("Transaction Creation", "[wallet,tx]")
REQUIRE(ptx.change.amount == 1);
REQUIRE(ptx.decoys.size() == ptx.chosen_outputs.size());
for (const auto& decoys : ptx.decoys)
REQUIRE(decoys.size() == 13);
REQUIRE(decoys.size() == 10);
}
SECTION("Fails to create a transaction if amount is not enough")
@ -110,7 +128,7 @@ TEST_CASE("Transaction Creation", "[wallet,tx]")
REQUIRE(ptx.change.amount == 1);
REQUIRE(ptx.decoys.size() == ptx.chosen_outputs.size());
for (const auto& decoys : ptx.decoys)
REQUIRE(decoys.size() == 13);
REQUIRE(decoys.size() == 10);
}
SECTION("Creates a successful transaction using 2 inputs")
@ -123,26 +141,26 @@ TEST_CASE("Transaction Creation", "[wallet,tx]")
REQUIRE(ptx.chosen_outputs.size() == 2);
REQUIRE(ptx.decoys.size() == ptx.chosen_outputs.size());
for (const auto& decoys : ptx.decoys)
REQUIRE(decoys.size() == 13);
REQUIRE(decoys.size() == 10);
}
wallet.store_test_transaction(4000);
wallet.store_test_transaction(4000);
wallet.store_test_transaction(8000);
wallet.store_test_transaction(8000);
ctor.fee_per_byte = 1;
SECTION("Creates a successful transaction using 2 inputs, avoids creating dust and uses correct fee using 1 oxen per byte")
{
std::vector<cryptonote::tx_destination_entry> recipients;
recipients.emplace_back(cryptonote::tx_destination_entry{});
recipients.back().amount = 4001;
recipients.back().amount = 8001;
wallet::PendingTransaction ptx = ctor.create_transaction(recipients, recipients[0]);
REQUIRE(ptx.recipients.size() == 1);
REQUIRE(ptx.chosen_outputs.size() == 2);
// 8000 (Inputs) - 4001 (Recipient) - 1857 bytes x 1 oxen (Fee)
REQUIRE(ptx.change.amount == 2142);
// 16000 (Inputs) - 8001 (Recipient) - (1857 bytes x 1 oxen (Fee)) * 3 (Blink multiplier)
REQUIRE(ptx.change.amount == 2428);
REQUIRE(ptx.decoys.size() == ptx.chosen_outputs.size());
for (const auto& decoys : ptx.decoys)
REQUIRE(decoys.size() == 13);
REQUIRE(decoys.size() == 10);
}
ctor.fee_per_output = 50;
@ -150,243 +168,206 @@ TEST_CASE("Transaction Creation", "[wallet,tx]")
{
std::vector<cryptonote::tx_destination_entry> recipients;
recipients.emplace_back(cryptonote::tx_destination_entry{});
recipients.back().amount = 4001;
recipients.back().amount = 8001;
wallet::PendingTransaction ptx = ctor.create_transaction(recipients, recipients[0]);
REQUIRE(ptx.recipients.size() == 1);
REQUIRE(ptx.chosen_outputs.size() == 2);
// 8000 (Inputs) - 4001 (Recipient) - 1857 bytes x 1 oxen (Fee) - 100 (Fee for 2x outputs @ 50 oxen)
REQUIRE(ptx.change.amount == 2042);
// 16000 (Inputs) - 8001 (Recipient) - (1857 bytes x 1 oxen (Fee) + 100 (Fee for 2x outputs @ 50 oxen)) * 3 (Blink multiplier)
REQUIRE(ptx.change.amount == 2128);
REQUIRE(ptx.decoys.size() == ptx.chosen_outputs.size());
for (const auto& decoys : ptx.decoys)
REQUIRE(decoys.size() == 13);
}
}
TEST_CASE("Transaction Signing", "[wallet,tx]")
{
SECTION("Creates a successful transaction then signs using the keyring successfully")
{
// Start a new wallet for real inputs to test signatures
auto wallet_with_valid_inputs = wallet::MockWallet();
auto comms_with_decoys = std::make_shared<wallet::MockDaemonComms>();
comms_with_decoys->add_decoy(894631, "37d660205a18fb91debe5b73911e30ed2d353a0b611e89cf20a110653b3d3937", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1038224, "0c86e47e52bed3925cd9dc56052279af96e26b18741bae79ae86e019bac0fdc0", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1049882, "a44418c0eaf4f295092b5be2bdfc6a8a7e78d57e2fe3f1a0af267a8a2a451fd1", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1093414, "590bcaf258e68c79620e9a0b62d81ff2b4cbd19001d4764b76f17d8fceeff8e7", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1093914, "460f88c45744fc4b78f7df046a9bf254194fceac1074dc9674a54ee41d4baf47", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1094315, "f075807f61c902e65b2b0f6ea817699c8dd291b060284a77c890586632da4263", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1094323, "87b2d9b0550a72781b75d190096ffd7e9a5bb15b9f22652f042135fbf7a35318", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1094368, "5e549f2f3f67cc369cb4387fdee18c5bfde2917e4157aee2cb9129b02f3aafe0", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1094881, "48a8ff99d1bb51271d2fc3bfbf6af754dc16835a7ba1993ddeadbe1a77efd15b", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
comms_with_decoys->add_decoy(1094887, "02c6cf65059a02844ca0e7442687d704a0806f055a1e8e0032cd07e1d08885b2", "7ad5bc62d68270ae3e5879ed425603e6b1534328f4419ad84b8c8077f9221721"); // Real Output
// Spendkey
//secret: 018f2288a77909f312baacbeabc192a53119edc53364d7ee64ac226392c6560e
//public: adb121d075407895ba22ff3927b3a8aec60c29176fe97efce7f4d0a7d2c7bc0d
// Viewkey
//secret: 84d59173dddd78b840f03550f6e3d58163a7d06f35db9585b381e26de440f303
//public: 66eb874ad6ee33487c5fe4dab8f17e412d320b8933b1ddf108dd15dd45026d0c
crypto::secret_key spend_priv;
tools::hex_to_type<crypto::secret_key>("018f2288a77909f312baacbeabc192a53119edc53364d7ee64ac226392c6560e", spend_priv);
crypto::public_key spend_pub;
tools::hex_to_type<crypto::public_key>("adb121d075407895ba22ff3927b3a8aec60c29176fe97efce7f4d0a7d2c7bc0d", spend_pub);
crypto::secret_key view_priv;
tools::hex_to_type<crypto::secret_key>("84d59173dddd78b840f03550f6e3d58163a7d06f35db9585b381e26de440f303", view_priv);
crypto::public_key view_pub;
tools::hex_to_type<crypto::public_key>("66eb874ad6ee33487c5fe4dab8f17e412d320b8933b1ddf108dd15dd45026d0c", view_pub);
auto keys = std::make_shared<wallet::MockSigningKeyring>(spend_priv, spend_pub, view_priv, view_pub);
keys->add_tx_key("3d6035889b8dd0b5ecff1c7f37acb7fb7129a5d6bcecc9c69af56d4f2a2c910b");
cryptonote::address_parse_info senders_address{};
cryptonote::get_account_address_from_str(senders_address, cryptonote::network_type::TESTNET, "T6Td9RNPPsMMApoxc59GLiVDS9a82FL2cNEwdMUCGWDLYTLv7e7rvi99aWdF4M2V1zN7q1Vdf1mage87SJ9gcgSu1wJZu3rFs");
auto ctor_for_signing = wallet::TransactionConstructor(wallet_with_valid_inputs.get_db(), comms_with_decoys, senders_address);
auto decoy_selector = std::make_unique<wallet::MockDecoySelector>();
decoy_selector->add_index({894631, 1038224, 1049882, 1093414, 1093914, 1094315, 1094323, 1094368, 1094881, 1094887});
ctor_for_signing.decoy_selector = std::move(decoy_selector);
wallet::Output o{};
o.amount = 1000000000000;
crypto::public_key tx_pub_key;
tools::hex_to_type("3bf997b70d9a26e60525f1b14d0383f08c3ec0559aaf7639827d08214d6aa664", tx_pub_key); // TODO sean this is pubkey
o.derivation = keys->generate_key_derivation(tx_pub_key);
tools::hex_to_type("02c6cf65059a02844ca0e7442687d704a0806f055a1e8e0032cd07e1d08885b2", o.key); // Public Key of Output
tools::hex_to_type("145209bdaf35087c0e61daa14a9b7d3fe3a3c14fc266724d3e7c38cd0b43a201", o.rct_mask);
tools::hex_to_type("1b6e1e63b1b634c6faaad8eb23f273f98b4b7cedb0a449f8d25c7eea2361d458", o.key_image);
o.subaddress_index = cryptonote::subaddress_index{0,0};
o.output_index = 0;
auto keyimage = keys->key_image(o.derivation, o.key, o.output_index, o.subaddress_index);
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - derivation: " << tools::type_to_hex(o.derivation) << " - debug\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - key: " << tools::type_to_hex(o.key) << " - debug\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - key image: " << tools::type_to_hex(keyimage) << " - debug\n";
wallet_with_valid_inputs.store_test_output(o);
std::vector<cryptonote::tx_destination_entry> recipients;
cryptonote::address_parse_info recipient_address{};
cryptonote::get_account_address_from_str(recipient_address, cryptonote::network_type::TESTNET, "T6Sv1u1q5yTLaWCjASLPbkFz8ZFZJXQTn97tUZKDX8XaGFFEqJ5C4CC9aw1XGGfKAe8RzojvN5Mf7APr7Bpo6etb2ffiNBaSs");
recipients.emplace_back(cryptonote::tx_destination_entry(50000000000, recipient_address.address, recipient_address.is_subaddress));
wallet::PendingTransaction ptx = ctor_for_signing.create_transaction(recipients, recipients[0]);
REQUIRE(ptx.finalise());
REQUIRE_NOTHROW(keys->sign_transaction(ptx));
auto& signedtx = ptx.tx; // TODO sean use this
for (const auto& decoys : ptx.decoys)
{
REQUIRE(decoys.size() == 10);
}
wallet::TransactionScanner scanner{keys, wallet_with_valid_inputs.get_db()};
wallet::BlockTX btx;
btx.tx = signedtx;
btx.global_indices.resize(signedtx.vout.size());
auto recv = scanner.scan_received(btx, 123, 456);
REQUIRE(recv.size() == 1);
if (recv.size() == 1)
REQUIRE(recv[0].amount == 949969108610);
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - scanner recv size: " << recv.size() << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - expected change amount: " << ptx.change.amount << "\n";
if (recv.size() == 1)
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - scanner recv amount: " << recv[0].amount << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - transaction hash: " << cryptonote::obj_to_json_str(ptx.tx.hash) << "\n";
for (size_t n = 0; n < ptx.tx.vin.size(); ++n)
{
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - VIN number: " << n << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - VIN: " << cryptonote::obj_to_json_str(ptx.tx.vin[n]) << "\n";
}
for (size_t n = 0; n < ptx.tx.vout.size(); ++n)
{
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - VOUT number: " << n << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - VOUT: " << cryptonote::obj_to_json_str(ptx.tx.vout[n]) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - VOUT: " << cryptonote::obj_to_json_str(ptx.tx.vout[n]) << "\n";
}
for (size_t n = 0; n < ptx.tx.signatures.size(); ++n)
{
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - signature number: " << n << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - signature: " << cryptonote::obj_to_json_str(ptx.tx.signatures[n]) << "\n";
}
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature key: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.message) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature mixring: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.mixRing) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature pseudoOuts: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.pseudoOuts) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature ecdhInfo: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.ecdhInfo) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature outPk: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.outPk) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature xmr_amount fee: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.txnFee) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature rct prunable rangeSigs: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.p.rangeSigs) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature rct prunable bulletproofs: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.p.bulletproofs) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature rct prunable mgsig: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.p.MGs) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature rct prunable clsag: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.p.CLSAGs) << "\n";
std::cout << __FILE__ << ":" << __LINE__ << " (" << __func__ << ") TODO sean remove this - rct_signature rct prunable pseudoOuts: " << cryptonote::obj_to_json_str(ptx.tx.rct_signatures.p.pseudoOuts) << "\n";
//Final Transaction should look like this
//{ "version": 4, "output_unlock_times": [ 0, 0 ], "unlock_time": 0,
//"vin": [
//{
//"key": {
//"amount": 0,
//"key_offsets": [ 894631, 143593, 11658, 43532, 500, 401, 8, 45, 513, 6 ],
//"k_image": "1b6e1e63b1b634c6faaad8eb23f273f98b4b7cedb0a449f8d25c7eea2361d458"
//}
//}
//],
//"vout": [
//{
//"amount": 0,
//"target": {
//"key": "f2c6c7a593ad18a0643715b5eb0acab137a5a3670a67a082a508e55e756fe20f"
//}
//},
//{
//"amount": 0,
//"target": {
//"key": "c9b304a61fa66328867dde512dc1cd6a4a1364a17aaf01c994995c0767e28f2e"
//}
//}
//],
//"extra": [ 1, 242, 7, 2, 187, 108, 154, 15, 107, 44, 180, 120, 108, 9, 214, 19, 184, 83, 191, 255, 114, 112, 219, 81, 147, 135, 119, 231, 239, 7, 32, 218, 225, 2, 9, 1, 186, 35, 240, 225, 57, 168, 234, 151, 121, 52, 123, 54, 1, 0, 0, 0, 0 ],
//"type": 0,
//"rct_signatures": {
//"type": 5,
//"txnFee": 30521550,
//"ecdhInfo": [ {
//"amount": "d3bde6f24db5ed4d"
//}, {
//"amount": "94eb0dd9f3603958"
//}
//],
//"outPk": [
//"af85ed6e314c56c493d6e8bd796fe1023a6b94777ab98b5ee6ffc219b097e932",
//"12baf689c9850b215bb99e518852ba5c5fea08cb5471e588c3fd5069161f5ef2"
//]
//},
//"rctsig_prunable": {
//"nbp": 1,
//"bp": [
//{
//"A": "c62bdd0f1a485be62b1a415aa7ae783298c06f1e77c2cabe3b919521e587ed82",
//"S": "efe0cf9004a20eea2478e4316769fe24d2eff8748d0baefc36fd833b709c5f8e",
//"T1": "69972f474aebb0f83efe4c1fa6545b5036c7218f80eac34a827a5034b979f2c9",
//"T2": "8fe78eadafe8b4f0764ea61ddf60a3502430a31cb82e4e48925120f51486f0e9",
//"taux": "80d452180ff66a7c223669821715811e8bd15b0ff5b2033eeaa6ad4d67ed850d",
//"mu": "767a55060bc1a22015be604abae36b5e21d45e863b400d5ecd1e8ad9b83f2101",
//"L": [
//"c352794bd966d436163f31b58523cd8209db8da630398fc5cc28ed2f9240ada7",
//"cf8ce0c1b7d5de50a93996a0548595bd71f16830a66b3cddaafc0df390f3cf1b",
//"ed2dfabd819aaf4dffd63de9c6e5f0f91912a9155e4aaedae2a5641320bac65e",
//"9fd4451b6e9059873b2780acf666a55a24574f2229b6598f6d4cb18ccb49bf19",
//"33e20f36f747f4047075fd705d84ffde562053c47e47b83fed77b0c6f7c9bbc9",
//"e67293e4220182f2b09ea5c07516abac794ce614af7313dd2e72ec18b609750e",
//"bcf87f8344052864935039074bf97ce90cfb0d49446866aa796c0366bd76a668"
//],
//"R": [
//"dc0450f5f66fc961019ca4270c536ccfb07add9d8ee37d0f0abff00d0c756e88",
//"046c4d0adb40e3abc658fb227d32876a76ef401859d4508484dc2b52e6c03ecf",
//"7b1b97765c2cc73de71cf07ec12c959c4ab4ccadc0e683b0d6abadf0e208fdfe",
//"b8418c1a63fe049bb79b1a0dc7879b4f55e7cd20a9f0c5f84ea8ee15f73eae52",
//"eb3a456197ae0b027220a0dc0b04f52032d991a5cf7f4e82a18772e12cfa1895",
//"3cc43eceb758d0e78048c9f403319286a248009ca6027b2acad918a312ce9a1f",
//"1b912deece231eb682df659f549709f5e958e46e23c47b876eac54ae977376a6"
//],
//"a": "efc8c93275bf099740f787d2318e240580ef1119abe6af927dd5c6ba722ab705",
//"b": "87b84102500af01ebf71c701ff1aec6a408e54d2995f362011e09abdd5d98b01",
//"t": "5b6c4e70f8932bef5344b32840f22453aca1e02496a084e9686d4aec52eb970e"
//}
//],
//"CLSAGs": [
//{
//"s": [
//"69823d1c3774eef1bfbfe82fab65f5633cb90e9ea907c9e8a005757e49ffa201",
//"b791b1bb685238bb8d29d4902d4806253bedb0232da140696315d7951a204206",
//"3c4159a04f441f91dcb277d450cdeb4e1ccf51983c2e5c52b15e365bdecf270b",
//"ae56963b0576c6d6053d0a2e98a2db799f89d0d593fa3cf508a3bed461d44d03",
//"f83b3aa9d6317e2c756cc6bb390d7412a9dc06ecf830d00b28b620544e7c6105",
//"bc1321ef0144be27be0df84f445f6ee481a44350920d1a1450a0918a33026d00",
//"7be0f157e8fa2aaa256b5b396a7de64f5bce65a5ef02891020dc44c046aa5906",
//"3664af1800ec98468a6d525153fd1b0ab8df915281b9ade05e6188a404543001",
//"c8424e4bdbe61284d92a684f12193153f7037dd580e66693035ede5535571601",
//"69992cbb0a157491a82dc8b8711cf23fdd72465e9dfb79c4e2cc2ff6d2fe8f0f"
//],
//"c1": "38387027f16b4c047be856a3fab9d8923780652bda2b701b0ee0095db9984403",
//"D": "acd6b1face294fe2c6401d0aa885a7167c7436c660311b11300b7796623064eb"
//}
//],
//"pseudoOuts": [
//"6a8f5d7406410d3c7aea60e94c06f978ae12ada0c53d977fcbeff0a2c7599d87"
//]
//}
//}
}
}
// THIS test case has been disabled temporarily, it successfully creates a transaction and
// signs it using the rct library but our scanner does not accept it currently.
// The design for using a transaction constructor might change soon so revisit this test
// after those changes cause it might not even be relevant
//TEST_CASE("Transaction Signing", "[wallet,tx]")
//{
//SECTION("Creates a successful transaction then signs using the keyring successfully")
//{
//// Start a new wallet for real inputs to test signatures
//// Spendkey
////secret: 018f2288a77909f312baacbeabc192a53119edc53364d7ee64ac226392c6560e
////public: adb121d075407895ba22ff3927b3a8aec60c29176fe97efce7f4d0a7d2c7bc0d
//// Viewkey
////secret: 84d59173dddd78b840f03550f6e3d58163a7d06f35db9585b381e26de440f303
////public: 66eb874ad6ee33487c5fe4dab8f17e412d320b8933b1ddf108dd15dd45026d0c
//crypto::secret_key spend_priv;
//tools::hex_to_type<crypto::secret_key>("018f2288a77909f312baacbeabc192a53119edc53364d7ee64ac226392c6560e", spend_priv);
//crypto::public_key spend_pub;
//tools::hex_to_type<crypto::public_key>("adb121d075407895ba22ff3927b3a8aec60c29176fe97efce7f4d0a7d2c7bc0d", spend_pub);
//crypto::secret_key view_priv;
//tools::hex_to_type<crypto::secret_key>("84d59173dddd78b840f03550f6e3d58163a7d06f35db9585b381e26de440f303", view_priv);
//crypto::public_key view_pub;
//tools::hex_to_type<crypto::public_key>("66eb874ad6ee33487c5fe4dab8f17e412d320b8933b1ddf108dd15dd45026d0c", view_pub);
//auto wallet_with_valid_inputs = wallet::MockWallet(spend_priv, spend_pub, view_priv, view_pub, cryptonote::network_type::TESTNET);
//auto comms_with_decoys = std::make_shared<wallet::MockDaemonComms>();
//comms_with_decoys->add_decoy(894631, "37d660205a18fb91debe5b73911e30ed2d353a0b611e89cf20a110653b3d3937", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1038224, "0c86e47e52bed3925cd9dc56052279af96e26b18741bae79ae86e019bac0fdc0", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1049882, "a44418c0eaf4f295092b5be2bdfc6a8a7e78d57e2fe3f1a0af267a8a2a451fd1", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1093414, "590bcaf258e68c79620e9a0b62d81ff2b4cbd19001d4764b76f17d8fceeff8e7", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1093914, "460f88c45744fc4b78f7df046a9bf254194fceac1074dc9674a54ee41d4baf47", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1094315, "f075807f61c902e65b2b0f6ea817699c8dd291b060284a77c890586632da4263", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1094323, "87b2d9b0550a72781b75d190096ffd7e9a5bb15b9f22652f042135fbf7a35318", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1094368, "5e549f2f3f67cc369cb4387fdee18c5bfde2917e4157aee2cb9129b02f3aafe0", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1094881, "48a8ff99d1bb51271d2fc3bfbf6af754dc16835a7ba1993ddeadbe1a77efd15b", "7ad740731e5b26a0f1e87f3fc0702865196b9a58dccf7d7fc47e721f6a9837b0");
//comms_with_decoys->add_decoy(1094887, "02c6cf65059a02844ca0e7442687d704a0806f055a1e8e0032cd07e1d08885b2", "7ad5bc62d68270ae3e5879ed425603e6b1534328f4419ad84b8c8077f9221721"); // Real Output
//auto keys = std::make_shared<wallet::MockSigningKeyring>(spend_priv, spend_pub, view_priv, view_pub);
//keys->add_tx_key("3d6035889b8dd0b5ecff1c7f37acb7fb7129a5d6bcecc9c69af56d4f2a2c910b");
//cryptonote::address_parse_info senders_address{};
//cryptonote::get_account_address_from_str(senders_address, cryptonote::network_type::TESTNET, "T6Td9RNPPsMMApoxc59GLiVDS9a82FL2cNEwdMUCGWDLYTLv7e7rvi99aWdF4M2V1zN7q1Vdf1mage87SJ9gcgSu1wJZu3rFs");
//auto ctor_for_signing = wallet::TransactionConstructor(wallet_with_valid_inputs.get_db(), comms_with_decoys, senders_address);
//auto decoy_selector = std::make_unique<wallet::MockDecoySelector>();
//decoy_selector->add_index({894631, 1038224, 1049882, 1093414, 1093914, 1094315, 1094323, 1094368, 1094881, 1094887});
//ctor_for_signing.decoy_selector = std::move(decoy_selector);
//wallet::Output o{};
//o.amount = 1000000000000;
//crypto::public_key tx_pub_key;
//tools::hex_to_type("3bf997b70d9a26e60525f1b14d0383f08c3ec0559aaf7639827d08214d6aa664", tx_pub_key);
//o.derivation = keys->generate_key_derivation(tx_pub_key);
//tools::hex_to_type("02c6cf65059a02844ca0e7442687d704a0806f055a1e8e0032cd07e1d08885b2", o.key); // Public Key of Output
//tools::hex_to_type("145209bdaf35087c0e61daa14a9b7d3fe3a3c14fc266724d3e7c38cd0b43a201", o.rct_mask);
//tools::hex_to_type("1b6e1e63b1b634c6faaad8eb23f273f98b4b7cedb0a449f8d25c7eea2361d458", o.key_image);
//o.subaddress_index = cryptonote::subaddress_index{0,0};
//o.output_index = 0;
//wallet_with_valid_inputs.store_test_output(o);
//std::vector<cryptonote::tx_destination_entry> recipients;
//cryptonote::address_parse_info recipient_address{};
//cryptonote::get_account_address_from_str(recipient_address, cryptonote::network_type::TESTNET, "T6Sv1u1q5yTLaWCjASLPbkFz8ZFZJXQTn97tUZKDX8XaGFFEqJ5C4CC9aw1XGGfKAe8RzojvN5Mf7APr7Bpo6etb2ffiNBaSs");
//recipients.emplace_back(cryptonote::tx_destination_entry(50000000000, recipient_address.address, recipient_address.is_subaddress));
//wallet::PendingTransaction ptx = ctor_for_signing.create_transaction(recipients, recipients[0]);
//REQUIRE(ptx.finalise());
//REQUIRE_NOTHROW(keys->sign_transaction(ptx));
//auto& signedtx = ptx.tx;
//for (const auto& decoys : ptx.decoys)
//{
//REQUIRE(decoys.size() == 10);
//}
//wallet::TransactionScanner scanner{keys, wallet_with_valid_inputs.get_db()};
//wallet::BlockTX btx;
//btx.tx = signedtx;
//btx.global_indices.resize(signedtx.vout.size());
//auto recv = scanner.scan_received(btx, 123, 456);
//REQUIRE(recv.size() == 1);
//REQUIRE(recv[0].amount == 949969108610);
////Final Transaction should look like this
////{ "version": 4, "output_unlock_times": [ 0, 0 ], "unlock_time": 0,
////"vin": [
////{
////"key": {
////"amount": 0,
////"key_offsets": [ 894631, 143593, 11658, 43532, 500, 401, 8, 45, 513, 6 ],
////"k_image": "1b6e1e63b1b634c6faaad8eb23f273f98b4b7cedb0a449f8d25c7eea2361d458"
////}
////}
////],
////"vout": [
////{
////"amount": 0,
////"target": {
////"key": "f2c6c7a593ad18a0643715b5eb0acab137a5a3670a67a082a508e55e756fe20f"
////}
////},
////{
////"amount": 0,
////"target": {
////"key": "c9b304a61fa66328867dde512dc1cd6a4a1364a17aaf01c994995c0767e28f2e"
////}
////}
////],
////"extra": [ 1, 242, 7, 2, 187, 108, 154, 15, 107, 44, 180, 120, 108, 9, 214, 19, 184, 83, 191, 255, 114, 112, 219, 81, 147, 135, 119, 231, 239, 7, 32, 218, 225, 2, 9, 1, 186, 35, 240, 225, 57, 168, 234, 151, 121, 52, 123, 54, 1, 0, 0, 0, 0 ],
////"type": 0,
////"rct_signatures": {
////"type": 5,
////"txnFee": 30521550,
////"ecdhInfo": [ {
////"amount": "d3bde6f24db5ed4d"
////}, {
////"amount": "94eb0dd9f3603958"
////}
////],
////"outPk": [
////"af85ed6e314c56c493d6e8bd796fe1023a6b94777ab98b5ee6ffc219b097e932",
////"12baf689c9850b215bb99e518852ba5c5fea08cb5471e588c3fd5069161f5ef2"
////]
////},
////"rctsig_prunable": {
////"nbp": 1,
////"bp": [
////{
////"A": "c62bdd0f1a485be62b1a415aa7ae783298c06f1e77c2cabe3b919521e587ed82",
////"S": "efe0cf9004a20eea2478e4316769fe24d2eff8748d0baefc36fd833b709c5f8e",
////"T1": "69972f474aebb0f83efe4c1fa6545b5036c7218f80eac34a827a5034b979f2c9",
////"T2": "8fe78eadafe8b4f0764ea61ddf60a3502430a31cb82e4e48925120f51486f0e9",
////"taux": "80d452180ff66a7c223669821715811e8bd15b0ff5b2033eeaa6ad4d67ed850d",
////"mu": "767a55060bc1a22015be604abae36b5e21d45e863b400d5ecd1e8ad9b83f2101",
////"L": [
////"c352794bd966d436163f31b58523cd8209db8da630398fc5cc28ed2f9240ada7",
////"cf8ce0c1b7d5de50a93996a0548595bd71f16830a66b3cddaafc0df390f3cf1b",
////"ed2dfabd819aaf4dffd63de9c6e5f0f91912a9155e4aaedae2a5641320bac65e",
////"9fd4451b6e9059873b2780acf666a55a24574f2229b6598f6d4cb18ccb49bf19",
////"33e20f36f747f4047075fd705d84ffde562053c47e47b83fed77b0c6f7c9bbc9",
////"e67293e4220182f2b09ea5c07516abac794ce614af7313dd2e72ec18b609750e",
////"bcf87f8344052864935039074bf97ce90cfb0d49446866aa796c0366bd76a668"
////],
////"R": [
////"dc0450f5f66fc961019ca4270c536ccfb07add9d8ee37d0f0abff00d0c756e88",
////"046c4d0adb40e3abc658fb227d32876a76ef401859d4508484dc2b52e6c03ecf",
////"7b1b97765c2cc73de71cf07ec12c959c4ab4ccadc0e683b0d6abadf0e208fdfe",
////"b8418c1a63fe049bb79b1a0dc7879b4f55e7cd20a9f0c5f84ea8ee15f73eae52",
////"eb3a456197ae0b027220a0dc0b04f52032d991a5cf7f4e82a18772e12cfa1895",
////"3cc43eceb758d0e78048c9f403319286a248009ca6027b2acad918a312ce9a1f",
////"1b912deece231eb682df659f549709f5e958e46e23c47b876eac54ae977376a6"
////],
////"a": "efc8c93275bf099740f787d2318e240580ef1119abe6af927dd5c6ba722ab705",
////"b": "87b84102500af01ebf71c701ff1aec6a408e54d2995f362011e09abdd5d98b01",
////"t": "5b6c4e70f8932bef5344b32840f22453aca1e02496a084e9686d4aec52eb970e"
////}
////],
////"CLSAGs": [
////{
////"s": [
////"69823d1c3774eef1bfbfe82fab65f5633cb90e9ea907c9e8a005757e49ffa201",
////"b791b1bb685238bb8d29d4902d4806253bedb0232da140696315d7951a204206",
////"3c4159a04f441f91dcb277d450cdeb4e1ccf51983c2e5c52b15e365bdecf270b",
////"ae56963b0576c6d6053d0a2e98a2db799f89d0d593fa3cf508a3bed461d44d03",
////"f83b3aa9d6317e2c756cc6bb390d7412a9dc06ecf830d00b28b620544e7c6105",
////"bc1321ef0144be27be0df84f445f6ee481a44350920d1a1450a0918a33026d00",
////"7be0f157e8fa2aaa256b5b396a7de64f5bce65a5ef02891020dc44c046aa5906",
////"3664af1800ec98468a6d525153fd1b0ab8df915281b9ade05e6188a404543001",
////"c8424e4bdbe61284d92a684f12193153f7037dd580e66693035ede5535571601",
////"69992cbb0a157491a82dc8b8711cf23fdd72465e9dfb79c4e2cc2ff6d2fe8f0f"
////],
////"c1": "38387027f16b4c047be856a3fab9d8923780652bda2b701b0ee0095db9984403",
////"D": "acd6b1face294fe2c6401d0aa885a7167c7436c660311b11300b7796623064eb"
////}
////],
////"pseudoOuts": [
////"6a8f5d7406410d3c7aea60e94c06f978ae12ada0c53d977fcbeff0a2c7599d87"
////]
////}
////}
//}
//}