oxen-core/src/cryptonote_basic/verification_context.h
Jason Rhinelander a3ebf5eba6 Reward fudge factor (#867)
* Add a 1 atomic unit fudge factor on reward calculations

If the thread's rounding mode is different (because RandomX changed it
in the current thread or in the thread that generated the block) then
the reward calculation can be up to 1 atomic unit off.  This lets those
pass rather than rejecting the block.

(I tested LOKI's reward calculations up to height 10M to verify that the
maximum error in reward values is never off by more than 1).

* Remove partial_block_reward

This variable is not actually used anywhere.

* Add 1ULP tolerance for SN reward checks

* Rewrite confusing logic and error

- fix the broken error message which was printing "base(base+fees)" instead
  of "total(base+fees)".
- improve the error message wording to actually indicate what the values
  signify.
- don't use base_reward as a temporary value (the intermediate value
  assigned to it is completely replaced later anyway).
- use some better variable names to describe what is happening here

* Add check for overflow
2019-10-04 13:57:14 +10:00

118 lines
4.3 KiB
C++

// Copyright (c) 2014-2019, The Monero Project
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without modification, are
// permitted provided that the following conditions are met:
//
// 1. Redistributions of source code must retain the above copyright notice, this list of
// conditions and the following disclaimer.
//
// 2. Redistributions in binary form must reproduce the above copyright notice, this list
// of conditions and the following disclaimer in the documentation and/or other
// materials provided with the distribution.
//
// 3. Neither the name of the copyright holder nor the names of its contributors may be
// used to endorse or promote products derived from this software without specific
// prior written permission.
//
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY
// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
//
// Parts of this file are originally copyright (c) 2012-2013 The Cryptonote developers
#pragma once
#include "serialization/keyvalue_serialization.h"
namespace cryptonote
{
/************************************************************************/
/* */
/************************************************************************/
struct vote_verification_context
{
bool m_verification_failed;
bool m_invalid_block_height;
bool m_duplicate_voters;
bool m_validator_index_out_of_bounds;
bool m_worker_index_out_of_bounds;
bool m_signature_not_valid;
bool m_added_to_pool;
bool m_not_enough_votes;
bool m_incorrect_voting_group;
bool m_invalid_vote_type;
bool m_votes_not_sorted;
BEGIN_KV_SERIALIZE_MAP()
KV_SERIALIZE(m_verification_failed)
KV_SERIALIZE(m_invalid_block_height)
KV_SERIALIZE(m_duplicate_voters)
KV_SERIALIZE(m_validator_index_out_of_bounds)
KV_SERIALIZE(m_worker_index_out_of_bounds)
KV_SERIALIZE(m_signature_not_valid)
KV_SERIALIZE(m_added_to_pool)
KV_SERIALIZE(m_not_enough_votes)
KV_SERIALIZE(m_incorrect_voting_group)
KV_SERIALIZE(m_invalid_vote_type)
KV_SERIALIZE(m_votes_not_sorted)
END_KV_SERIALIZE_MAP()
};
struct tx_verification_context
{
bool m_should_be_relayed;
bool m_verifivation_failed; //bad tx, should drop connection
bool m_verifivation_impossible; //the transaction is related with an alternative blockchain
bool m_added_to_pool;
bool m_low_mixin;
bool m_double_spend;
bool m_invalid_input;
bool m_invalid_output;
bool m_too_big;
bool m_overspend;
bool m_fee_too_low;
bool m_not_rct;
bool m_invalid_version;
bool m_invalid_type;
bool m_key_image_locked_by_snode;
bool m_key_image_blacklisted;
vote_verification_context m_vote_ctx;
BEGIN_KV_SERIALIZE_MAP()
KV_SERIALIZE(m_should_be_relayed)
KV_SERIALIZE(m_verifivation_failed)
KV_SERIALIZE(m_verifivation_impossible)
KV_SERIALIZE(m_added_to_pool)
KV_SERIALIZE(m_low_mixin)
KV_SERIALIZE(m_double_spend)
KV_SERIALIZE(m_invalid_input)
KV_SERIALIZE(m_invalid_output)
KV_SERIALIZE(m_too_big)
KV_SERIALIZE(m_overspend)
KV_SERIALIZE(m_fee_too_low)
KV_SERIALIZE(m_not_rct)
KV_SERIALIZE(m_invalid_version)
KV_SERIALIZE(m_invalid_type);
KV_SERIALIZE(m_key_image_locked_by_snode);
KV_SERIALIZE(m_key_image_blacklisted);
KV_SERIALIZE(m_vote_ctx)
END_KV_SERIALIZE_MAP()
};
struct block_verification_context
{
bool m_added_to_main_chain;
bool m_verifivation_failed; //bad block, should drop connection
bool m_marked_as_orphaned;
bool m_already_exists;
};
}