mirror of
https://github.com/oxen-io/oxen-core.git
synced 2023-12-14 02:22:56 +01:00
5e95cef882
openssl is a miserable dependency to fight with, especially for
iOS/Android, and we use it for very little:
- it gets (mis)used to write base64 data to a file in wallet2 for things
like multisig data. However this mode is *not* enabled by default,
basically completely unknown, completely unused, only exists in the
cli wallet, and is just dumb. (Honestly the justification given in
the PR is that "Windows users might want it", presupposing that there
exists Windows users who are capable of generating a multisig wallet
in a CLI-only application and yet are incapable of dealing with binary
files).
- it's a dependency of unbound (in order to do dnssec, I believe).
Unbound itself is fairly useless for Oxen, so I've removed it too:
- it does OpenAlias lookups, which are a Monero thing that has never
been used outside Monero, doesn't work reliably (because it fails
if the result isn't DNSSEC validated) and is pointless when we
have ONS.
- it does DNS resolution on seed nodes, but we have never set seed
nodes by name and just use seed node IPs instead (which seems a
bit better anyway since the DNS lookup leaks some metadata).
- it *was* being used for sha256, but an earlier commit in this PR
already replaced that with libsodium (entirely coincidentally).
- for static deps, it enables HTTPS support for the wallet. However
only the CLI wallet actually supports this (the GUI and mobile wallets
don't), and since oxend hasn't support this for a while I have strong
doubts it is being used anywhere. (Plus wallet3 will do everything
encrypted using zmq/libsodium, so doesn't need this to be secure).
Note here that it is *only* removed by this commit for static builds:
if doing a system build that links to libcurl supporting HTTPS then
HTTPS support will still work.
Libexpat is also gone because it was only there for libunbound.
|
||
|---|---|---|
| .. | ||
| 32-bit-toolchain.cmake | ||
| 64-bit-toolchain.cmake | ||
| check_for_std_filesystem.cmake | ||
| CheckLinkerFlag.c | ||
| CheckLinkerFlag.cmake | ||
| CheckTrezor.cmake | ||
| DownloadLibSodium.cmake | ||
| Doxyfile.in | ||
| Doxygen.extra.css.in | ||
| FindBacktrace.cmake | ||
| FindHIDAPI.cmake | ||
| FindLibunwind.cmake | ||
| FindLibUSB.cmake | ||
| FindReadline.cmake | ||
| GenVersion.cmake | ||
| ios.toolchain.cmake | ||
| StaticBuild.cmake | ||
| test-libusb-version.c | ||
| test-protobuf.cpp | ||
| test-protobuf.proto | ||
| test-static-assert.c | ||
| Version.cmake | ||