mirror of https://github.com/oxen-io/oxen-core.git
fb0aff57f6
In short: epee's http client is garbage, standard violating, and
unreliable.
This completely removes the epee http client support and replaces it
with cpr, a curl-based C++ wrapper. rpc/http_client.h wraps cpr for RPC
requests specifically, but it is also usable directly.
This replacement has a number of advantages:
- requests are considerably more reliable. The epee http client code
assumes that a connection will be kept alive forever, and returns a
failure if a connection is ever closed. This results in some very
annoying things: for example, preparing a transaction and then waiting
a long tim before confirming it will usually result in an error
communication with the daemon. This is just terribly behaviour: the
right thing to do on a connection failure is to resubmit the request.
- epee's http client is broken in lots of other ways: for example, it
tries throwing SSL at the port to see if it is HTTPS, but this is
protocol violating and just breaks (with a several second timeout) on
anything that *isn't* epee http server (for example, when lokid is
behind a proxying server).
- even when it isn't doing the above, the client breaks in other ways:
for example, there is a comment (replaced in this PR) in the Trezor PR
code that forces a connection close after every request because epee's
http client doesn't do proper keep-alive request handling.
- it seems noticeably faster to me in practical use in this PR; both
simple requests (for example, when running `lokid status`) and
wallet<->daemon connections are faster, probably because of crappy
code in epee. (I think this is also related to the throw-ssl-at-it
junk above: the epee client always generates an ssl certificate during
static initialization because it might need one at some point).
- significantly reduces the amount of code we have to maintain.
- removes all the epee ssl option code: curl can handle all of that just
fine.
- removes the epee socks proxy code; curl can handle that just fine.
(And can do more: it also supports using HTTP/HTTPS proxies).
- When a cli wallet connection fails we know show why it failed (which
now is an error message from curl), which could have all sorts of
reasons like hostname resolution failure, bad ssl certificate, etc.
Previously you just got a useless generic error that tells you
nothing.
Other related changes in this PR:
- Drops the check-for-update and download-update code. To the best of
my knowledge these have never been supported in loki-core and so it
didn't seem worth the trouble to convert them to use cpr for the
requests.
- Cleaned up node_rpc_proxy return values: there was an inconsistent mix
of ways to return errors and how the returned strings were handled.
Instead this cleans it up to return a pair<bool, val>, which (with
C++17) can be transparently captured as:
auto [success, val] = node.whatever(req);
This drops the failure message string, but it was almost always set to
something fairly useless (if we want to resurrect it we could easily
change the first element to be a custom type with a bool operator for
success, and a `.error` attribute containing some error string, but
for the most part the current code wasn't doing much useful with the
failure string).
- changed local detection (for automatic trusted daemon determination)
to just look for localhost, and to not try to resolve anything.
Trusting non-public IPs does not work well (e.g. with lokinet where
all .loki addresses resolve to a local IP).
- ssl fingerprint option is removed; this isn't supported by curl
(because it is essentially just duplicating what a custom cainfo
bundle does)
- --daemon-ssl-allow-chained is removed; it wasn't a useful option (if
you don't want chaining, don't specify a cainfo chain).
- --daemon-address is now a URL instead of just host:port. (If you omit
the protocol, http:// is prepended).
- --daemon-host and --daemon-port are now deprecated and produce a
warning (in simplewallet) if used; the replacement is to use
--daemon-address.
- --daemon-ssl is deprecated; specify --daemon-address=https://whatever
instead.
- the above three are now hidden from --help
- reordered the wallet connection options to make more logical sense.
|
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| account.cpp | ||
| address_from_url.cpp | ||
| aligned.cpp | ||
| apply_permutation.cpp | ||
| base58.cpp | ||
| block_queue.cpp | ||
| block_reward.cpp | ||
| blockchain_db.cpp | ||
| bulletproofs.cpp | ||
| chacha.cpp | ||
| checkpoints.cpp | ||
| command_line.cpp | ||
| crypto.cpp | ||
| device.cpp | ||
| difficulty.cpp | ||
| dns_resolver.cpp | ||
| epee_boosted_tcp_server.cpp | ||
| epee_levin_protocol_handler_async.cpp | ||
| epee_utils.cpp | ||
| expect.cpp | ||
| get_xtype_from_string.cpp | ||
| hardfork.cpp | ||
| hashchain.cpp | ||
| hmac_keccak.cpp | ||
| http.cpp | ||
| is_hdd.cpp | ||
| json_serialization.cpp | ||
| keccak.cpp | ||
| levin.cpp | ||
| lmdb.cpp | ||
| logging.cpp | ||
| loki_name_system.cpp | ||
| long_term_block_weight.cpp | ||
| main.cpp | ||
| memwipe.cpp | ||
| mlocker.cpp | ||
| mnemonics.cpp | ||
| mul_div.cpp | ||
| multiexp.cpp | ||
| multisig.cpp | ||
| net.cpp | ||
| node_server.cpp | ||
| notify.cpp | ||
| output_distribution.cpp | ||
| output_selection.cpp | ||
| parse_amount.cpp | ||
| pruning.cpp | ||
| random.cpp | ||
| ringct.cpp | ||
| ringdb.cpp | ||
| rolling_median.cpp | ||
| serialization.cpp | ||
| service_nodes.cpp | ||
| service_nodes_swarm.cpp | ||
| sha256.cpp | ||
| string_util.cpp | ||
| subaddress.cpp | ||
| test_notifier.cpp | ||
| test_peerlist.cpp | ||
| test_protocol_pack.cpp | ||
| test_tx_utils.cpp | ||
| testdb.h | ||
| threadpool.cpp | ||
| unbound.cpp | ||
| unit_tests_utils.h | ||
| uri.cpp | ||
| varint.cpp | ||
| vercmp.cpp | ||
| wipeable_string.cpp | ||