address PR comments

This commit is contained in:
Kyle Zsembery 2020-09-04 15:14:16 +10:00
parent 2c0ad5c407
commit 9beafe4f5d
2 changed files with 2 additions and 6 deletions

View file

@ -18,6 +18,7 @@ Please submit any changes as pull requests to the development branch, all change
#### Pre-requisites #### Pre-requisites
- Download latest [Lokid](https://github.com/loki-project/loki/releases/latest) - Download latest [Lokid](https://github.com/loki-project/loki/releases/latest)
- Extract the lokid binaries to a folder
#### Commands #### Commands
@ -26,7 +27,6 @@ nvm use 11.9.0
npm install -g quasar-cli npm install -g quasar-cli
git clone https://github.com/loki-project/loki-electron-gui-wallet git clone https://github.com/loki-project/loki-electron-gui-wallet
cd loki-electron-wallet cd loki-electron-wallet
// the binaries are what was downloaded in the prequisite step
cp path_to_lokid_binaries/lokid bin/ cp path_to_lokid_binaries/lokid bin/
cp path_to_lokid_binaries/loki-wallet-rpc bin/ cp path_to_lokid_binaries/loki-wallet-rpc bin/
npm install npm install

View file

@ -314,11 +314,7 @@ export class Backend {
const vSizeDiff = semver.diff(version, latestVersion); const vSizeDiff = semver.diff(version, latestVersion);
const updateAvailable = semver.ltr(version, latestVersion); const updateAvailable = semver.ltr(version, latestVersion);
const majorOrMinor = vSizeDiff === "major" || vSizeDiff == "minor"; const majorOrMinor = vSizeDiff === "major" || vSizeDiff == "minor";
let updateRequired = false; const updateRequired = updateAvailable && majorOrMinor;
if (updateAvailable && majorOrMinor) {
updateRequired = true;
}
this.send("set_update_required", { required: updateRequired, latest_version: latestVersion }); this.send("set_update_required", { required: updateRequired, latest_version: latestVersion });
} catch (e) { } catch (e) {
this.send("set_updated_required", { required: false, latest_version: "Unknown" }); this.send("set_updated_required", { required: false, latest_version: "Unknown" });