mirror of
https://github.com/oxen-io/oxen-mq.git
synced 2023-12-13 21:00:31 +01:00
edcde9246a
MAX_SOCKETS wasn't working properly because ZMQ uses it when the context is initialized, which happens when the first socket is constructed on that context. For OxenMQ, we had several sockets constructed on the context during OxenMQ construction, which meant the context_t was being initialized during OxenMQ construction, rather than during start(), and so setting MAX_SOCKETS would have no effect and you'd always get the default. This fixes it by making all the member variable zmq::socket_t's default-constructed, then replacing them with proper zmq::socket_t's during startup() so that we also defer zmq::context_t initialization to the right place. A second issue found during testing (also fixed here) is that the socket worker threads use to communicate to the proxy could fail if the worker socket creation would violate the zmq max sockets limit, which wound up throwing an uncaught exception and aborting. This pre-initializes (but doesn't connect) all potential worker threads sockets during start() so that the lazily-initialized worker thread will have one already set up rather than having to create a new one (which could fail).
44 lines
1.2 KiB
C++
44 lines
1.2 KiB
C++
#include "common.h"
|
|
#include <oxenc/hex.h>
|
|
|
|
using namespace oxenmq;
|
|
|
|
TEST_CASE("zmq socket limit", "[zmq][socket-limit]") {
|
|
// Make sure setting .MAX_SOCKETS works as expected. (This test was added when a bug was fixed
|
|
// that was causing it not to be applied).
|
|
std::string listen = random_localhost();
|
|
OxenMQ server{
|
|
"", "", // generate ephemeral keys
|
|
false, // not a service node
|
|
[](auto) { return ""; },
|
|
};
|
|
server.listen_plain(listen);
|
|
server.start();
|
|
|
|
std::atomic<int> failed = 0, good = 0, failed_toomany = 0;
|
|
OxenMQ client;
|
|
client.MAX_SOCKETS = 15;
|
|
client.start();
|
|
|
|
std::vector<ConnectionID> conns;
|
|
address server_addr{listen};
|
|
for (int i = 0; i < 16; i++)
|
|
client.connect_remote(server_addr,
|
|
[&](auto) { good++; },
|
|
[&](auto cid, auto msg) {
|
|
if (msg == "connect() failed: Too many open files")
|
|
failed_toomany++;
|
|
else
|
|
failed++;
|
|
});
|
|
|
|
|
|
wait_for([&] { return good > 0 && failed_toomany > 0; });
|
|
{
|
|
auto lock = catch_lock();
|
|
REQUIRE( good > 0 );
|
|
REQUIRE( failed == 0 );
|
|
REQUIRE( failed_toomany > 0 );
|
|
}
|
|
}
|