timestamp & duplicated message

app/src/main/java/org/thoughtcrime/securesms/database/MmsSmsDatabase.java

@@ -78,6 +78,14 @@ public class MmsSmsDatabase extends Database {
     super(context, databaseHelper);
   }
 
+  public @Nullable MessageRecord getMessageForTimestamp(long timestamp) {
+    MmsSmsDatabase db = DatabaseFactory.getMmsSmsDatabase(context);
+    try (Cursor cursor = queryTables(PROJECTION, MmsSmsColumns.NORMALIZED_DATE_SENT + " = " + timestamp, null, null)) {
+      MmsSmsDatabase.Reader reader = db.readerFor(cursor);
+      return reader.getNext();
+    }
+  }
+
   public @Nullable MessageRecord getMessageFor(long messageId) {
     MmsSmsDatabase db = DatabaseFactory.getMmsSmsDatabase(context);
 

app/src/main/java/org/thoughtcrime/securesms/database/Storage.kt

@@ -33,6 +33,7 @@ import org.session.libsignal.utilities.logging.Log
 import org.thoughtcrime.securesms.crypto.IdentityKeyUtil
 import org.thoughtcrime.securesms.database.helpers.SQLCipherOpenHelper
 import org.thoughtcrime.securesms.loki.database.LokiThreadDatabase
+import org.thoughtcrime.securesms.loki.protocol.SessionMetaProtocol
 import org.thoughtcrime.securesms.loki.utilities.OpenGroupUtilities
 import org.thoughtcrime.securesms.loki.utilities.get
 import org.thoughtcrime.securesms.loki.utilities.getString
@@ -279,6 +280,15 @@ class Storage(context: Context, helper: SQLCipherOpenHelper) : Database(context,
         DatabaseFactory.getLokiAPIDatabase(context).removeLastDeletionServerID(group, server)
     }
 
+    override fun isMessageDuplicated(timestamp: Long, sender: String): Boolean {
+        val database = DatabaseFactory.getMmsSmsDatabase(context)
+        return if (sender.isEmpty()) {
+            database.getMessageForTimestamp(timestamp) != null
+        } else {
+            database.getMessageFor(timestamp, sender) != null
+        }
+    }
+
     override fun setUserCount(group: Long, server: String, newValue: Int) {
         DatabaseFactory.getLokiAPIDatabase(context).setUserCount(group, server, newValue)
     }
@@ -300,16 +310,16 @@ class Storage(context: Context, helper: SQLCipherOpenHelper) : Database(context,
     }
 
     override fun getReceivedMessageTimestamps(): Set<Long> {
-        TODO("Not yet implemented")
+        return SessionMetaProtocol.getTimestamps()
     }
 
     override fun addReceivedMessageTimestamp(timestamp: Long) {
-        TODO("Not yet implemented")
+        SessionMetaProtocol.addTimestamp(timestamp)
     }
 
-    override fun removeReceivedMessageTimestamps(timestamps: Set<Long>) {
-        TODO("Not yet implemented")
-    }
+//    override fun removeReceivedMessageTimestamps(timestamps: Set<Long>) {
+//        TODO("Not yet implemented")
+//    }
 
     override fun getMessageIdInDatabase(timestamp: Long, author: String): Long? {
         val database = DatabaseFactory.getMmsSmsDatabase(context)

app/src/main/java/org/thoughtcrime/securesms/loki/protocol/SessionMetaProtocol.kt

@@ -21,6 +21,14 @@ object SessionMetaProtocol {
         timestamps.remove(timestamp)
     }
 
+    fun getTimestamps(): Set<Long> {
+        return timestamps
+    }
+
+    fun addTimestamp(timestamp: Long) {
+        timestamps.add(timestamp)
+    }
+
     @JvmStatic
     fun shouldIgnoreMessage(timestamp: Long): Boolean {
         val shouldIgnoreMessage = timestamps.contains(timestamp)

libsession/src/main/java/org/session/libsession/messaging/StorageProtocol.kt

@@ -86,9 +86,10 @@ interface StorageProtocol {
     fun removeLastDeletionServerID(group: Long, server: String)
 
     // Message Handling
+    fun isMessageDuplicated(timestamp: Long, sender: String): Boolean
     fun getReceivedMessageTimestamps(): Set<Long>
     fun addReceivedMessageTimestamp(timestamp: Long)
-    fun removeReceivedMessageTimestamps(timestamps: Set<Long>)
+//    fun removeReceivedMessageTimestamps(timestamps: Set<Long>)
     // Returns the IDs of the saved attachments.
     fun persistAttachments(messageId: Long, attachments: List<Attachment>): List<Long>
 

libsession/src/main/java/org/session/libsession/messaging/sending_receiving/MessageReceiver.kt

@@ -50,7 +50,7 @@ object MessageReceiver {
         // If the message failed to process the first time around we retry it later (if the error is retryable). In this case the timestamp
         // will already be in the database but we don't want to treat the message as a duplicate. The isRetry flag is a simple workaround
         // for this issue.
-        if (storage.getReceivedMessageTimestamps().contains(envelope.timestamp) && !isRetry) throw Error.DuplicateMessage
+        if (storage.isMessageDuplicated(envelope.timestamp, envelope.source) && !isRetry) throw Error.DuplicateMessage
         storage.addReceivedMessageTimestamp(envelope.timestamp)
         // Decrypt the contents
         val ciphertext = envelope.content ?: throw Error.NoData