oxen-io/session-desktop
1
0
Fork 0
mirror of https://github.com/oxen-io/session-desktop.git synced 2023-12-14 02:12:57 +01:00
Code Issues Projects Releases Wiki Activity

disable closedgroup update groups for now

Browse source
This commit is contained in:
Audric Ackermann 2021-02-01 13:14:19 +11:00
parent ebd94ce15c
commit 267a3e6bf6
No known key found for this signature in database
GPG key ID: 999F434D76324AD4
2 changed files with 33 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
ts/session/group/index.ts
View file

@ -262,7 +262,6 @@ export async function updateOrCreateClosedGroup(details: GroupInfo) {
}
updates.left = false;
updates.lastJoinedTimestamp = updates.active_at;
} else {
updates.left = true;
}

69
ts/test/session/unit/receiving/ClosedGroupUpdates_test.ts
View file

@ -20,41 +20,38 @@ const { expect } = chai;
// tslint:disable-next-line: max-func-body-length
describe('ClosedGroupUpdates', () => {
//FIXME AUDRIC TODO
// Initialize new stubbed cache
const sandbox = sinon.createSandbox();
const ourDevice = TestUtils.generateFakePubKey();
const ourNumber = ourDevice.key;
const groupId = TestUtils.generateFakePubKey().key;
const members = TestUtils.generateFakePubKeys(10);
const sender = members[3].key;
const getConvo = sandbox.stub(ConversationController.getInstance(), 'get');
beforeEach(async () => {
// Utils Stubs
sandbox.stub(UserUtils, 'getOurPubKeyStrFromCache').returns(ourNumber);
});
afterEach(() => {
TestUtils.restoreStubs();
sandbox.restore();
});
describe('handleClosedGroupControlMessage', () => {
describe('performIfValid', () => {
it('does not perform if convo does not exist', async () => {
const envelope = generateEnvelopePlusClosedGroup(groupId, sender);
const groupUpdate = generateGroupUpdateNameChange(groupId);
getConvo.returns(undefined as any);
await handleClosedGroupControlMessage(envelope, groupUpdate);
});
});
// describe('handleClosedGroupNameChanged', () => {
// it('does not trigger an update of the group if the name is the same', async () => {
// const envelope = generateEnvelopePlusClosedGroup(groupId, sender);
// const groupUpdate = generateGroupUpdateNameChange(groupId);
// await handleClosedGroupControlMessage(envelope, groupUpdate);
// });
// });
});
// const sandbox = sinon.createSandbox();
// const ourDevice = TestUtils.generateFakePubKey();
// const ourNumber = ourDevice.key;
// const groupId = TestUtils.generateFakePubKey().key;
// const members = TestUtils.generateFakePubKeys(10);
// const sender = members[3].key;
// const getConvo = sandbox.stub(ConversationController.getInstance(), 'get');
// beforeEach(async () => {
// // Utils Stubs
// sandbox.stub(UserUtils, 'getCurrentDevicePubKey').resolves(ourNumber);
// });
// afterEach(() => {
// TestUtils.restoreStubs();
// sandbox.restore();
// });
// describe('handleClosedGroupControlMessage', () => {
// describe('performIfValid', () => {
// it('does not perform if convo does not exist', async () => {
// const envelope = generateEnvelopePlusClosedGroup(groupId, sender);
// const groupUpdate = generateGroupUpdateNameChange(groupId);
// getConvo.returns(undefined as any);
// await handleClosedGroupControlMessage(envelope, groupUpdate);
// });
// });
// // describe('handleClosedGroupNameChanged', () => {
// // it('does not trigger an update of the group if the name is the same', async () => {
// // const envelope = generateEnvelopePlusClosedGroup(groupId, sender);
// // const groupUpdate = generateGroupUpdateNameChange(groupId);
// // await handleClosedGroupControlMessage(envelope, groupUpdate);
// // });
// // });
// });
});