oxen-io/session-desktop
1
0
Fork 0
mirror of https://github.com/oxen-io/session-desktop.git synced 2023-12-14 02:12:57 +01:00
Code Issues Projects Releases Wiki Activity

fix: review changes #2, refactorised toggleLinkPreviews function

Browse source
This commit is contained in:
tomobre 2023-02-16 11:36:52 +11:00
parent 138d8da676
commit 77f0138d49
1 changed files with 7 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ts/components/settings/section/CategoryPrivacy.tsx
View file

@ -12,7 +12,8 @@ import { TypingBubble } from '../../conversation/TypingBubble';
import { SessionSettingButtonItem, SessionToggleWithDescription } from '../SessionSettingListItem';
import { displayPasswordModal } from '../SessionSettings';
async function toggleLinkPreviews(isToggleOn: boolean, setIsToggleOn: (value: boolean) => void) {
async function toggleLinkPreviews(forceUpdate: () => void) {
const isToggleOn = Boolean(window.getSettingValue(SettingsKey.settingsLinkPreview));
if (!isToggleOn) {
window.inboxStore?.dispatch(
updateConfirmModal({
@ -22,13 +23,14 @@ async function toggleLinkPreviews(isToggleOn: boolean, setIsToggleOn: (value: bo
onClickOk: async () => {
const newValue = !isToggleOn;
await window.setSettingValue(SettingsKey.settingsLinkPreview, newValue);
setIsToggleOn(newValue);
forceUpdate();
},
})
);
} else {
await window.setSettingValue(SettingsKey.settingsLinkPreview, false);
await Data.createOrUpdateItem({ id: hasLinkPreviewPopupBeenDisplayed, value: false });
setIsToggleOn(false);
forceUpdate();
}
}
@ -45,9 +47,7 @@ export const SettingsCategoryPrivacy = (props: {
hasPassword: boolean | null;
onPasswordUpdated: (action: string) => void;
}) => {
const [isLinkPreviewsOn, setIsLinkPreviewsOn] = React.useState(
Boolean(window.getSettingValue(SettingsKey.settingsLinkPreview))
);
const isLinkPreviewsOn = Boolean(window.getSettingValue(SettingsKey.settingsLinkPreview));
const forceUpdate = useUpdate();
@ -77,8 +77,7 @@ export const SettingsCategoryPrivacy = (props: {
/>
<SessionToggleWithDescription
onClickToggle={async () => {
await toggleLinkPreviews(isLinkPreviewsOn, setIsLinkPreviewsOn);
forceUpdate();
await toggleLinkPreviews(forceUpdate);
}}
title={window.i18n('linkPreviewsTitle')}
description={window.i18n('linkPreviewDescription')}