oxen-io/session-desktop
1
0
Fork 0
mirror of https://github.com/oxen-io/session-desktop.git synced 2023-12-14 02:12:57 +01:00
Code Issues Projects Releases Wiki Activity

fix empty avatar being undefined rather than ''

Browse source 
building ClosedGroupUpdate message via ts makes it have an avatar
content with fields empty if we pass '' as avatar.

we wamt no avatar field at all
This commit is contained in:
Audric Ackermann 2020-07-13 09:07:52 +10:00
parent 9be0dcabd9
commit a4fedaf75d
No known key found for this signature in database
GPG key ID: 999F434D76324AD4
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
js/background.js
View file

@ -700,7 +700,7 @@
return;
}
const nullAvatar = '';
const nullAvatar = undefined;
if (avatar) {
// would get to download this file on each client in the group
// and reference the local file
@ -831,7 +831,7 @@
recipients: allMembers,
active: true,
expireTimer: 0,
avatar: '',
avatar: undefined,
},
confirm: () => {},
};

7
ts/session/messages/outgoing/content/data/group/ClosedGroupUpdateMessage.ts
View file

@ -43,6 +43,13 @@ export abstract class ClosedGroupUpdateMessage extends ClosedGroupMessage {
throw new Error('admins has not the correct type');
}
if (
params.avatar !== undefined &&
!(params.avatar instanceof SignalService.AttachmentPointer)
) {
throw new Error('avatar has not the correct type');
}
this.name = params.name;
this.members = params.members;
this.admins = params.admins;