oxen-io/session-desktop
1
0
Fork 0
mirror of https://github.com/oxen-io/session-desktop.git synced 2023-12-14 02:12:57 +01:00
Code Issues Projects Releases Wiki Activity

Tests and increase consistency for isFileDangerous calls

Browse source
This commit is contained in:
Scott Nonnenberg 2018-10-15 11:54:50 -07:00
parent 8edfbdcee5
commit bc0ec92ad2
2 changed files with 36 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ts/components/conversation/Message.tsx
View file

@ -505,7 +505,7 @@ export class Message extends React.Component<Props, State> {
} else {
const { fileName, fileSize, contentType } = attachment;
const extension = getExtension({ contentType, fileName });
const isDangerous = isFileDangerous(fileName);
const isDangerous = isFileDangerous(fileName || '');
return (
<div
@ -738,7 +738,7 @@ export class Message extends React.Component<Props, State> {
return null;
}
const fileName = attachment && attachment.fileName;
const fileName = attachment ? attachment.fileName : null;
const isDangerous = isFileDangerous(fileName || '');
const downloadButton = attachment ? (

34
ts/test/util/isFileDangerous_test.ts Normal file
View file

@ -0,0 +1,34 @@
import { assert } from 'chai';
import { isFileDangerous } from '../../util/isFileDangerous';
describe('isFileDangerous', () => {
it('returns false for images', () => {
assert.strictEqual(isFileDangerous('dog.gif'), false);
assert.strictEqual(isFileDangerous('cat.jpg'), false);
});
it('returns false for documents', () => {
assert.strictEqual(isFileDangerous('resume.docx'), false);
assert.strictEqual(isFileDangerous('price_list.pdf'), false);
});
it('returns true for executable files', () => {
assert.strictEqual(isFileDangerous('run.exe'), true);
assert.strictEqual(isFileDangerous('install.pif'), true);
});
it('returns false for empty filename', () => {
assert.strictEqual(isFileDangerous(''), false);
});
it('returns false for exe at various parts of filename', () => {
assert.strictEqual(isFileDangerous('.exemanifesto.txt'), false);
assert.strictEqual(isFileDangerous('runexe'), false);
assert.strictEqual(isFileDangerous('run_exe'), false);
});
it('returns true for upper-case EXE', () => {
assert.strictEqual(isFileDangerous('run.EXE'), true);
});
});