oxen-io/session-ios
1
0
Fork 0
mirror of https://github.com/oxen-io/session-ios.git synced 2023-12-13 21:30:14 +01:00
Code Issues Projects Releases Wiki Activity
session-ios/SignalServiceKit/src/Contacts/Threads/TSGroupThread.h

50 lines
1.8 KiB
C
Raw Normal View History

"Bob's SN changed" displayed in every group containing Bob // FREEBIE
2017-05-17 16:02:46 +02:00
//
Send "disappearing messages" state for groups.
2018-01-31 20:11:40 +01:00
// Copyright (c) 2018 Open Whisper Systems. All rights reserved.
"Bob's SN changed" displayed in every group containing Bob // FREEBIE
2017-05-17 16:02:46 +02:00
//
Init Commit
2015-12-07 03:31:43 +01:00
#import "TSGroupModel.h"
#import "TSThread.h"
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE
2016-10-14 23:00:29 +02:00
NS_ASSUME_NONNULL_BEGIN
@class TSAttachmentStream;
Process messages in a single transaction (wherever possible). // FREEBIE
2017-09-13 21:35:33 +02:00
@class YapDatabaseReadWriteTransaction;
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE
2016-10-14 23:00:29 +02:00
Avatar updates when contact/profile/group photo changes // FREEBIE
2018-04-25 22:50:07 +02:00
extern NSString *const TSGroupThreadAvatarChangedNotification;
Fix "group avatar doesn't update after local change."
2018-05-18 21:37:38 +02:00
extern NSString *const TSGroupThread_NotificationKey_UniqueId;
Avatar updates when contact/profile/group photo changes // FREEBIE
2018-04-25 22:50:07 +02:00
Init Commit
2015-12-07 03:31:43 +01:00
@interface TSGroupThread : TSThread
Sync messages with your other devices After provisioning a desktop client, you'll see messages sent from your phone appear on your desktop client, and messages sent from the desktop client appear on your phone. * In the process extracted some of the Attachment processing logic out of the giant MessagesManager. * Some nullability annotations on affected files. // FREEBIE
2016-08-23 22:38:05 +02:00
Init Commit
2015-12-07 03:31:43 +01:00
@property (nonatomic, strong) TSGroupModel *groupModel;
Sync messages with your other devices After provisioning a desktop client, you'll see messages sent from your phone appear on your desktop client, and messages sent from the desktop client appear on your phone. * In the process extracted some of the Attachment processing logic out of the giant MessagesManager. * Some nullability annotations on affected files. // FREEBIE
2016-08-23 22:38:05 +02:00
Handle group keychange error (#50) // FREEBIE
2016-10-24 19:54:00 +02:00
+ (instancetype)getOrCreateThreadWithGroupModel:(TSGroupModel *)groupModel;
Init Commit
2015-12-07 03:31:43 +01:00
+ (instancetype)getOrCreateThreadWithGroupModel:(TSGroupModel *)groupModel
transaction:(YapDatabaseReadWriteTransaction *)transaction;
Create & access groups more carefully. // FREEBIE
2017-10-03 19:41:48 +02:00
+ (instancetype)getOrCreateThreadWithGroupId:(NSData *)groupId;
+ (instancetype)getOrCreateThreadWithGroupId:(NSData *)groupId
transaction:(YapDatabaseReadWriteTransaction *)transaction;
Sync messages with your other devices After provisioning a desktop client, you'll see messages sent from your phone appear on your desktop client, and messages sent from the desktop client appear on your phone. * In the process extracted some of the Attachment processing logic out of the giant MessagesManager. * Some nullability annotations on affected files. // FREEBIE
2016-08-23 22:38:05 +02:00
Create & access groups more carefully. // FREEBIE
2017-10-03 19:41:48 +02:00
+ (nullable instancetype)threadWithGroupId:(NSData *)groupId transaction:(YapDatabaseReadTransaction *)transaction;
Init Commit
2015-12-07 03:31:43 +01:00
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE
2016-10-14 23:00:29 +02:00
+ (NSString *)threadIdFromGroupId:(NSData *)groupId;
Use cached group details when rendering blocklist
2018-09-14 17:29:18 +02:00
+ (NSString *)defaultGroupName;
nonblocking SN change notifications don't percolate group threads to the top unless there is a message in that thread. Otherwise the user is overwhelmed by a bunch of group threads with redundant notifications. The notifications will be there if the user later enters the threads. The affect is that only the thread with the relevant message will pop to the top. // FREEBIE
2017-05-17 16:35:04 +02:00
// all group threads containing recipient as a member
Add protocol context to protocol kit.
2018-01-25 22:40:20 +01:00
+ (NSArray<TSGroupThread *> *)groupThreadsWithRecipientId:(NSString *)recipientId
transaction:(YapDatabaseReadWriteTransaction *)transaction;
"Bob's SN changed" displayed in every group containing Bob // FREEBIE
2017-05-17 16:02:46 +02:00
Leave group when blocking it
2018-09-10 19:25:38 +02:00
- (void)leaveGroupWithSneakyTransaction;
- (void)leaveGroupWithTransaction:(YapDatabaseReadWriteTransaction *)transaction;
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE
2016-10-14 23:00:29 +02:00
- (void)updateAvatarWithAttachmentStream:(TSAttachmentStream *)attachmentStream;
Process messages in a single transaction (wherever possible). // FREEBIE
2017-09-13 21:35:33 +02:00
- (void)updateAvatarWithAttachmentStream:(TSAttachmentStream *)attachmentStream
transaction:(YapDatabaseReadWriteTransaction *)transaction;
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE
2016-10-14 23:00:29 +02:00
Fix "group avatar doesn't update after local change."
2018-05-18 21:37:38 +02:00
- (void)fireAvatarChangedNotification;
Init Commit
2015-12-07 03:31:43 +01:00
@end
Explain send failures for text and media messages Motivation ---------- We were often swallowing errors or yielding generic errors when it would be better to provide specific errors. We also didn't create an attachment when attachments failed to send, making it impossible to show the user what was happening with an in-progress or failed attachment. Primary Changes --------------- - Funnel all message sending through MessageSender, and remove message sending from MessagesManager. - Record most recent sending error so we can expose it in the UI - Can resend attachments. - Update message status for attachments, just like text messages - Extracted UploadingService from MessagesManager - Saving attachment stream before uploading gives uniform API for send vs. resend - update status for downloading transcript attachments - TSAttachments have a local id, separate from the server allocated id This allows us to save the attachment before the allocation request. Which is is good because: 1. can show feedback to user faster. 2. allows us to show an error when allocation fails. Code Cleanup ------------ - Replaced a lot of global singleton access with injected dependencies to make for easier testing. - Never save group meta messages. Rather than checking before (hopefully) every save, do it in the save method. - Don't use callbacks for sync code. - Handle errors on writing attachment data - Fix old long broken tests that weren't even running. =( - Removed dead code - Use constants vs define - Port flaky travis fixes from Signal-iOS // FREEBIE
2016-10-14 23:00:29 +02:00
NS_ASSUME_NONNULL_END
Reference in a new issue Copy permalink