Merge pull request #864 from f-person/feat/all-orientations-for-ipad

feat: Enable upside down orientation for iPad

Session/Media Viewing & Editing/DocumentTitleViewController.swift

@@ -46,6 +46,10 @@ public class DocumentTileViewController: UIViewController, UITableViewDelegate,
     // MARK: - UI
     
     override public var supportedInterfaceOrientations: UIInterfaceOrientationMask {
+        if UIDevice.current.isIPad {
+            return .all
+        }
+
         return .allButUpsideDown
     }
     

Session/Media Viewing & Editing/MediaGalleryNavigationController.swift

@@ -44,6 +44,10 @@ class MediaGalleryNavigationController: UINavigationController {
     // MARK: - Orientation
 
     public override var supportedInterfaceOrientations: UIInterfaceOrientationMask {
+        if UIDevice.current.isIPad {
+            return .all
+        }
+
         return .allButUpsideDown
     }
     

Session/Media Viewing & Editing/MediaTileViewController.swift

@@ -54,6 +54,10 @@ public class MediaTileViewController: UIViewController, UICollectionViewDataSour
     // MARK: - UI
     
     override public var supportedInterfaceOrientations: UIInterfaceOrientationMask {
+        if UIDevice.current.isIPad {
+            return .all
+        }
+
         return .allButUpsideDown
     }
     

Session/Meta/AppDelegate.swift

@@ -248,7 +248,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate, UNUserNotificationCenterD
 
     func application(_ application: UIApplication, supportedInterfaceOrientationsFor window: UIWindow?) -> UIInterfaceOrientationMask {
         if UIDevice.current.isIPad {
-            return .allButUpsideDown
+            return .all
         }
         
         return .portrait

Session/Meta/Session-Info.plist

@@ -140,6 +140,7 @@
 		<string>UIInterfaceOrientationLandscapeLeft</string>
 		<string>UIInterfaceOrientationLandscapeRight</string>
 		<string>UIInterfaceOrientationPortrait</string>
+		<string>UIInterfaceOrientationPortraitUpsideDown</string>
 	</array>
 	<key>UIViewControllerBasedStatusBarAppearance</key>
 	<true/>

SignalUtilitiesKit/Shared View Controllers/OWSViewController.m

@@ -13,12 +13,12 @@ NS_ASSUME_NONNULL_BEGIN
 
 BOOL IsLandscapeOrientationEnabled(void)
 {
-    return NO;
+    return UIDevice.currentDevice.isIPad;
 }
 
 UIInterfaceOrientationMask DefaultUIInterfaceOrientationMask(void)
 {
-    return (IsLandscapeOrientationEnabled() ? UIInterfaceOrientationMaskAllButUpsideDown
+    return (IsLandscapeOrientationEnabled() ? UIInterfaceOrientationMaskAll
                                             : UIInterfaceOrientationMaskPortrait);
 }