oxen-io/session-ios
1
0
Fork 0
mirror of https://github.com/oxen-io/session-ios.git synced 2023-12-13 21:30:14 +01:00
Code Issues Projects Releases Wiki Activity

Working around a bizarre crash on iOS 9

Browse source 
Without this, I get a SEGFAULT on iOS 9.3 device 1 in 3 calls when
accessing the RTC extern constants. Swift bug?

Currently using XCode 8.2

// FREEBIE
This commit is contained in:
Michael Kirk 2017-01-27 16:41:11 -05:00
parent fff061ff3f
commit 459d0d6012
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Signal/src/call/PeerConnectionClient.swift
View file

@ -6,8 +6,15 @@ import Foundation
import PromiseKit
import WebRTC
// HACK - Seeing crazy SEGFAULTs on iOS9 when accessing these objc externs.
// iOS10 seems unaffected. Reproducible for ~1 in 3 calls.
// Binding them to a file constant seems to work around the problem.
let kAudioTrackType = kRTCMediaStreamTrackKindAudio
let kVideoTrackType = kRTCMediaStreamTrackKindVideo
let kMediaConstraintsMinWidth = kRTCMediaConstraintsMinWidth
let kMediaConstraintsMaxWidth = kRTCMediaConstraintsMaxWidth
let kMediaConstraintsMinHeight = kRTCMediaConstraintsMinHeight
let kMediaConstraintsMaxHeight = kRTCMediaConstraintsMaxHeight
/**
* The PeerConnectionClient notifies it's delegate (the CallService) of key events in the call signaling life cycle
@ -142,10 +149,10 @@ class PeerConnectionClient: NSObject, RTCPeerConnectionDelegate, RTCDataChannelD
// TODO: What are the best values to use here?
let mediaConstraintsDictionary = [
kRTCMediaConstraintsMinWidth: "240",
kRTCMediaConstraintsMinHeight: "320",
kRTCMediaConstraintsMaxWidth: "240",
kRTCMediaConstraintsMaxHeight: "320"
kMediaConstraintsMinWidth: "240",
kMediaConstraintsMinHeight: "320",
kMediaConstraintsMaxWidth: "240",
kMediaConstraintsMaxHeight: "320"
]
let cameraConstraints = RTCMediaConstraints(mandatoryConstraints:nil,
optionalConstraints:mediaConstraintsDictionary)