oxen-io/session-ios
1
0
Fork 0
mirror of https://github.com/oxen-io/session-ios.git synced 2023-12-13 21:30:14 +01:00
Code Issues Projects Releases Wiki Activity

Add loading background to gif cells, refactor gif cells.

Browse source 
// FREEBIE
This commit is contained in:
Matthew Chen 2017-10-04 11:55:15 -04:00
parent 334396dac6
commit 52a8fb4b88
1 changed files with 35 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
Signal/src/ViewControllers/GifPicker/GifPickerCell.swift
View file

@ -62,29 +62,35 @@ class GifPickerCell: UICollectionViewCell {
stillAssetRequest = nil stillAssetRequest = nil
} }
private func clearanimatedAssetRequest() { private func clearAnimatedAssetRequest() {
animatedAssetRequest?.cancel() animatedAssetRequest?.cancel()
animatedAssetRequest = nil animatedAssetRequest = nil
} }
private func clearAssetRequests() { private func clearAssetRequests() {
clearStillAssetRequest() clearStillAssetRequest()
clearanimatedAssetRequest() clearAnimatedAssetRequest()
} }
public func ensureCellState() { public func ensureCellState() {
ensureLoadState()
ensureViewState()
}
public func ensureLoadState() {
guard isCellVisible else { guard isCellVisible else {
// Cancel any outstanding requests. // Don't load if cell is not visible.
clearAssetRequests() clearAssetRequests()
// Clear image view so we don't animate offscreen GIFs.
imageView?.image = nil
return return
} }
guard let imageInfo = imageInfo else { guard let imageInfo = imageInfo else {
// Don't load if cell is not configured.
clearAssetRequests() clearAssetRequests()
return return
} }
guard self.animatedAsset == nil else { guard self.animatedAsset == nil else {
// Don't load if cell is already loaded.
clearAssetRequests()
return return
} }
// The Giphy API returns a slew of "renditions" for a given image. // The Giphy API returns a slew of "renditions" for a given image.
@ -101,7 +107,9 @@ class GifPickerCell: UICollectionViewCell {
} }
// Start still asset request if necessary. // Start still asset request if necessary.
if stillAsset == nil && animatedAsset == nil && stillAssetRequest == nil { if stillAsset != nil || animatedAsset != nil {
clearStillAssetRequest()
} else if stillAssetRequest == nil {
stillAssetRequest = GiphyDownloader.sharedInstance.requestAsset(rendition:stillRendition, stillAssetRequest = GiphyDownloader.sharedInstance.requestAsset(rendition:stillRendition,
priority:.high, priority:.high,
success: { [weak self] assetRequest, asset in success: { [weak self] assetRequest, asset in
@ -112,7 +120,7 @@ class GifPickerCell: UICollectionViewCell {
} }
strongSelf.clearStillAssetRequest() strongSelf.clearStillAssetRequest()
strongSelf.stillAsset = asset strongSelf.stillAsset = asset
strongSelf.tryToDisplayAsset() strongSelf.ensureViewState()
}, },
failure: { [weak self] assetRequest in failure: { [weak self] assetRequest in
guard let strongSelf = self else { return } guard let strongSelf = self else { return }
@ -125,7 +133,9 @@ class GifPickerCell: UICollectionViewCell {
} }
// Start animated asset request if necessary. // Start animated asset request if necessary.
if animatedAsset == nil && animatedAssetRequest == nil { if animatedAsset != nil {
clearAnimatedAssetRequest()
} else if animatedAssetRequest == nil {
animatedAssetRequest = GiphyDownloader.sharedInstance.requestAsset(rendition:animatedRendition, animatedAssetRequest = GiphyDownloader.sharedInstance.requestAsset(rendition:animatedRendition,
priority:.low, priority:.low,
success: { [weak self] assetRequest, asset in success: { [weak self] assetRequest, asset in
@ -137,7 +147,7 @@ class GifPickerCell: UICollectionViewCell {
// If we have the animated asset, we don't need the still asset. // If we have the animated asset, we don't need the still asset.
strongSelf.clearAssetRequests() strongSelf.clearAssetRequests()
strongSelf.animatedAsset = asset strongSelf.animatedAsset = asset
strongSelf.tryToDisplayAsset() strongSelf.ensureViewState()
}, },
failure: { [weak self] assetRequest in failure: { [weak self] assetRequest in
guard let strongSelf = self else { return } guard let strongSelf = self else { return }
@ -145,18 +155,24 @@ class GifPickerCell: UICollectionViewCell {
owsFail("Obsolete request callback.") owsFail("Obsolete request callback.")
return return
} }
strongSelf.clearanimatedAssetRequest() strongSelf.clearAnimatedAssetRequest()
}) })
} }
} }
private func tryToDisplayAsset() { private func ensureViewState() {
guard isCellVisible else {
// Clear image view so we don't animate offscreen GIFs.
clearViewState()
return
}
guard let asset = pickBestAsset() else { guard let asset = pickBestAsset() else {
owsFail("\(TAG) missing asset.") clearViewState()
return return
} }
guard let image = YYImage(contentsOfFile:asset.filePath) else { guard let image = YYImage(contentsOfFile:asset.filePath) else {
owsFail("\(TAG) could not load asset.") owsFail("\(TAG) could not load asset.")
clearViewState()
return return
} }
if imageView == nil { if imageView == nil {
@ -167,9 +183,16 @@ class GifPickerCell: UICollectionViewCell {
} }
guard let imageView = imageView else { guard let imageView = imageView else {
owsFail("\(TAG) missing imageview.") owsFail("\(TAG) missing imageview.")
clearViewState()
return return
} }
imageView.image = image imageView.image = image
self.backgroundColor = nil
}
private func clearViewState() {
imageView?.image = nil
self.backgroundColor = UIColor(white:0.95, alpha:1.0)
} }
private func pickBestAsset() -> GiphyAsset? { private func pickBestAsset() -> GiphyAsset? {