From 59b125c3fbb3d5fa9541a6364d259d131c3ef8b2 Mon Sep 17 00:00:00 2001 From: Michael Kirk Date: Tue, 24 Oct 2017 15:21:46 -0700 Subject: [PATCH] Add clarifying comment per CR // FREEBIE --- .../ConversationView/ConversationViewController.m | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Signal/src/ViewControllers/ConversationView/ConversationViewController.m b/Signal/src/ViewControllers/ConversationView/ConversationViewController.m index 19d3e84f7..ef3f6e117 100644 --- a/Signal/src/ViewControllers/ConversationView/ConversationViewController.m +++ b/Signal/src/ViewControllers/ConversationView/ConversationViewController.m @@ -986,6 +986,10 @@ typedef NS_ENUM(NSInteger, MessagesRangeSizeMode) { self.viewHasEverAppeared = YES; } +// `viewWillDisappear` is called whenever the view *starts* to disappear, +// but, as is the case with the "pan left for message details view" gesture, +// this can be canceled. As such, we shouldn't tear down anything expensive +// until `viewDidDisappear`. - (void)viewWillDisappear:(BOOL)animated { DDLogDebug(@"%@ viewWillDisappear", self.tag);