From 6bc9b21cde6e6a88d8fe23921bdc9d9fcd395669 Mon Sep 17 00:00:00 2001 From: Niels Andriesse Date: Tue, 13 Jul 2021 09:46:06 +1000 Subject: [PATCH] Fix handling of failed messages in open groups Failures wouldn't show up because `recipientIdentifiers` was empty for open groups --- SessionMessagingKit/Threads/TSGroupThread.m | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/SessionMessagingKit/Threads/TSGroupThread.m b/SessionMessagingKit/Threads/TSGroupThread.m index 9121921c7..542a2bb4e 100644 --- a/SessionMessagingKit/Threads/TSGroupThread.m +++ b/SessionMessagingKit/Threads/TSGroupThread.m @@ -119,15 +119,14 @@ NSString *const TSGroupThread_NotificationKey_UniqueId = @"TSGroupThread_Notific - (NSArray *)recipientIdentifiers { - NSMutableArray *groupMemberIds = [self.groupModel.groupMemberIds mutableCopy]; - - if (groupMemberIds == nil) { - return @[]; + if (self.isClosedGroup) { + NSMutableArray *groupMemberIds = [self.groupModel.groupMemberIds mutableCopy]; + if (groupMemberIds == nil) { return @[]; } + [groupMemberIds removeObject:TSAccountManager.localNumber]; + return [groupMemberIds copy]; + } else { + return @[ [LKGroupUtilities getDecodedGroupID:self.groupModel.groupId] ]; } - - [groupMemberIds removeObject:TSAccountManager.localNumber]; - - return [groupMemberIds copy]; } // @returns all threads to which the recipient is a member.