Respond to CR.

// FREEBIE
This commit is contained in:
Matthew Chen 2017-02-13 16:30:54 -05:00
parent e48efe01c9
commit a52771e286
4 changed files with 11 additions and 13 deletions

View File

@ -18,7 +18,6 @@
#import "OWSWebRTCDataProtos.pb.h"
#import "PhoneManager.h"
#import "PropertyListPreferences.h"
#import "PureLayout.h"
#import "PushManager.h"
#import "RPAccountManager.h"
#import "TSSocketManager.h"
@ -27,6 +26,7 @@
#import "UIUtil.h"
#import "UIView+OWS.h"
#import <JSQSystemSoundPlayer.h>
#import <PureLayout/PureLayout.h>
#import <SignalServiceKit/Contact.h>
#import <SignalServiceKit/ContactsUpdater.h>
#import <SignalServiceKit/Cryptography.h>

View File

@ -2,7 +2,7 @@
// Copyright (c) 2017 Open Whisper Systems. All rights reserved.
//
#import "PureLayout.h"
#import <PureLayout/PureLayout.h>
#import <UIKit/UIKit.h>
// A convenience method for doing responsive layout. Scales between two

View File

@ -195,9 +195,9 @@
#pragma mark - Gesture Recognizers
- (void)imageDismissGesture:(UIGestureRecognizer *)sender {
if (sender.state == UIGestureRecognizerStateRecognized) {
[self dismiss];
}
if (sender.state == UIGestureRecognizerStateRecognized) {
[self dismiss];
}
}
- (void)longPressGesture:(UIGestureRecognizer *)sender {

View File

@ -1238,10 +1238,6 @@ typedef enum : NSUInteger {
_videoPlayer = [[MPMoviePlayerController alloc] initWithContentURL:attStream.mediaURL];
[_videoPlayer prepareToPlay];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(moviePlayBackDidFinish:)
name:MPMoviePlayerPlaybackDidFinishNotification
object:_videoPlayer];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(moviePlayerWillExitFullscreen:)
name:MPMoviePlayerWillExitFullscreenNotification
@ -1389,16 +1385,18 @@ typedef enum : NSUInteger {
}
}
- (void)moviePlayBackDidFinish:(id)sender {
DDLogDebug(@"%@ %s", self.tag, __PRETTY_FUNCTION__);
}
// There's more than one way to exit the fullscreen video playback.
// There's a done button, a "toggle fullscreen" button and I think
// there's some gestures too. These fire slightly different notifications.
// We want to hide & clean up the video player immediately in all of
// these cases.
- (void)moviePlayerWillExitFullscreen:(id)sender {
DDLogDebug(@"%@ %s", self.tag, __PRETTY_FUNCTION__);
[self clearVideoPlayer];
}
// See comment on moviePlayerWillExitFullscreen:
- (void)moviePlayerDidExitFullscreen:(id)sender {
DDLogDebug(@"%@ %s", self.tag, __PRETTY_FUNCTION__);