From 0dcde9516e671ab96c21672edd33c40b815f176a Mon Sep 17 00:00:00 2001 From: Matthew Chen Date: Fri, 8 Jun 2018 10:34:56 -0400 Subject: [PATCH] Suppress legal links. --- .../AppSettings/AboutTableViewController.m | 3 +++ .../Registration/RegistrationViewController.m | 9 ++++++++- SignalServiceKit/src/TSConstants.h | 1 + 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/Signal/src/ViewControllers/AppSettings/AboutTableViewController.m b/Signal/src/ViewControllers/AppSettings/AboutTableViewController.m index aeeb125b5..fb9c8c0ed 100644 --- a/Signal/src/ViewControllers/AppSettings/AboutTableViewController.m +++ b/Signal/src/ViewControllers/AppSettings/AboutTableViewController.m @@ -49,12 +49,15 @@ accessoryText:[[[NSBundle mainBundle] infoDictionary] objectForKey:@"CFBundleVersion"]]]; +#ifdef SHOW_LEGAL_TERMS_LINK [informationSection addItem:[OWSTableItem disclosureItemWithText:NSLocalizedString(@"SETTINGS_LEGAL_TERMS_CELL", @"table cell label") actionBlock:^{ [[UIApplication sharedApplication] openURL:[NSURL URLWithString:kLegalTermsUrlString]]; }]]; +#endif + [contents addSection:informationSection]; OWSTableSection *helpSection = [OWSTableSection new]; diff --git a/Signal/src/ViewControllers/Registration/RegistrationViewController.m b/Signal/src/ViewControllers/Registration/RegistrationViewController.m index d8d549222..ecc463ed3 100644 --- a/Signal/src/ViewControllers/Registration/RegistrationViewController.m +++ b/Signal/src/ViewControllers/Registration/RegistrationViewController.m @@ -79,6 +79,7 @@ NSString *const kKeychainKey_LastRegisteredPhoneNumber = @"kKeychainKey_LastRegi headerLabel.textColor = [UIColor whiteColor]; headerLabel.font = [UIFont ows_mediumFontWithSize:ScaleFromIPhone5To7Plus(20.f, 24.f)]; +#ifdef SHOW_LEGAL_TERMS_LINK NSString *legalTopMatterFormat = NSLocalizedString(@"REGISTRATION_LEGAL_TOP_MATTER_FORMAT", @"legal disclaimer, embeds a tappable {{link title}} which is styled as a hyperlink"); NSString *legalTopMatterLinkWord = NSLocalizedString( @@ -103,8 +104,12 @@ NSString *const kKeychainKey_LastRegisteredPhoneNumber = @"kKeychainKey_LastRegi UITapGestureRecognizer *tapGesture = [[UITapGestureRecognizer alloc] initWithTarget:self action:@selector(didTapLegalTerms:)]; [legalTopMatterLabel addGestureRecognizer:tapGesture]; +#endif - UIStackView *headerContent = [[UIStackView alloc] initWithArrangedSubviews:@[ headerLabel, legalTopMatterLabel ]]; + UIStackView *headerContent = [[UIStackView alloc] initWithArrangedSubviews:@[ headerLabel ]]; +#ifdef SHOW_LEGAL_TERMS_LINK + [headerContent addArrangedSubview:legalTopMatterLabel]; +#endif headerContent.axis = UILayoutConstraintAxisVertical; headerContent.alignment = UIStackViewAlignmentCenter; headerContent.spacing = ScaleFromIPhone5To7Plus(8, 16); @@ -244,6 +249,7 @@ NSString *const kKeychainKey_LastRegisteredPhoneNumber = @"kKeychainKey_LastRegi [spinnerView autoPinTrailingToSuperviewMarginWithInset:20.f]; [spinnerView stopAnimating]; +#ifdef SHOW_LEGAL_TERMS_LINK NSString *bottomTermsLinkText = NSLocalizedString(@"REGISTRATION_LEGAL_TERMS_LINK", @"one line label below submit button on registration screen, which links to an external webpage."); UIButton *bottomLegalLinkButton = [UIButton new]; @@ -262,6 +268,7 @@ NSString *const kKeychainKey_LastRegisteredPhoneNumber = @"kKeychainKey_LastRegi withOffset:ScaleFromIPhone5To7Plus(8, 12)]; [bottomLegalLinkButton setCompressionResistanceHigh]; [bottomLegalLinkButton setContentHuggingHigh]; +#endif } - (void)viewDidAppear:(BOOL)animated diff --git a/SignalServiceKit/src/TSConstants.h b/SignalServiceKit/src/TSConstants.h index 9779a3bf7..f8f3753b2 100644 --- a/SignalServiceKit/src/TSConstants.h +++ b/SignalServiceKit/src/TSConstants.h @@ -18,6 +18,7 @@ typedef NS_ENUM(NSInteger, TSWhisperMessageType) { #define textSecureHTTPTimeOut 10 #define kLegalTermsUrlString @"https://signal.org/legal/" +//#define SHOW_LEGAL_TERMS_LINK //#ifndef DEBUG