Revisit TODOs in the SAE work.
This commit is contained in:
parent
9c8178653d
commit
ba42ac73d8
|
@ -1370,7 +1370,7 @@ const CGFloat OWSMessageCellCornerRadius = 17;
|
|||
OWSAssert(backupZipPath.length > 0);
|
||||
|
||||
OWSBackupImportViewController *backupViewController = [OWSBackupImportViewController new];
|
||||
// TODO: Add support for restoring password-protected backups.
|
||||
// There currently isn't any support for restoring password-protected backups.
|
||||
[backupViewController importBackup:backupZipPath password:nil];
|
||||
UINavigationController *navigationController =
|
||||
[[UINavigationController alloc] initWithRootViewController:backupViewController];
|
||||
|
|
|
@ -141,7 +141,6 @@ public class ProfileFetcherJob: NSObject {
|
|||
}
|
||||
}
|
||||
|
||||
// TODO: This was a struct.
|
||||
@objc
|
||||
public class SignalServiceProfile: NSObject {
|
||||
let TAG = "[SignalServiceProfile]"
|
||||
|
|
|
@ -50,7 +50,6 @@ extern NSString *const StorageIsReadyNotification;
|
|||
|
||||
+ (void)resetAllStorage;
|
||||
|
||||
// TODO: Deprecate?
|
||||
- (YapDatabaseConnection *)newDatabaseConnection;
|
||||
|
||||
#ifdef DEBUG
|
||||
|
|
|
@ -263,7 +263,7 @@ typedef NSData *_Nullable (^CreateDatabaseMetadataBlock)(void);
|
|||
// Try to reset app by deleting all databases.
|
||||
//
|
||||
// TODO: Possibly clean up all app files.
|
||||
// [OWSStorage deleteDatabaseFiles];
|
||||
// [OWSStorage deleteDatabaseFiles];
|
||||
|
||||
if (![self tryToLoadDatabase]) {
|
||||
OWSFail(@"%@ Could not load database (second try)", self.logTag);
|
||||
|
@ -599,8 +599,8 @@ typedef NSData *_Nullable (^CreateDatabaseMetadataBlock)(void);
|
|||
|
||||
if (CurrentAppContext().isMainApp) {
|
||||
if (CurrentAppContext().isInBackground) {
|
||||
// TODO: Rather than crash here, we should detect the situation earlier
|
||||
// and exit gracefully - (in the app delegate?). See the `
|
||||
// Rather than crash here, we should have already detected the situation earlier
|
||||
// and exited gracefully (in the app delegate) using isDatabasePasswordAccessible.
|
||||
// This is a last ditch effort to avoid blowing away the user's database.
|
||||
[self raiseKeySpecInaccessibleExceptionWithErrorDescription:errorDescription];
|
||||
}
|
||||
|
|
|
@ -38,7 +38,6 @@ NSString *const kNSUserDefaults_LastCompletedLaunchAppVersion_SAE
|
|||
return instance;
|
||||
}
|
||||
|
||||
// TODO: Modify these NSUserDefaults keys for SAE.
|
||||
- (void)configure {
|
||||
self.currentAppVersion = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleShortVersionString"];
|
||||
|
||||
|
|
Loading…
Reference in New Issue