oxen-io
/
session-ios
mirror of https://github.com/oxen-io/session-ios.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Better translation comments 

in response to some confusion received from translators

// FREEBIE
This commit is contained in:
Michael Kirk 2017-02-07 11:26:33 -05:00
parent 3349ac9a10
commit dc9ffe40e5
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Signal/src/UserInterface/Strings.swift
View File

@ -11,4 +11,5 @@ import Foundation
static let callBackButtonTitle = NSLocalizedString("CALLBACK_BUTTON_TITLE", comment: "notification action")
static let missedCallNotificationBody = NSLocalizedString("MISSED_CALL", comment: "notification title")
static let missedCallNotificationBodyWithCallerName = NSLocalizedString("MSGVIEW_MISSED_CALL", comment: "notification title. Embeds {{Caller's Name}}")
static let callStatusFormat = NSLocalizedString("CALL_STATUS_FORMAT", comment: "embeds {{Call Status}} in call screen label. For ongoing calls, {{Call Status}} is a seconds timer like 01:23, otherwise {{Call Status}} is a short text like 'Ringing', 'Busy', or 'Failed Call'")
}

6
Signal/src/view controllers/CallViewController.swift
View File

@ -560,8 +560,8 @@ class CallViewController: UIViewController, CallObserver, CallServiceObserver, R
func updateCallStatusLabel(callState: CallState) {
assert(Thread.isMainThread)
let text = String(format:NSLocalizedString("CALL_STATUS_FORMAT", comment: "Format for call status label"),
localizedTextForCallState(callState))
let text = String(format: CallStrings.callStatusFormat,
localizedTextForCallState(callState))
self.callStatusLabel.text = text
}
@ -686,7 +686,7 @@ class CallViewController: UIViewController, CallObserver, CallServiceObserver, R
guard let call = self.call else {
Logger.error("\(TAG) call was unexpectedly nil. Terminating call.")
let text = String(format:NSLocalizedString("CALL_STATUS_FORMAT", comment: "Format for call status label"),
let text = String(format: CallStrings.callStatusFormat,
NSLocalizedString("END_CALL_UNCATEGORIZED_FAILURE", comment: "Call setup status label"))
self.callStatusLabel.text = text

2
Signal/translations/en.lproj/Localizable.strings
View File

@ -73,7 +73,7 @@
/* Accessibilty label for placing call button */
"CALL_LABEL" = "Call";
/* Format for call status label */
/* embeds {{Call Status}} in call screen label. For ongoing calls, {{Call Status}} is a seconds timer like 01:23, otherwise {{Call Status}} is a short text like 'Ringing', 'Busy', or 'Failed Call' */
"CALL_STATUS_FORMAT" = "Signal %@";
/* notification action */