Michael Kirk
75ead2ac09
quoted reply: distinguish "not found" vs. "no longer available"
2018-08-20 14:59:52 -06:00
Michael Kirk
c6f77ec6ea
"Tap to retry" retries, rather than maybe deletes.
...
Attachment downloads can fail on slow networks or if the app crashes.
It's unlikely that the users response to this would be to delete the
attachment pointer, so it doesn't make sense to surface that as a
primary action.
If a user does want to delete the attachment, as always they can
long-press to delete.
// FREEBIE
2018-08-20 12:25:23 -06:00
Matthew Chen
decb0c54ca
Theme review.
2018-08-16 17:30:08 -04:00
Matthew Chen
f89fa8359b
Revert "Add logging around 'SAE to same thread' crash."
...
This reverts commit eee2f7c8c6
.
2018-08-16 16:09:00 -04:00
Matthew Chen
e3378dec65
Revert "Add logging around 'share from SAE to same conversation' crash."
...
This reverts commit f62bf7d18e
.
2018-08-16 16:08:39 -04:00
Matthew Chen
f62bf7d18e
Add logging around 'share from SAE to same conversation' crash.
2018-08-16 16:08:15 -04:00
Matthew Chen
eee2f7c8c6
Add logging around 'SAE to same thread' crash.
2018-08-16 13:34:07 -04:00
Matthew Chen
b347c40c66
Clean up ahead of PR.
2018-08-16 12:21:03 -04:00
Matthew Chen
0a7b3537b5
Recreate message database view when message mappings are corrupt.
2018-08-16 12:21:03 -04:00
Matthew Chen
db2f5bf3b0
Add temporary logging around conversation view crashes.
2018-08-16 12:21:03 -04:00
Matthew Chen
420f5f88ff
Add logging, error checking and recovery around corrupt message mappings.
2018-08-16 12:21:03 -04:00
Matthew Chen
b3c19b7905
Improve logging of conversation view exceptions.
2018-08-15 14:30:34 -04:00
Michael Kirk
8829cdfb4b
Toast view when tapped message doesn't exist, mark remotely sourced.
2018-08-10 16:55:54 -06:00
Michael Kirk
c05700fd98
Log in OWSFail
...
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
2018-08-09 15:30:19 -06:00
Matthew Chen
0ac1cb1e72
Cache system message text.
2018-08-09 14:01:07 -04:00
Matthew Chen
b3c62d91be
Merge remote-tracking branch 'origin/release/2.28.1'
2018-08-08 13:51:52 -04:00
Michael Kirk
51b1761364
Fix crash during CollectionView thrash
2018-08-08 10:17:42 -06:00
Michael Kirk
7e5d9480b1
Add missing header file
2018-08-08 10:17:03 -06:00
Michael Kirk
2ea7e2b036
CR: clean up preferences
2018-08-08 10:04:59 -06:00
Michael Kirk
e5b3cbd00c
Use StoreKit for reviews
2018-08-07 15:56:52 -06:00
Matthew Chen
faf3cd6a55
Fix lazy collapse of message cell footers.
2018-08-06 14:03:40 -04:00
Matthew Chen
cea93784b1
Avoid redundant content inset updates.
2018-08-06 09:08:54 -04:00
Matthew Chen
9b45a15c35
Merge branch 'release/2.28.1'
2018-08-06 09:01:19 -04:00
Matthew Chen
4918b8994e
Delay footer collapse in new messages.
2018-08-03 15:57:54 -04:00
Matthew Chen
251eef46a2
Delay footer collapse in new messages.
2018-08-03 15:57:54 -04:00
Matthew Chen
dfc39b4a1d
Tidy files.
2018-08-01 09:46:05 -04:00
Matthew Chen
e6bc37d941
Tidy files.
2018-08-01 09:46:05 -04:00
Matthew Chen
2c19474397
Tidy files.
2018-08-01 09:46:05 -04:00
Matthew Chen
8f55f53329
Tidy files.
2018-08-01 09:46:05 -04:00
Michael Kirk
103a8dc579
ubsan fixups
2018-07-31 17:42:20 -06:00
Michael Kirk
78ad597e44
Merge tag '2.28.0.15'
2018-07-31 17:36:37 -06:00
Matthew Chen
995c2f2a2a
Refine 'new message' animations.
2018-07-31 16:04:22 -06:00
Matthew Chen
24d85898e1
Refine 'new message' animations.
2018-07-31 16:04:22 -06:00
Matthew Chen
026ef02ce5
Refine 'new message' animations.
2018-07-31 16:04:22 -06:00
Jesse Squires
6dc74ddcaf
Fix some project warnings + other fixes
...
- Prefer checking `.isEmpty` rather than `.count == 0` for Swift collections (can be more optimal)
- Avoid comparing `BOOL` explicitly to `NO` (considered bad practice since `BOOL` is a `signed char`)
- Specify unused `SGX_FLAGS` as `__unused` to silence warnings
2018-07-31 09:48:58 -06:00
Matthew Chen
fa8a07abf1
Respond to CR.
2018-07-26 10:54:45 -04:00
Matthew Chen
7759c9ca0f
Refine theme.
2018-07-26 09:42:48 -04:00
Michael Kirk
6e1c1a681b
Merge tag '2.28.0.12'
2018-07-23 16:12:46 -06:00
Michael Kirk
2d4eb7d057
remove interactive 'swipe for info'
2018-07-23 13:08:41 -06:00
Matthew Chen
48975eaac8
Respond to CR.
2018-07-20 15:37:47 -04:00
Matthew Chen
d14f764b50
Streamline SignalRecipient.
2018-07-18 13:57:21 -04:00
Michael Kirk
ef9a0880ae
Fix analyzer warnings
2018-07-18 10:24:08 -06:00
Michael Kirk
baacebc956
Enable (quick) static analyzer for normal builds
...
// FREEBIE
2018-07-18 10:24:08 -06:00
Michael Kirk
567f625902
touch instead of reload to make sure any adjacent bubbles are updated appropriately.
2018-07-17 09:53:45 -06:00
Michael Kirk
2c3f7db4e4
Only add one 'incoming message' unread indicator per foreground.
...
// FREEBIE
2018-07-17 09:53:45 -06:00
Michael Kirk
f2f3b9eaed
reload cell after removing unread indicator
...
// FREEBIE
2018-07-17 09:53:45 -06:00
Michael Kirk
0847c0bafb
ScrollToBottom accounts for top inset
...
// FREEBIE
2018-07-13 14:25:11 -06:00
Matthew Chen
687efabede
Respond to CR.
2018-07-13 16:24:36 -04:00
Matthew Chen
96a8df5f88
Fix "new unread indicator animation" issue.
2018-07-13 16:21:57 -04:00
Matthew Chen
f69945ea20
Fix 'breaks vs. collapse' issue.
2018-07-13 16:21:57 -04:00