Commit graph

500 commits

Author SHA1 Message Date
Michael Kirk
3d5f7e6bf3 Clean up logging
- tag all log lines for easier filtering
- use up-to-date database path

// FREEBIE
2018-02-14 09:16:42 -08:00
Michael Kirk
4d0362f9a6 Don't create redundant caption for sync'd transcripts.
Note: For test devices running HEAD, there may have already been some
redundant captions created for sync'd transcripts.

However the existing `TSMessage#initWithCoder:` migration will address
this for our production users, so I'm not going to bother with a second
migration just for our test devices.

// FREEBIE
2018-02-14 09:03:55 -08:00
Matthew Chen
81522e4a23 Respond to CR. 2018-02-14 10:38:08 -05:00
Matthew Chen
888bf9256f Avoid deadlocks in message sender. 2018-02-14 10:38:08 -05:00
Matthew Chen
01496b2db8 Avoid deadlocks in message sender. 2018-02-14 10:38:08 -05:00
Matthew Chen
a19882baaa Avoid deadlocks in message sender. 2018-02-14 10:38:08 -05:00
Collin B. Stuart
cc94573e9b Constant time compare
- fix case when second part of the && conditional is skipped when data is not equal

- isEqual variable marked volatile to prevent case when it doesn't equal 0, the loop can break early since it can never be 0 again

- tested with Fastest O3 and Whole Module optimization (App Store Release)

// FREEBIE
2018-02-13 16:18:06 -08:00
Michael Kirk
ea12ed4c23 Fix dynamic type check which was too restrictive
// FREEBIE
2018-02-13 15:54:23 -08:00
Michael Kirk
ae2ddb25cc CR: add assert
// FREEBIE
2018-02-13 09:50:01 -08:00
Michael Kirk
d6b3e191d1 Fix crash while searching when group somehow has nil members
This shouldn't normally happen, but seeing it on my device.

// FREEBIE
2018-02-13 09:50:01 -08:00
Michael Kirk
a23f1b86ef nullability annotations for TSGroupModel
- add readonly where possible
- group members needn't be a mutable array

// FREEBIE
2018-02-13 09:50:01 -08:00
Joshua Lund
2c18a75d12 Update to the new GitHub organization name 2018-02-13 10:52:07 -05:00
Matthew Chen
ba42ac73d8 Revisit TODOs in the SAE work. 2018-02-12 22:33:26 -05:00
Matthew Chen
9c8178653d Revisit TODOs in the SAE work. 2018-02-12 22:33:26 -05:00
Matthew Chen
b64528e817 Respond to CR. 2018-02-09 10:42:25 -05:00
Matthew Chen
78c4c00eac Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
862172072c Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
bd0f601792 Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
38950ae2ed Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
6b357f9445 Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
43765ef3b5 Respond to CR. 2018-02-09 10:31:29 -05:00
Matthew Chen
51cec20c50 Clean up ahead of PR. 2018-02-09 10:31:29 -05:00
Matthew Chen
7d3f79440f Clean up ahead of PR. 2018-02-09 10:31:29 -05:00
Matthew Chen
c8e7eb903c Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
bbd689bfd0 Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
d3e16583eb Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
074046b98e Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
7358f3053f Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
218bb15ea7 Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
39e353503f Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
71782e0369 Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Matthew Chen
122ef91e57 Add protocol context to protocol kit. 2018-02-09 10:31:29 -05:00
Michael Kirk
a1d3073705 Cannot open settings from share extension
// FREEBIE
2018-02-06 18:50:36 -08:00
Matthew Chen
799949e546 Refine sync messages. 2018-02-02 10:56:16 -05:00
Matthew Chen
59ff1561f5 Set the timestamp property on data messages. 2018-02-02 10:42:56 -05:00
Matthew Chen
4218af13d5 Send image width/height for image and video attachments. 2018-02-02 10:42:56 -05:00
Matthew Chen
3a4180214f Send image width/height for image and video attachments. 2018-02-02 10:42:56 -05:00
Matthew Chen
43ed8d9a5d Send "disappearing messages" state for groups. 2018-02-02 10:42:56 -05:00
Matthew Chen
b16a65a4cd Sync block state for contacts. 2018-02-02 10:42:56 -05:00
Matthew Chen
742d4cabc2 Send "disappearing messages" state for contacts. 2018-02-02 10:42:56 -05:00
Matthew Chen
2dc37d598c Updates service proto schema to latest. 2018-02-02 10:42:56 -05:00
Michael Kirk
4f8db63fb3 Ensure keyspec is generated before DB is created
// FREEBIE
2018-01-31 18:05:44 -08:00
Michael Kirk
6f959ff292 CR: be more conservative about deriving key spec, clear old passphrase
after deriving key spec.

// FREEBIE
2018-01-31 17:22:42 -08:00
Michael Kirk
d22fc664f2 more granular key access
// FREEBIE
2018-01-31 16:08:03 -08:00
Michael Kirk
426c9baa16 Key material changes
- For new installs, generate raw key-spec rather than derive it
- Adapt to separated concerns of the key derivation migration from the unencrypted header migration
- Reduce number of places where we delete/generate keying information
- Only store relevant keying material

// FREEBIE
2018-01-31 16:08:03 -08:00
Michael Kirk
938b9c85b8 Don't crash on clean install
Otherwise we'll error when retrieving non-existent password.

// FREEBIE
2018-01-31 13:28:14 -08:00
Matthew Chen
4bfdef520a Respond to CR. 2018-01-30 12:39:27 -05:00
Matthew Chen
a30170b3b2 Prefer "app is ready" flag to "storage is ready" flag. 2018-01-30 11:34:00 -05:00
Matthew Chen
be1fde905c Don't mark app as ready until all version migrations are done. 2018-01-30 11:27:44 -05:00
Matthew Chen
963d0547ad Clean up ahead of PR. 2018-01-30 10:31:13 -05:00