Commit graph

23 commits

Author SHA1 Message Date
Michael Kirk af7ee5e1d1 address compiler breakage after rebase 2018-12-19 15:16:36 -07:00
Michael Kirk 5671fd2520 Revert "Revert 'new sort id'."
This reverts commit ebae75af00.
2018-12-19 15:16:36 -07:00
Matthew Chen fea40d571c Move contact offers to Conversation view model. 2018-12-13 09:12:41 -05:00
Matthew Chen ebae75af00 Revert 'new sort id'. 2018-09-27 19:40:51 -04:00
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 2018-09-26 09:52:33 -06:00
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
2018-09-26 09:52:33 -06:00
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
2018-09-26 09:52:33 -06:00
Michael Kirk 6c5fbc6de5 Update existing contact offers in place
WIP: migration / autoincrement logic

TODO:

-[x] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?

fixup contact offers
2018-09-26 09:52:33 -06:00
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
2018-09-07 10:00:48 -06:00
Matthew Chen ecafe546b6 Rework unread indicators. 2018-07-11 16:43:39 -04:00
Matthew Chen 8d72bb032e Rework unread indicators. 2018-07-11 16:43:39 -04:00
Michael Kirk 77fc5571fb Implement avatar sending
// FREEBIE
2018-05-07 12:08:41 -04:00
Michael Kirk 48b4791b13 Download avatar attachment stream
// FREEBIE
2018-05-07 12:08:41 -04:00
Michael Kirk 64ff4cd660 tap-to-retry failed thumbnail downloads
// FREEBIE
2018-04-16 16:06:18 -04:00
Matthew Chen fc2704cf88 Label quoted replies to yourself as such. 2018-04-11 14:40:18 -04:00
Matthew Chen f6698501df Revert "Label quoted replies to yourself as such."
This reverts commit 24d7492f61.
2018-04-11 11:48:08 -04:00
Matthew Chen 24d7492f61 Label quoted replies to yourself as such. 2018-04-11 11:47:33 -04:00
Matthew Chen 76995e4594 Enforce quoted reply edge cases. 2018-04-10 15:56:55 -04:00
Michael Kirk 81b2b57703 CR: add comments, make atomic
// FREEBIE
2018-04-09 12:47:57 -04:00
Michael Kirk 90486aa49c Inline method with one caller, fix formatting
// FREEBIE
2018-04-09 12:47:57 -04:00
Michael Kirk c56e8acc51 QuotedReplyModel from SSK->SignalMessaging
// FREEBIE
2018-04-09 12:47:56 -04:00
Matthew Chen 8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
2018-04-02 16:17:46 -04:00
Michael Kirk a58f1f385c Share a photo from photos app
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
2017-12-07 10:13:06 -05:00