Commit graph

1543 commits

Author SHA1 Message Date
Matthew Chen b714e528f5 Add UDManager. 2018-10-02 13:23:21 -04:00
Matthew Chen 21177e84db Fix or disable tests broken by recent merges. 2018-10-02 13:19:51 -04:00
Matthew Chen 71da312336 Post-SMK ud changes. 2018-10-02 13:19:41 -04:00
Matthew Chen 2c4c096d93 Fix typo in swift names. 2018-10-02 13:16:46 -04:00
Matthew Chen db487705c3 Fix breakage in the tests. 2018-10-02 12:42:07 -04:00
Michael Kirk 006021ea41 Fix: group color change doesn't immediately apply
Because we were fetching a new thread instance, instead of updating the
existing thread instance, classes which were bound to the old thread instance
weren't updating. This affected the HeaderView.AvatarView.thread and the
ConversationStyle.thread.
2018-10-01 17:06:09 -06:00
Matthew Chen 7d727b7ac9 Modify proto wrapper builders to require required fields. 2018-10-01 09:08:23 -04:00
Matthew Chen 74e456f90e Modify proto wrapper builders to require required fields. 2018-10-01 09:08:23 -04:00
Matthew Chen 04db4ca950 Get SMK tests building and passing. 2018-10-01 09:08:02 -04:00
Matthew Chen 8f5e21c7cf Fix build breakage from SMK. 2018-10-01 09:08:02 -04:00
Matthew Chen 3738155c81 Fix build breakage from SMK. 2018-10-01 09:08:02 -04:00
Matthew Chen 8ae200ac21 Fix build breakage around SignalCoreKit. 2018-10-01 09:07:40 -04:00
Matthew Chen b77528ca0a Fix asserts & logging. 2018-10-01 09:07:40 -04:00
Matthew Chen 0125535d4d Pull out SignalCoreKit. 2018-10-01 09:06:40 -04:00
Matthew Chen ebae75af00 Revert 'new sort id'. 2018-09-27 19:40:51 -04:00
Matthew Chen 3c22d0b0c8 Swift exit(). 2018-09-27 16:56:54 -04:00
Michael Kirk e3e6c31612 fix hang on conversation load 2018-09-27 15:29:00 -04:00
Michael Kirk 79add78d51 Merge branch 'release/2.30.1' 2018-09-27 13:03:35 -06:00
Matthew Chen bb5c9ff106 Respond to CR. 2018-09-27 13:56:07 -04:00
Matthew Chen c0f4254599 Mark CDS feature flag for removal. 2018-09-27 13:56:07 -04:00
Matthew Chen 0884598a3a Fix CDS cookie handling. 2018-09-27 13:56:07 -04:00
Matthew Chen c368aabf9c Fix the "de-register" logic. 2018-09-27 13:56:07 -04:00
Matthew Chen b10bf441c4 Add note about curl cookie support. 2018-09-27 13:56:07 -04:00
Matthew Chen 370c96af53 Enable CDS in contact intersection. 2018-09-27 13:56:07 -04:00
Matthew Chen 43d0b9b9bf Fix misnamed method. 2018-09-27 13:56:07 -04:00
Matthew Chen b6a14ea014 Fix the CDS version checking. 2018-09-27 13:56:07 -04:00
Matthew Chen bcb882f5aa Update CDS URLs. 2018-09-27 13:56:07 -04:00
Matthew Chen b3ad6e27dc Rework conversation message bubble colors; add "conversation colors" class. 2018-09-27 09:07:47 -04:00
Matthew Chen 8db4595bdc Rework group avatars to reflect conversation colors. 2018-09-27 08:55:20 -04:00
Michael Kirk fe7d69e9c6 Update thread's sorting order based on whatever the currently last message is 2018-09-26 09:52:34 -06:00
Michael Kirk 02692e42bd remove addressed TODO's 2018-09-26 09:52:34 -06:00
Michael Kirk 3240e0d9d0 Be explicit about receivedAt time
We were often using `timestampForLegacySorting`, which is convoluted for when
we actually just want received time.

In some sense this is a superficial change, but it's part of auditing that
we've completed moved away from timestampForLegacySorting.
2018-09-26 09:52:34 -06:00
Michael Kirk 6bfd0f29ed mark self-sent messages as read as soon as it was created 2018-09-26 09:52:34 -06:00
Michael Kirk c0c973de1c Sort gallery finder by sortId 2018-09-26 09:52:34 -06:00
Michael Kirk b281b37637 replace thread.lastMessageDate/archivalDate -> thread.lastSortId, thread.archivedAsOfSortId
Update migration accordingly

Date shown on home view cell is message.receivedAt
2018-09-26 09:52:34 -06:00
Michael Kirk 90aa593dcd sortId vs. Read status 2018-09-26 09:52:33 -06:00
Michael Kirk 089c4f09ea bump all views which rely on message sorting 2018-09-26 09:52:33 -06:00
Michael Kirk ab55e85304 step 1: timestampForSorting audit, change signature
No change in functionality in this commit, I just broke the signature to have a
systematic audit of the callsites. Added TODO's with the plan for each call.
2018-09-26 09:52:33 -06:00
Michael Kirk e1a46d85fb investigation shows we don't use this timestamp for call error messages 2018-09-26 09:52:33 -06:00
Michael Kirk df61316495 minimize diff senderTimestamp -> timestamp 2018-09-26 09:52:33 -06:00
Michael Kirk 00d0d1e002 Remove legacy Error backdating - no changes in functionality
Historically we would backdate the SN change messages, but since adopting
non-blocking SN changes long ago, they're already sorted properly by creation
time, so backdating has been unnecessary for a while.

I also audited that all other error messages are saved directly after creation.

I applied deprecation attributes as appropriate as I audited.
2018-09-26 09:52:33 -06:00
Michael Kirk 550e7ba63b Create disappearing message update info messages before messages they affect
Since we're no longer sorting by timestamp we have to ensure we save the update
info message before we save any affected message, e.g. in the case of implicit
updates.
2018-09-26 09:52:33 -06:00
Michael Kirk eef1368ad3 Timestamp audit step1: change signature
There is no change in functionality in this commit.

Apart from clarifying what the timestamp means (it's the timestamp of the
*sender*), this intentionally breaks all the call sites, so I could have a sane
way to thoroughly audit wherever we're passing in timestamps, to see where
we're depending on them to affect sort order.

For the sake of a cleaner diff of meaningful changes, instead of "fixing"
everything in this commit, I've just added comments and renamed signatures.
2018-09-26 09:52:33 -06:00
Michael Kirk a60d8eb161 WIP: migration / autoincrement logic
TODO:

-[ ] contact offer
-[ ] verify all paths that utilized timestampForSorting, e.g. make sure SN appear before the message they affect, etc.
-[x] Monotonic ID
-[x] New extension which sorts by id
-[x] Migration
  -[ ] batch migration?
2018-09-26 09:52:33 -06:00
Matthew Chen 72562920ed Fix author conversation colors. 2018-09-26 09:19:12 -04:00
Michael Kirk bccb633b6c fix release compile 2018-09-25 17:16:12 -06:00
Matthew Chen 8910f1f65a Enable conversation colors. 2018-09-25 16:11:37 -04:00
Matthew Chen 98630cca50 Respond to CR; add db utility methods to test base classes. 2018-09-21 09:21:34 -04:00
Matthew Chen 559c496ae5 Clean up. 2018-09-21 09:08:39 -04:00
Matthew Chen 66fc389fba Get SSK tests building and running. 2018-09-21 09:08:39 -04:00
Matthew Chen 87836f506b Move more singletons to SSKEnvironment. 2018-09-21 09:06:48 -04:00
Matthew Chen 39ebdf0921 Log curl command for failed requests in debug builds. 2018-09-20 14:02:35 -04:00
Matthew Chen 15b52db8bf Respond to CR. 2018-09-20 08:55:19 -04:00
Matthew Chen 29bb69032a DRY up the debounce of db extension version increment. 2018-09-20 08:55:19 -04:00
Matthew Chen e8186a7005 Fix rebase breakage. Make environment properties mutable in tests. 2018-09-19 16:30:03 -04:00
Matthew Chen 3b2c5bfc7b Modify mock environments to register all db views. 2018-09-19 16:29:15 -04:00
Matthew Chen 83e6484156 Respond to CR. Rework how OWSUploadOperation's networkManager property. 2018-09-19 16:28:03 -04:00
Matthew Chen edcedd2845 Remove selfRecipient method. 2018-09-19 15:11:26 -04:00
Matthew Chen e1db60c1c0 Rework creation of singletons. 2018-09-19 15:11:26 -04:00
Matthew Chen 4ad7ca79b7 Respond to CR. 2018-09-18 16:44:33 -04:00
Matthew Chen e8eac9f30b Clean up ahead of PR. 2018-09-18 16:35:13 -04:00
Matthew Chen b883209f91 Refine logging. 2018-09-18 16:35:12 -04:00
Matthew Chen 69290f7ec8 Improve logging around failied keychain deletion. 2018-09-18 09:07:54 -04:00
Matt Rubin d25579e478 Treat failure to delete a non-existent password as success
Fixes https://github.com/signalapp/Signal-iOS/issues/3876
2018-09-18 09:05:43 -04:00
Michael Kirk e1f131f09c restore save after marking item as uploaded
This was lost in an earlier fixup commit - markAsAccepted mutates but does not
persist anything since SPK doesn't know about YapDB
2018-09-17 10:10:32 -06:00
Michael Kirk cb55ba57f5 CR: rename classes, no functional changes 2018-09-17 10:10:32 -06:00
Michael Kirk 9f35b93647 CR: clarify comment 2018-09-17 10:10:32 -06:00
Michael Kirk 9bca1c8e52 Add some missing nullability annotations 2018-09-17 10:10:32 -06:00
Michael Kirk b3d3c27f39 CR: Split operations into separate files (no changes in functionality) 2018-09-17 10:10:32 -06:00
Michael Kirk ff3e9bcdd1 cr: add comment about operation queue 2018-09-17 10:10:32 -06:00
Michael Kirk bfd8eb63c6 Add some comments/nullability annotations for clarity 2018-09-17 10:10:32 -06:00
Michael Kirk c9218b59ca CR: add operation queue name 2018-09-17 10:10:32 -06:00
Michael Kirk 5a7d7634bf store keys before uploading to avoid race condition with service 2018-09-17 10:10:32 -06:00
Michael Kirk 1853e79c3e Don't retry send until SPK has been rotated
// FREEBIE
2018-09-17 10:10:32 -06:00
Michael Kirk 5e1306aaa5 Restore check debounce 2018-09-17 10:10:32 -06:00
Michael Kirk 8e488b5c3b remove unused code 2018-09-17 10:10:32 -06:00
Michael Kirk 85d35b52d6 restore PreKey upload failure tracking 2018-09-17 10:10:32 -06:00
Michael Kirk 39b691b697 Fix operations not being de-alloced 2018-09-17 10:10:32 -06:00
Michael Kirk 619597cd61 ensure operations run to completion on the PreKey operation queue 2018-09-17 10:10:32 -06:00
Michael Kirk 3df0e72eda Extract SPK rotation and CreatePreKey operations 2018-09-17 10:10:32 -06:00
Michael Kirk 286d3c8ce9 Serialize RefreshKeyOperation
TODO

-[] rotate signed prekey job
-[] verify current prekey w/ server
-[] create keys
2018-09-17 10:10:32 -06:00
Michael Kirk 01811a4891 fix swift method signature 2018-09-17 10:10:32 -06:00
Michael Kirk b11bd6ea46 extract convenience intitializer for param parser 2018-09-17 10:10:32 -06:00
Michael Kirk 1eb05c1d01 remove unused preKeyLastResort 2018-09-17 10:10:32 -06:00
Michael Kirk 920a82564f Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Matthew Chen 22afe39cd0 Respond to CR. 2018-09-14 14:34:50 -04:00
Matthew Chen 2ea751bbac Clean up attachment downloads. 2018-09-14 14:34:50 -04:00
Matthew Chen 32f1ce9473 Clean up attachment downloads. 2018-09-14 14:34:50 -04:00
Matthew Chen b00858921d Update Cocoapods. 2018-09-14 14:32:28 -04:00
Matthew Chen 9b94580dae Update assertions.
* Streamline precompiled headers.
* Remove obsolete assertions in Constraints.h.
2018-09-14 14:30:06 -04:00
Matthew Chen e15b8ebe16 Add names to operation queues. 2018-09-14 14:24:37 -04:00
Matthew Chen 62c55c9cfb Fix broken tests. 2018-09-14 14:20:39 -04:00
Matthew Chen 2ba642c9e9 Ensure fakes/mocks are debug-only. 2018-09-14 14:18:39 -04:00
Matthew Chen e784f9feeb Move fakes to SSK/tests. 2018-09-14 14:05:43 -04:00
Michael Kirk df67e883f3 BlockList vs. "zero length" group names 2018-09-14 11:32:39 -05:00
Michael Kirk 24ea8262d5 consolidate blocked-group state tracking 2018-09-14 10:51:39 -05:00
Michael Kirk 0f9b0936df Use cached group details when rendering blocklist 2018-09-14 10:31:17 -05:00
Michael Kirk 1f15ba6dc5 Cache group details on blocking manager
In case the group thread is later deleted.
2018-09-14 10:31:17 -05:00
Michael Kirk b96e9a6a82 Fix: not receiving group deliveries
Previously we were using the wrong method - the local user's id is removed
from group.recipientIdentifiers
2018-09-13 09:57:35 -05:00
Michael Kirk f1e5b1862f Ignore messages from left groups 2018-09-12 19:16:14 -05:00
Michael Kirk b369ffa88f add type annotations 2018-09-12 19:16:14 -05:00
Michael Kirk b6eb1476cb Leave group when blocking it 2018-09-12 19:16:14 -05:00
Michael Kirk 2c9d905a16 Message processor ignores messages from blocked group 2018-09-12 19:16:14 -05:00
Michael Kirk eadb04efcc WIP: ContactViewHelper incorporates group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] ConversationViewHelper
   -[x] Track blocked groups
   -[ ] HomeView
   -[ ] ConversationView
   -[ ] Any others?
   -[ ] Rename? Extract BlockList cache?
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[x] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
2018-09-12 19:16:14 -05:00
Michael Kirk b282d51da0 SyncMessages for blocked groups 2018-09-12 19:16:14 -05:00
Michael Kirk 236c17f65e WIP: group blocking
-[ ] UI
  -[ ] Conversation Settings
    -[x] Show switch for group
    -[ ] localize
    -[ ] migrate existing localizations? (nice to have)
    -[ ] can view conversation settings (but not edit them) in left group
    -[ ] special block copy for groups
    -[ ] special unblock copy for groups
  -[ ] Block List
    -[ ] Group Section
    -[ ] Unblock group
  -[ ] Interstitial interacting with blocked threads (e.g. thread picker)
    -[ ] BlockListUIUtils w/ thread
        -[x] Block
        -[x] Unblock
        -[ ] Replace usages where possible
        -[x] block manager
-[ ] Sync
  -[x] tentative protos
  -[ ] confirm protos w/ team
  -[ ] send new protos
-[ ] Message Processing
  -[ ] Drop messages from blocked groups
2018-09-12 19:16:14 -05:00
Michael Kirk bfe1f38c75 update protos for group blocking 2018-09-12 19:16:14 -05:00
Michael Kirk 08c0b248ed fix group avatar updates and quote generation
don't shadow same-named variable
2018-09-12 15:01:57 -05:00
Matthew Chen 25239ca608 Respond to CR. 2018-09-10 17:43:17 -05:00
Matthew Chen 3935b019f4 Add base class for tests. 2018-09-10 17:30:18 -05:00
Michael Kirk e4d12feeb9 rev gallery db extension since our isValid checks have changed 2018-09-07 16:37:00 -06:00
Matthew Chen 106ecf2e8e Respond to CR. 2018-09-07 16:25:10 -04:00
Matthew Chen cc117b385c Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:59 -04:00
Matthew Chen 3a12446be8 Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:41 -04:00
Matthew Chen bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 2018-09-07 16:19:00 -04:00
Matthew Chen bcceda1861 Respond to CR. 2018-09-07 16:05:57 -04:00
Matthew Chen cfb511aa57 Respond to CR. 2018-09-07 16:00:32 -04:00
Matthew Chen eb616a3411 Respond to CR. 2018-09-07 15:37:40 -04:00
Matthew Chen 535241ef9e Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 2018-09-07 15:37:40 -04:00
Matthew Chen 399dd13cee Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 2018-09-07 15:37:40 -04:00
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 2018-09-07 15:27:50 -04:00
Michael Kirk 9ec82b9a44 graceful failure when receiving too-small profile data 2018-09-07 11:02:52 -06:00
Michael Kirk 503cb046e4 remove unused FunctionalUtil code 2018-09-07 11:02:52 -06:00
Michael Kirk a2852ee930 Overflow math and safer asserts in Cryptography.m
Also removed some unused code
2018-09-07 11:02:52 -06:00
Michael Kirk c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
2018-09-07 10:00:48 -06:00
Michael Kirk a54ed8b201 Step 1/2 Prefer safer asserts 2018-09-07 10:00:48 -06:00
Matthew Chen 9fefdd2e2c Respond to CR. 2018-09-06 16:04:01 -04:00
Matthew Chen a2fe4dbe39 Refine image validation. 2018-09-06 16:04:01 -04:00
Matthew Chen 34a05cdb85 Refine image validation. 2018-09-06 16:04:01 -04:00
Matthew Chen b6649319da Fix build breakage. 2018-09-06 16:03:29 -04:00
Matthew Chen 27fa5dc2ef Make thumbnail logic thread-safe to being called on main thread. 2018-09-06 16:03:29 -04:00
Matthew Chen a04aa259ed Fix bug in sync loading of thumbnails. 2018-09-06 16:03:29 -04:00
Matthew Chen 5bdbf76b08 Cache "is valid image/video" properties. 2018-09-06 16:03:29 -04:00
Matthew Chen b1f2b9e75c Clean up thumbnail-related logic. 2018-09-06 16:03:29 -04:00
Matthew Chen a088b94c74 Update Cocoapods, fix build breakage. 2018-09-06 15:37:24 -04:00
Matthew Chen b91751a114 Respond to CR. 2018-09-06 15:30:00 -04:00
Matthew Chen 748b243156 Restore full-screen thumbnails. 2018-09-06 15:30:00 -04:00
Matthew Chen 9eb2a4f5ad Raise max valid image size. 2018-09-06 15:30:00 -04:00
Matthew Chen 72a71c185b Improve handling of thumbnails dir. 2018-09-06 15:30:00 -04:00
Matthew Chen 3a5d1877da Reduce thumbnail sizes. 2018-09-06 15:30:00 -04:00
Matthew Chen ec83ed182b Clean up. 2018-09-06 15:30:00 -04:00
Matthew Chen 32bf47fc74 Don't track thumbnail metadata in db; improve thumbnail quality. 2018-09-06 15:30:00 -04:00
Matthew Chen 8026d34651 Remove full-screen thumbnail. 2018-09-06 15:30:00 -04:00
Matthew Chen 2daa66fdf6 Use thumbnails dir. 2018-09-06 15:30:00 -04:00
Matthew Chen a9096209e9 Add failure methods to thumbnail service. 2018-09-06 15:30:00 -04:00
Matthew Chen 8748dc9b2e Modify new thumbnail system to include video and GIF thumbnails. 2018-09-06 15:30:00 -04:00
Matthew Chen 206432fdf0 Add failure methods to thumbnail service. 2018-09-06 15:30:00 -04:00
Matthew Chen f6e792c707 Add failure methods to thumbnail service. 2018-09-06 15:30:00 -04:00
Matthew Chen 3437361d70 Use new thumbnails in media gallery thumbnails. 2018-09-06 15:30:00 -04:00
Matthew Chen ac4365e1c9 Add OWSThumbnailService. 2018-09-06 15:30:00 -04:00
Matthew Chen 1831f0b1f8 Reorder AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen 446ceb2b9c Rename AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen 498828f93c Rename AttachmentStream methods. 2018-09-06 15:30:00 -04:00
Matthew Chen 44a3a81469 Update logging and asserts in hotfix changes. 2018-09-04 16:12:41 -04:00
Matthew Chen 9ab4da5c81 cherry-pick Merge branch 'charlesmchen/logSdp' 2018-09-04 13:51:31 -06:00
Matthew Chen fac7f6932f Rename TSGroupMetaMessage enum values. 2018-09-04 09:30:01 -04:00
Matthew Chen f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 2018-09-04 09:27:41 -04:00
Michael Kirk 495830f08d Fixup some SSK tests
Still more to do...
2018-08-31 11:03:27 -06:00
Michael Kirk 6d92413931 WIP: Run SSK tests
This just configures them to run. They're very broken at the moment.
2018-08-31 12:35:32 -04:00
Michael Kirk 6821e4a3a5 Don't include invalid media in gallery 2018-08-30 19:21:45 -06:00
Michael Kirk e715bf9ea2 image sizing
Validate image sizing
2018-08-30 19:21:38 -06:00
Matthew Chen 9477606732 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen f473f60111 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen 03829779cc Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen c0d486b1f1 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen 3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen d81dea1d84 Add OWS log macros. 2018-08-27 12:58:50 -04:00
Matthew Chen 2d06c05a4f Log call session description. 2018-08-27 10:49:25 -04:00
Matthew Chen 713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
Matthew Chen 7be8f30877 Apply -> Never. 2018-08-27 10:21:03 -04:00
Matthew Chen d01023d862 Respond to CR. 2018-08-27 10:07:14 -04:00
Matthew Chen 11eaf1474e Add OWSProdExit(). 2018-08-27 10:07:14 -04:00
Matthew Chen 4f2f4a44a0 Respond to CR. 2018-08-27 10:04:27 -04:00
Matthew Chen d4f7b5d45b Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen f34bdd34bc Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen dd4f1babba Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen e1049fdfcc Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen bc23e38efc Respond to CR. 2018-08-27 10:02:28 -04:00
Matthew Chen cf6f3841a8 Apply new Swift logging. 2018-08-27 10:02:28 -04:00
Matthew Chen 3697974ca8 Rework Swift logging. 2018-08-27 10:02:28 -04:00
Michael Kirk 82e559d11b Use swift macros for main thread assert 2018-08-23 10:29:49 -06:00
Michael Kirk 2fc3a211f1 restrict debug methods 2018-08-23 10:16:40 -06:00
Michael Kirk 1295a09ab3 add comment 2018-08-22 16:25:53 -06:00
Matthew Chen 2b8b688fb6 Disable CDS. 2018-08-20 15:38:30 -04:00
Matthew Chen 2af0a897e1 Disable CDS. 2018-08-20 15:34:04 -04:00
Michael Kirk d57cbf2acd main thread operation init which creates background task
// FREEBIE
2018-08-20 12:21:48 -06:00
Matthew Chen 52be2127ff Sync conversation colors. 2018-08-16 15:21:39 -04:00
Matthew Chen b347c40c66 Clean up ahead of PR. 2018-08-16 12:21:03 -04:00
Matthew Chen 0a7b3537b5 Recreate message database view when message mappings are corrupt. 2018-08-16 12:21:03 -04:00
Matthew Chen 8ce9f3b24d Fix nominal race in "is registered" state. 2018-08-15 10:38:47 -04:00
Matthew Chen 26001e49d1 Unify log tags. 2018-08-15 10:24:29 -04:00
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 2018-08-10 16:55:54 -06:00
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
2018-08-09 15:30:19 -06:00
Matthew Chen db3df249bf Merge NSData categories. 2018-08-09 13:50:55 -04:00
Matthew Chen 2c9c028504 Clean up. 2018-08-09 09:51:23 -06:00
Matthew Chen 7437e7a6b1 Remove 'has' accessors from proto wrappers. 2018-08-08 15:02:56 -04:00
Matthew Chen 1868c58037 Converge appLaunchTime. 2018-08-08 13:53:24 -04:00
Matthew Chen b3c62d91be Merge remote-tracking branch 'origin/release/2.28.1' 2018-08-08 13:51:52 -04:00
Matthew Chen e5eda8b45d Add convenience initializers to proto wrappers. 2018-08-08 13:08:47 -04:00
Michael Kirk ab62868851 Remove noisy comments, update rotation time. 2018-08-07 14:37:13 -06:00
Matthew Chen 21523ac522 Respond to CR. 2018-08-07 15:29:21 -04:00
Matthew Chen 1ab0842403 Remove Obj-c proto parser. 2018-08-07 15:10:48 -04:00
Matthew Chen a5ffbdebb3 Remove Obj-c proto parser. 2018-08-07 15:10:48 -04:00
Matthew Chen dc012d46e4 Migrate call proto wrappers. 2018-08-07 14:40:49 -04:00
Matthew Chen 135a1655fd Migrate call proto wrappers. 2018-08-07 14:40:49 -04:00
Matthew Chen 32d0f23b22 Migrate call proto wrappers. 2018-08-07 14:40:49 -04:00
Matthew Chen 94675e880a Migrate call proto wrappers. 2018-08-07 14:40:49 -04:00
Matthew Chen 8837e5902e Migrate call proto wrappers. 2018-08-07 14:40:49 -04:00
Matthew Chen 68241e8a0a Respond to CR. 2018-08-07 14:36:36 -04:00
Matthew Chen 34a404f589 Clean up ahead of PR. 2018-08-07 13:20:22 -04:00
Matthew Chen 67110d0def Migrate to websocket proto wrappers. 2018-08-07 13:20:22 -04:00
Matthew Chen f795ec352e Migrate to backup proto wrappers. 2018-08-07 13:20:22 -04:00
Matthew Chen eaf59b122d Migrate to provisioning proto wrappers. 2018-08-07 13:20:22 -04:00
Matthew Chen 50db472be5 Migrate to fingerprint proto wrappers. 2018-08-07 13:20:22 -04:00
Matthew Chen 45e782c243 Revamp orphan data cleaner. 2018-08-07 13:07:26 -04:00
Michael Kirk 87f97b8b97 fix typo 2018-08-06 13:36:42 -06:00
Michael Kirk 504f4afae5 fix typo 2018-08-06 13:36:38 -06:00
Michael Kirk 2e5cae2a6b Fix typo 2018-08-06 13:34:47 -06:00
Matthew Chen 463addaa6c Ignore new calls in the incomplete calls job. 2018-08-06 14:10:25 -04:00
Matthew Chen d3a4447f81 Convert overzealous assert. 2018-08-06 09:34:26 -04:00
Matthew Chen 64c6d820fd Fix typo. 2018-08-06 09:26:02 -04:00
Matthew Chen d709a02493 Clean up formatting. 2018-08-06 09:02:40 -04:00
Michael Kirk 0bc03b0fd4 Move seed 2018-08-03 14:26:43 -06:00
Michael Kirk fc1ce02ae5 CR: Now that we have transaction semantics, this shouldn't happen.
// FREEBIE
2018-08-03 14:10:46 -06:00
Michael Kirk 1eb7fc986c YapDB introduced a method purpose built to do what we were approximating.
This seems a little more future proof / less error prone if we change the
registered extensions.
2018-08-03 14:09:35 -06:00
Michael Kirk df01c7e63e Update to latest YapDB (with Signal patches applied)
Applied branches:

- mkirk/invalidFinalIndices
- mkirk/upstream-unencrypted-headers

Also fixed up test suite.
2018-08-03 14:09:35 -06:00
Matthew Chen a647b5be48 Respond to CR. 2018-08-03 15:50:27 -04:00
Matthew Chen 3f47524373 Respond to CR. 2018-08-03 14:52:55 -04:00
Matthew Chen 03a9b21cfd Respond to CR. 2018-08-03 14:35:22 -04:00
Matthew Chen 632dc145fd Code generate Swift wrappers for protocol buffers. 2018-08-03 14:05:20 -04:00
Matthew Chen 6be3d2e42d Code generate Swift wrappers for protocol buffers. 2018-08-03 14:05:20 -04:00
Matthew Chen 8d814a5210 Code generate Swift wrappers for protocol buffers. 2018-08-03 14:05:20 -04:00
Matthew Chen 950cab7eb9 Code generate Swift wrappers for protocol buffers. 2018-08-03 14:05:20 -04:00
Matthew Chen ff8565dbd5 Code generate Swift wrappers for protocol buffers. 2018-08-03 14:05:20 -04:00
Matthew Chen d3adb80242 Code generate Swift wrappers for protocol buffers. 2018-08-03 14:05:20 -04:00
Matthew Chen ab31e5a07f Code generate Swift wrappers for protocol buffers. 2018-08-03 14:05:20 -04:00
Matthew Chen 28acea3cf0 Respond to CR. 2018-08-03 14:03:02 -04:00
Matthew Chen e1eb58ba3b Swift proto parsing wrappers. 2018-08-02 14:28:13 -04:00
Matthew Chen 0d23b06cbc Code generate Swift wrappers for protocol buffers. 2018-08-02 14:27:05 -04:00
Matthew Chen 377634a1f7 Code generate Swift wrappers for protocol buffers. 2018-08-02 14:27:05 -04:00
Matthew Chen b164ce9403 Code generate Swift wrappers for protocol buffers. 2018-08-02 14:27:05 -04:00
Matthew Chen 73f22ae62e Code generate Swift wrappers for protocol buffers. 2018-08-01 16:55:32 -04:00
Matthew Chen 6941ab8c8c Code generate Swift wrappers for protocol buffers. 2018-08-01 16:16:39 -04:00
Matthew Chen 827f979282 Code generate Swift wrappers for protocol buffers. 2018-08-01 15:55:00 -04:00
Matthew Chen 77810f5918 Code generate Swift wrappers for protocol buffers. 2018-08-01 15:36:52 -04:00
Matthew Chen 64c99988a7 Code generate Swift wrappers for protocol buffers. 2018-08-01 14:37:09 -04:00
Matthew Chen 02a4de637e Code generate Swift wrappers for protocol buffers. 2018-08-01 11:44:44 -04:00
Matthew Chen 2b05bbc0aa Code generate Swift wrappers for protocol buffers. 2018-08-01 11:20:55 -04:00