Commit graph

4557 commits

Author SHA1 Message Date
Michael Kirk
891cc6ee0d CR: better method names
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
6eaa49593d preview vs. sending have independent resolution min
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
688810c267 CR: Enforce "one time only" with a bool, not a cell ref
Since cell's can be re-used, at a later point, we might not be
referencing the data we intend. Since all we want to do is enforce a
"one time only" check, just use a bool.

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
591cba6468 fix comment typos
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
a01de44917 Fix intermittent crash
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
6db5895269 dismiss keyboard when scrolling after auto-search
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
be51776d82 Fix mask appearing partially above search bar
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
37177de7cb Make sure user knows what they're picking
Abort selection until *some* kind of asset has been downloaded.

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
e4ad169d71 Show retryable error alert when fetching GIF fails
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
3939e8a6ac Download picked GIF faster: cancel pending request
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
b8ce636afc Show loading screen while selected GIF downloads
// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
ddf2fe21a1 Download smaller GIF for previews.
Previously we were downloading a full sized GIF for each cell, which can
take dozens of seconds on a slower connection. Now we download a smaller
GIF for the picker view, and only download the full sized GIF for the
selected cell.

Some stats:

Before:

Scenario: search "Cat" and no scrolling, no picking
~10 MB

Scenario: search "Cat" and no scrolling, then pick
~10 MB

Scenario: search "Cat" and scroll 3 screens, no picking
~30 MB

Scenario: search "Cat" and scroll 3 screens, then pick
~30 MB

After:

Scenarios: search "Cat" and no scrolling, no picking
~1.0 MB (savings 90%)

Scenarios: search "Cat" and no scrolling, then pick
~3.5 MB (savings 65%)

Scenarios: search "Cat" and scroll 3 screens, no picking
~3.0 MB (savings 90%)

Scenarios: search "Cat" and scroll 3 screens, then pick
~5.5 MB (savings 81%)

// FREEBIE
2017-10-20 12:34:55 -07:00
Michael Kirk
2a4c6506fb log giphy data usage in debug
// FREEBIE
2017-10-20 12:34:55 -07:00
Matthew Chen
7fa7d5d526 Fix "mark as read."
// FREEBIE
2017-10-20 09:53:33 -04:00
Matthew Chen
21cdaeed0f Merge branch 'charlesmchen/cleanupConversationView' 2017-10-19 23:03:13 -04:00
Matthew Chen
b0aa84e420 Clean up conversation view.
// FREEBIE
2017-10-19 23:02:59 -04:00
Matthew Chen
bc6b5d088b Merge branch 'charlesmchen/reloadAndLayoutChurn' 2017-10-19 22:53:58 -04:00
Matthew Chen
d355b45bae Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen
c2608785e1 Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen
385d7c0c77 Merge branch 'charlesmchen/textInputVsLeaveConversationView' 2017-10-19 22:48:39 -04:00
Matthew Chen
4dc6934fc7 End text editing if we leave conversation view.
// FREEBIE
2017-10-19 22:48:28 -04:00
Matthew Chen
27d8af6940 Merge branch 'charlesmchen/linkifyTextMessages' 2017-10-19 22:41:40 -04:00
Matthew Chen
bd5639baaf Linkify text messages.
// FREEBIE
2017-10-19 22:41:32 -04:00
Matthew Chen
98433272b0 Merge branch 'charlesmchen/fixMessageCellLayout' 2017-10-19 22:41:01 -04:00
Matthew Chen
bf80e6dd36 Fix broken message cell layout.
// FREEBIE
2017-10-19 22:40:52 -04:00
Matthew Chen
990fd1cca9 Merge branch 'charlesmchen/autoLoadMore' 2017-10-19 22:39:51 -04:00
Matthew Chen
45ba79d296 Auto-load more message if user scrolls near the top of the conversation.
// FREEBIE
2017-10-19 22:39:42 -04:00
Matthew Chen
7249a04a80 Merge branch 'charlesmchen/fixMessageInjection' 2017-10-19 22:39:12 -04:00
Matthew Chen
1ad3add1d5 Fix message injection.
// FREEBIE
2017-10-19 22:39:01 -04:00
Matthew Chen
1529ded433 Merge branch 'charlesmchen/resetKeyboardAfterSend' 2017-10-19 22:37:26 -04:00
Matthew Chen
c7097db939 Respond to CR.
// FREEBIE
2017-10-19 22:37:17 -04:00
Matthew Chen
f28abbc2a1 Revert from numeric to default keyboard after message send.
// FREEBIE
2017-10-19 22:36:25 -04:00
Matthew Chen
4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 22:33:51 -04:00
Matthew Chen
31941de1bf Merge branch 'charlesmchen/sendGifTwice' 2017-10-19 22:31:29 -04:00
Matthew Chen
fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 10:04:49 -07:00
Michael Kirk
9eb4909185 bump build
// FREEBIE
2017-10-18 16:30:57 -07:00
Matthew Chen
fb360cd41f Merge branch 'charlesmchen/attachmentApprovalInInputToolbar' 2017-10-18 12:53:39 -07:00
Matthew Chen
f3102e2761 Fix presentation animation of new "attachment approval" state of input toolbar.
// FREEBIE
2017-10-18 12:50:16 -07:00
Matthew Chen
0fe76aaab8 Move "attachment approval" into input toolbar.
// FREEBIE
2017-10-18 12:50:16 -07:00
Matthew Chen
7e41489d82 Merge branch 'charlesmchen/menuController' 2017-10-18 12:31:32 -07:00
Matthew Chen
298a4aa108 Simplify and fix edge cases around menu controller.
// FREEBIE
2017-10-18 12:31:23 -07:00
Matthew Chen
06eb794db6 Simplify and fix edge cases around long pressing on system message cells.
// FREEBIE
2017-10-18 12:31:23 -07:00
Matthew Chen
6cba186d8a Merge branch 'charlesmchen/inputPlaceholder' 2017-10-18 12:21:40 -07:00
Matthew Chen
37841d9b67 Respond to CR.
// FREEBIE
2017-10-18 12:21:17 -07:00
Matthew Chen
4a94d039e8 Restore the input toolbar's placeholder text.
// FREEBIE
2017-10-18 12:18:15 -07:00
Matthew Chen
7d3df0bf0a Merge branch 'charlesmchen/conversationCellPerf' 2017-10-18 12:13:33 -07:00
Matthew Chen
c47573334b Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
3b945a9da2 Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
88c874e4e6 Clean up ahead of PR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
257f8249bf Cull cached cell media outside a load window.
// FREEBIE
2017-10-18 12:13:26 -07:00