Commit graph

5144 commits

Author SHA1 Message Date
Michael Kirk 21fd7b040e Ensure sent video is mp4
// FREEBIE
2017-12-11 14:03:40 -05:00
Michael Kirk 3ad409238a Merge branch 'mkirk/approval-view-revamp' 2017-12-11 13:58:20 -05:00
Michael Kirk d3e7c99a63 Attachment approval: cancel/confirm to top/bottom toolbars
- avoid double-submit by disabling after hitting send.
- Animate SAE dismissal as modal
  Requires hiding the load view
- attachment is centered in screen
- add gradient to ensure controls are visible
- Fix clamp constraints - I think this was a typo
  Otherwise we couldn't show an image which was 1" wide by 2" tall
- set max zoom, hide scroll indicators
- use media view
- slower panning feels right
- white send button
- can share GIF, static, and sort of video...
- Play button for attachment approval
  - move to image assets so we can use it in SAE
  - slightly larger button for full-screen approval view
  - don't launch redundant fullscreen UI for images when in approval view
- fix scrollOffset in AttachmentApproval
- consolidate view initialization logic in loadView and fix white background
- CR: more legible arithmetic

// FREEBIE
2017-12-11 13:58:03 -05:00
Matthew Chen fc26c3fdb1 Merge branch 'charlesmchen/profileManagerConcurrency' 2017-12-11 12:38:11 -05:00
Matthew Chen 8642a708e7 Respond to CR. 2017-12-11 12:37:47 -05:00
Matthew Chen b9b3eb0541 Clean up ahead of PR. 2017-12-11 12:28:28 -05:00
Matthew Chen 429312523f Simplify OWSUserProfile's "apply changes" logic using model diffing. 2017-12-11 12:28:28 -05:00
Matthew Chen ee92efd4a8 Don't emit "user profile changed" notifications if nothing changed. 2017-12-11 12:28:28 -05:00
Matthew Chen f684482c54 Don't emit "user profile changed" notifications if nothing changed. 2017-12-11 12:28:28 -05:00
Matthew Chen 7b4aa4056c Don't emit "user profile changed" notifications if nothing changed. 2017-12-11 12:28:28 -05:00
Matthew Chen 97ce1a6675 Rework user profile saves; block SAE if no local user profile key. 2017-12-11 12:28:28 -05:00
Matthew Chen 3ea901044a Rework thread safety in profile manager. 2017-12-11 12:28:28 -05:00
Matthew Chen 74efcb9041 Rework thread safety in profile manager. 2017-12-11 12:28:28 -05:00
Matthew Chen ee300590e3 Rework thread safety in profile manager. 2017-12-11 12:28:28 -05:00
Matthew Chen 911c4d380b Rework thread safety in profile manager. 2017-12-11 12:28:28 -05:00
Matthew Chen c1d435c9d8 Merge branch 'charlesmchen/imageQualityRevisited' 2017-12-11 11:35:26 -05:00
Matthew Chen bf09c805b9 Respond to CR. 2017-12-11 11:27:53 -05:00
Matthew Chen c918279597 Convert image attachment thresholds to be based on file size. 2017-12-11 10:37:20 -05:00
Matthew Chen 80ae5e0fcf Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 11b4848530 Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 89db8b3a44 Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 84061cca9f Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Matthew Chen 55aa5eef6c Clean up ahead of PR. 2017-12-11 10:37:20 -05:00
Matthew Chen 125aabb0a3 Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Michael Kirk be5ac85276 Merge branch 'mkirk/track-dyload-time' 2017-12-08 13:35:42 -05:00
Michael Kirk ddd2004824 track dyload time 2017-12-08 13:35:19 -05:00
Michael Kirk b6f3c69f82 Merge branch 'mkirk/fixup-headers' 2017-12-08 13:32:58 -05:00
Michael Kirk d9cca77e23 update header references
// FREEBIE
2017-12-08 13:32:52 -05:00
Michael Kirk 726fde235a Merge branch 'mkirk/affix-searchbar' 2017-12-08 13:32:26 -05:00
Michael Kirk 23014f9ea4 Keep header affixed to navbar.
// FREEBIE
2017-12-08 11:40:59 -05:00
Michael Kirk b014c236b8 bump build number 2017-12-07 18:05:18 -05:00
Michael Kirk f7dfe23c66 sync translations 2017-12-07 18:00:30 -05:00
Michael Kirk d6359d6551 Update carthage - WebRTC M63
// FREEBIE
2017-12-07 17:32:41 -05:00
Michael Kirk 71f56ef3da Merge branch 'mkirk/dismiss-share-view' 2017-12-07 17:28:02 -05:00
Michael Kirk 1c74d8f912 CR: remove reset of BundleDocumentTypes 2017-12-07 17:27:37 -05:00
Michael Kirk dd1795e337 fixup rebae 2017-12-07 17:12:03 -05:00
Michael Kirk 3ecf0a7537 Cancelling dismisses share extension, remove "import with signal"
Usinig the new ShareViewDelegate to dismiss the share extension, might
have broken the "import with signal" functionality. But because we
want to remove it anyway, I've done that now, rather than fix it up.

// FREEBIE
2017-12-07 17:12:03 -05:00
Michael Kirk 2cd3ce62f9 Merge branch 'mkirk/conversation-picker-presentation' 2017-12-07 16:48:21 -05:00
Michael Kirk ed33663e6d CR: remove redundant isHidden
// FREEBIE
2017-12-07 16:48:02 -05:00
Michael Kirk cd95e1784b avoid race condition in presentation animation 2017-12-07 16:48:02 -05:00
Michael Kirk 3bb772f135 Modal conversation picker, hide loading screen when possible
The first usable screen in the conversation picker, that's the first
thing we want to show the user, and the modal presentation feels like
the right way to introduce this new context.

Long load times should be the exception, not the normal flow, so we
delay it's presentation in hopes that it will generally never be seen.

// FREEBIE
2017-12-07 16:48:01 -05:00
Matthew Chen 6bb9b9cbc6 Merge branch 'charlesmchen/saeSetupOrder' 2017-12-07 16:29:31 -05:00
Matthew Chen d15d5ce3a2 Respond to CR. 2017-12-07 16:29:24 -05:00
Matthew Chen 791743a5f0 Fix order of operations in SAE setup. 2017-12-07 16:04:52 -05:00
Matthew Chen 03d1165947 Merge branch 'charlesmchen/estonianAndTaiwaneseChinese' 2017-12-07 14:46:21 -05:00
Matthew Chen 345323fe8a Add Estonian and Taiwanese Chinese localizations. 2017-12-07 14:46:12 -05:00
Matthew Chen 5053b02681 Merge branch 'charlesmchen/logTagProperty' 2017-12-07 14:44:53 -05:00
Matthew Chen f7bcf1d04d Fix tests. 2017-12-07 14:44:38 -05:00
Matthew Chen 1be828574d Respond to CR. 2017-12-07 14:33:54 -05:00
Matthew Chen f148003fb3 Convert logTag to property. 2017-12-07 14:32:22 -05:00