Commit graph

8983 commits

Author SHA1 Message Date
Matthew Chen 687be6b79d Merge branch 'charlesmchen/assertReview' 2018-09-18 16:45:00 -04:00
Matthew Chen 4ad7ca79b7 Respond to CR. 2018-09-18 16:44:33 -04:00
Matthew Chen e8eac9f30b Clean up ahead of PR. 2018-09-18 16:35:13 -04:00
Matthew Chen b883209f91 Refine logging. 2018-09-18 16:35:12 -04:00
Matthew Chen 03f10b723e Merge branch 'delete-legacy-passphrase-fix' 2018-09-18 09:08:30 -04:00
Matthew Chen 69290f7ec8 Improve logging around failied keychain deletion. 2018-09-18 09:07:54 -04:00
Matt Rubin d25579e478 Treat failure to delete a non-existent password as success
Fixes https://github.com/signalapp/Signal-iOS/issues/3876
2018-09-18 09:05:43 -04:00
Michael Kirk ec019f2863 Merge branch 'mkirk/fix-test-run' 2018-09-17 12:41:12 -06:00
Michael Kirk 25bec86325 update pods 2018-09-17 12:38:36 -06:00
Michael Kirk 60a6128afd Remove SSK tests from Signal-iOS xcode test run
Firstly, they aren't compiling (and haven't been for a while), and thus prevent
iOS tests from running and being written. This can and should be fixed.

Secondly, they don't respect the ubsan.supp file. I'm not sure how to fix this.
We may just not be able to run the SSK tests as part of the Signal-iOS test
runner, and instead have to revert to running them from within a separate test
app.
2018-09-17 12:37:51 -06:00
Michael Kirk 13856acb02 remove wrong import 2018-09-17 12:37:51 -06:00
Michael Kirk e9f0c31d49 Merge branch 'mkirk/debounce-prekey-checks2' 2018-09-17 10:14:28 -06:00
Michael Kirk ec77b83c36 update pods 2018-09-17 10:13:30 -06:00
Michael Kirk e1f131f09c restore save after marking item as uploaded
This was lost in an earlier fixup commit - markAsAccepted mutates but does not
persist anything since SPK doesn't know about YapDB
2018-09-17 10:10:32 -06:00
Michael Kirk cb55ba57f5 CR: rename classes, no functional changes 2018-09-17 10:10:32 -06:00
Michael Kirk 9f35b93647 CR: clarify comment 2018-09-17 10:10:32 -06:00
Michael Kirk f5efa9ee90 update pods 2018-09-17 10:10:32 -06:00
Michael Kirk 9bca1c8e52 Add some missing nullability annotations 2018-09-17 10:10:32 -06:00
Michael Kirk b3d3c27f39 CR: Split operations into separate files (no changes in functionality) 2018-09-17 10:10:32 -06:00
Michael Kirk ff3e9bcdd1 cr: add comment about operation queue 2018-09-17 10:10:32 -06:00
Michael Kirk bfd8eb63c6 Add some comments/nullability annotations for clarity 2018-09-17 10:10:32 -06:00
Michael Kirk c9218b59ca CR: add operation queue name 2018-09-17 10:10:32 -06:00
Michael Kirk 5a7d7634bf store keys before uploading to avoid race condition with service 2018-09-17 10:10:32 -06:00
Michael Kirk 1853e79c3e Don't retry send until SPK has been rotated
// FREEBIE
2018-09-17 10:10:32 -06:00
Michael Kirk 5e1306aaa5 Restore check debounce 2018-09-17 10:10:32 -06:00
Michael Kirk 8e488b5c3b remove unused code 2018-09-17 10:10:32 -06:00
Michael Kirk 85d35b52d6 restore PreKey upload failure tracking 2018-09-17 10:10:32 -06:00
Michael Kirk 39b691b697 Fix operations not being de-alloced 2018-09-17 10:10:32 -06:00
Michael Kirk 619597cd61 ensure operations run to completion on the PreKey operation queue 2018-09-17 10:10:32 -06:00
Michael Kirk 3df0e72eda Extract SPK rotation and CreatePreKey operations 2018-09-17 10:10:32 -06:00
Michael Kirk 286d3c8ce9 Serialize RefreshKeyOperation
TODO

-[] rotate signed prekey job
-[] verify current prekey w/ server
-[] create keys
2018-09-17 10:10:32 -06:00
Michael Kirk 01811a4891 fix swift method signature 2018-09-17 10:10:32 -06:00
Michael Kirk b11bd6ea46 extract convenience intitializer for param parser 2018-09-17 10:10:32 -06:00
Michael Kirk 1eb05c1d01 remove unused preKeyLastResort 2018-09-17 10:10:32 -06:00
Michael Kirk 966db1bd49 Get tests compiling by any means necessary
comment out and fail tests which don't compile
2018-09-17 10:10:32 -06:00
Michael Kirk fdc846cb55 remove test for deleted method 2018-09-17 10:10:32 -06:00
Michael Kirk 170eb63772 update old non-existant API usage 2018-09-17 10:10:32 -06:00
Michael Kirk 7a832e85ec remove wrong import 2018-09-17 10:10:32 -06:00
Michael Kirk f285fc4e11 Merge branch 'mkirk/keyword-checks' 2018-09-17 10:04:11 -06:00
Michael Kirk 5236fba691 keyword checks 2018-09-17 09:50:22 -06:00
Michael Kirk 551102210e include C assert variants in keywords check 2018-09-17 09:36:44 -06:00
Michael Kirk 920a82564f Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Michael Kirk e7f9598e68 disable dark theme switch for production 2018-09-14 17:45:32 -05:00
Michael Kirk 2ffca98075 "Bump build to 2.29.3.3." 2018-09-14 17:43:16 -05:00
Matthew Chen 5627e67181 Merge branch 'charlesmchen/attachmentCleanup' 2018-09-14 14:41:48 -04:00
Matthew Chen 22afe39cd0 Respond to CR. 2018-09-14 14:34:50 -04:00
Matthew Chen 2ea751bbac Clean up attachment downloads. 2018-09-14 14:34:50 -04:00
Matthew Chen 32f1ce9473 Clean up attachment downloads. 2018-09-14 14:34:50 -04:00
Matthew Chen 6a2e00928c Merge branch 'charlesmchen/loggingAndAsserts' 2018-09-14 14:33:54 -04:00
Matthew Chen 8ef3497e58 Update cocoapods. 2018-09-14 14:33:17 -04:00