Commit graph

26 commits

Author SHA1 Message Date
Matthew Chen
644e78f19d Respond to CR. 2018-04-13 14:32:42 -04:00
Michael Kirk
1d95cd6977 Improve video scrubbing UX in PageView
// FREEBIE
2018-03-27 10:16:18 -04:00
Michael Kirk
6c877403cf Fix delete from message details
// FREEBIE
2018-03-22 19:54:19 -04:00
Michael Kirk
6e20f5b654 Fix Delete
from conversation settings > tile > tap for details > delete

TODO:

- Don't dismiss pager, show next item
- dismiss pager if deleting last media

// FREEBIE
2018-03-22 19:52:52 -04:00
Michael Kirk
428802aee8 Only try to stop video when it *is* a video
// FREEBIE
2018-03-19 20:30:19 -04:00
Michael Kirk
24eb4bf443 Stop any video whenever leaving PageView
// FREEBIE
2018-03-19 20:15:47 -04:00
Michael Kirk
4c2d30a776 Memory warning clears MediaPageView cache
Doing so required MediaDetailView to retain GalleryItem, but because
GalleryItem is a swift struct, I had to envoke the Box dance.

// FREEBIE
2018-03-19 18:57:10 -04:00
Michael Kirk
4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
2018-03-16 15:55:34 -04:00
Michael Kirk
88e1386720 Move frame to presentation logic, out of init
This no longer made sense now that we're using this in a
PageViewController we won't always be zooming from a particular frame.

TODO:

- why is background image all wonky?
- why aren't views created by the time it's presented? Is that a
regression? (how is self.view a MenuView if loadView hasn't been called)

// FREEBIE
2018-03-14 12:50:27 -04:00
Matthew Chen
59c745756a Clean up codebase. 2018-03-02 15:05:14 -05:00
Matthew Chen
99aedca45f Strip out special casing for pre-iOS 9 users. 2018-02-26 14:13:38 -05:00
Michael Kirk
c6e5d4369b Don't adjust inset when fully zoomed in.
On iOS11, when looking at the full-screen media details, if you'd zoomed
far enough that the media content is behind the status bar, tapping to
hide the status bar would cause an undesirable change in content offset.

// FREEBIE
2018-02-14 09:05:05 -08:00
Michael Kirk
c646f76335 Garther audio concerns, clean up session when done
- sync speakerphone state manipulated from system call screen
  - Revert audio session after call failure, ensures media plays out of
    speaker after placing a failing call.
  - Replace notification with delegate pattern since we're already using
    delegate pattern here.
- Fixes voiceover accessibility after voice memo
- Avoid audio blip after pressing hangup
- Rename CallAudioSession -> OWSAudioSession
  Going to start using it for other non-call things since we want to
  gather all our audio session concerns.
- Resume background audio when done playing video
  - Extract OWSVideoPlayer which ensures audio is in proper state before
    playback
  - Move recording session logic to shared OWSAudioSession
  - Deactivate audio session when complete

// FREEBIE
2018-02-06 18:45:51 -08:00
Michael Kirk
e39ca59eeb Merge tag '2.19.5.0' 2018-02-01 14:03:43 -08:00
Michael Kirk
3a5fa63cd6 Fix confirmation preview
// FREEBIE
2018-01-19 15:34:11 -05:00
Michael Kirk
94d58b88b8 Play video inline in approval view
Previously we launched the MPMoviePlayerController

// FREEBIE
2018-01-16 17:57:14 -05:00
Michael Kirk
0c6a42003f clang-format after RI
// FREEBIE
2018-01-16 15:27:53 -05:00
Michael Kirk
a423fe8a0e WIP Merge tag '2.19.4.4'
- restore video playback in fullscreen

This was a large merge, so I'm opting to make some changes in separate
commits.
2018-01-16 15:25:58 -05:00
Michael Kirk
63c23b77d0 Cleanup presentation view, feels less blurry
// FREEBIE
2018-01-12 00:17:06 -05:00
Michael Kirk
1ef824029e Fix distorted images
// FREEBIE
2018-01-11 23:58:11 -05:00
Michael Kirk
3582ab42db Fix media detail presentation
- video view now scales during presentation
- no "swooping" when presenting large res images

// FREEBIE
2018-01-11 23:49:21 -05:00
Michael Kirk
7c2bfdfb1f rename: imageView -> mediaView
// FREEBIE
2018-01-11 23:05:59 -05:00
Michael Kirk
8851413b35 CR: cleanup, remove debug animation time, move constant
// FREEBIE
2018-01-11 23:05:59 -05:00
Michael Kirk
e140ffc423 Fullscreen presentation touchups
"zoom" presentation now accounts for zoomScale.

Fix background flicker as status bar hides
Round corners during presentation/dismiss. Smooths transition a bit.

// FREEBIE
2018-01-11 23:05:59 -05:00
Michael Kirk
c91658119d CR: double tap zoom centers on tap location
// FREEBIE
2018-01-08 15:50:18 -05:00
Michael Kirk
412fe2735e Rename FullImageViewController -> MediaDetailViewController
// FREEBIE
2018-01-08 01:10:32 -05:00
Renamed from Signal/src/ViewControllers/FullImageViewController.m (Browse further)