Commit graph

4430 commits

Author SHA1 Message Date
Matthew Chen 6bc8f6d3a3 More perf tweaks for conversation view. 2018-12-13 13:32:00 -05:00
Matthew Chen 2bf0c55ab0 More perf tweaks for conversation view. 2018-12-13 13:32:00 -05:00
Matthew Chen ca129bf360 Preheat more UI DB views. 2018-12-13 12:28:18 -05:00
Matthew Chen be8a61b559 Refine contact offers logic. 2018-12-13 11:50:55 -05:00
Matthew Chen 19a2bfeaad More conversation viewmodel perf improvements. 2018-12-13 11:50:55 -05:00
Matthew Chen 5f637f24e9 Preheat UI DB views. 2018-12-13 11:48:24 -05:00
Matthew Chen b0295b736b Add ReverseDispatchQueue. 2018-12-13 11:44:29 -05:00
Matthew Chen 85f6d05e0f Refine view model diffing. 2018-12-13 09:21:13 -05:00
Matthew Chen 90d8fb3d14 Refine view model diffing. 2018-12-13 09:21:13 -05:00
Matthew Chen 9db50bd9e0 Reduce priority of media loads. 2018-12-13 09:16:39 -05:00
Matthew Chen 21ab3fbbcb Respond to CR. 2018-12-13 09:16:39 -05:00
Matthew Chen 962c1acc9f Fix "blinking" regression media views. 2018-12-13 09:16:39 -05:00
Matthew Chen 047afe21ae Fix typo. 2018-12-13 09:16:39 -05:00
Matthew Chen b9404938c4 Respond to CR. 2018-12-13 09:16:39 -05:00
Matthew Chen 358d97bf5b Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen ddd6732f74 Revert "Always load conversation media async."
This reverts commit 297aa080163cb6eb324b40bae790768ff2fb1721.
2018-12-13 09:16:39 -05:00
Matthew Chen 5cb319a9c8 Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen 956859244d Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen c1578b4b06 Always load conversation media async. 2018-12-13 09:16:39 -05:00
Matthew Chen fea40d571c Move contact offers to Conversation view model. 2018-12-13 09:12:41 -05:00
Matthew Chen 15826cec5d Reduce initial conversation load window size. 2018-12-13 09:09:07 -05:00
Matthew Chen 9017c16e7e Sort interactions in CVM. 2018-12-13 09:07:49 -05:00
Matthew Chen 95bc7a23f7 Use dedicated db connection in orphan data cleaner. 2018-12-12 14:14:09 -05:00
Michael Kirk beb02afce9 Soft delete group threads 2018-12-12 08:46:15 -07:00
Matthew Chen af3cff3399 Prep orphan data cleaner. 2018-12-11 16:35:28 -05:00
Matthew Chen 8ba747916a Prep orphan data cleaner. 2018-12-11 16:35:28 -05:00
Michael Kirk b7ab036c04 warn_unused_result on AnyPromise methods 2018-12-11 09:37:44 -07:00
Matthew Chen acd97602ca Respond to CR. 2018-12-11 10:46:01 -05:00
Matthew Chen 48bd0cfa06 Add missing retains to promises. 2018-12-11 10:43:47 -05:00
Matthew Chen 15653498b7 Apply backup feature flag. 2018-12-11 10:05:18 -05:00
Michael Kirk ff45070219 Optimize album ordering - remove unnecessary albums 2018-12-10 13:13:28 -07:00
Michael Kirk 1ab0daeb9b just a bit faster 2018-12-10 12:00:54 -07:00
Michael Kirk ed12a74ccf album picker design tweaks 2018-12-10 11:59:44 -07:00
Michael Kirk 3e032f55cd clear selectedIds in sync with deselection 2018-12-10 10:25:41 -07:00
Michael Kirk d85350bf8f remain in "multiselect" mode after switching PhotoCollection 2018-12-10 10:12:32 -07:00
Michael Kirk e776a2410c update comment per code review 2018-12-10 10:07:01 -07:00
Michael Kirk 6556a3173c Don't extend PhotoCollection picker beneath navbar 2018-12-10 10:06:10 -07:00
Michael Kirk 2eb2c2856b fix conversation input appearing over image picker 2018-12-10 10:06:10 -07:00
Michael Kirk 6a61d660b4 Don't show "selected" badge unless in batch mode (per myles) 2018-12-10 10:06:10 -07:00
Michael Kirk ac7e2f76d6 Properly handle external library changes, avoid overzealous deselect 2018-12-10 10:06:10 -07:00
Michael Kirk 82d49350ef properly deselect items when switching collections 2018-12-10 10:06:10 -07:00
Michael Kirk 635401dc5e Hide "Select" button while album chooser presented
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[x] animate title label
-[x] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
2018-12-10 10:06:10 -07:00
Michael Kirk 5490f07bb9 Animate title chevron
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[x] animate title label
-[] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
2018-12-10 10:06:10 -07:00
Michael Kirk caf0020697 Present CollectionPicker as child view
TODO:

-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[x] present/dismiss animation
-[] animate title label
-[] hide (some?) bar button items when collection picker presented

Nice to have:

-[] crop child view top - so that it comes *up to* the navbar bottom, but
    doesn't go behind
2018-12-10 10:06:10 -07:00
Michael Kirk 083d587ef0 WIP: Present CollectionPicker as child view
-[x] establish parent/child relation
-[x] reconcile changes with collection picker delegate
-[] present/dismiss animation
-[] animate title label
-[] hide (some?) bar button items when collection picker presented
2018-12-10 10:06:10 -07:00
Michael Kirk 0e1a65446f WIP: Present CollectionPicker as child view
-[x] establish parent/child relation
-[] reconcile changes with collection picker delegate
-[] present/dismiss animation
-[] animate title label
2018-12-10 10:06:10 -07:00
Michael Kirk 78e963404a remove overzealous assert, since we now sometimes post notification without threadId 2018-12-10 10:04:40 -07:00
Michael Kirk 52e21be656 fix draft scrolling 2018-12-10 10:03:01 -07:00
Matthew Chen 00c6ed2f3c Tweak scroll down animation behavior in conversation view. 2018-12-10 09:24:18 -05:00
Matthew Chen 734cc22cb3 Fix thread safety around CloudKit notifications. 2018-12-10 09:22:45 -05:00