Commit graph

334 commits

Author SHA1 Message Date
Matthew Chen
3964b78ff7 Reduce usage of JSQ. 2018-06-01 17:44:18 -04:00
Matthew Chen
833f6ad51d Skip missing and invalid interactions in conversation view. 2018-06-01 17:42:12 -04:00
Matthew Chen
2c0ba1cbd9 Skip missing and invalid interactions in conversation view. 2018-06-01 17:42:12 -04:00
Matthew Chen
6bc145ce3a Fix more build warnings. 2018-06-01 17:37:06 -04:00
Michael Kirk
9aafd89979 Remove unused synthesized ivars
// FREEBIE
2018-06-01 13:19:45 -04:00
Michael Kirk
ae1d82be84 Fix: input toolbar disappears when tapping media while edit menu is
present

// FREEBIE
2018-06-01 13:16:43 -04:00
Michael Kirk
e6c659d0ff remove incorrect comment 2018-06-01 13:16:43 -04:00
Michael Kirk
6e6a7446d0 Use global readWrite connection
// FREEBIE
2018-06-01 13:16:43 -04:00
Michael Kirk
468f7524ef Revert "separate read/write db connections"
This reverts commit 3e61741060e6a7c2a9891b46cf3abd567d33aa3a.
2018-06-01 13:16:43 -04:00
Michael Kirk
00f8ea4ff8 Use a single ui connection to share cache.
Primarly two things:
1. using an extension for the first time per connection is slow
2. fetching the same objects (e.g. if you leave/re-enter the same
conversation)

// FREEBIE
2018-06-01 13:16:43 -04:00
Michael Kirk
ddd39fcd3d separate read/write db connections
// FREEBIE
2018-06-01 13:16:42 -04:00
Michael Kirk
d9172cccb9 Measure time to display
// FREEBIE
2018-06-01 13:16:42 -04:00
Matthew Chen
879b9d4c72 Respond to CR. 2018-06-01 12:39:13 -04:00
Matthew Chen
9a08afae28 Fix build warnings. 2018-06-01 12:39:13 -04:00
Matthew Chen
3cd6a33aa6 Fix build warnings. 2018-06-01 12:39:13 -04:00
Matthew Chen
5ed22ada7b Respond to CR. 2018-06-01 12:01:20 -04:00
Matthew Chen
e4f7995e4d Ensure conversation view is first responder before presenting another view. 2018-06-01 11:59:26 -04:00
Matthew Chen
9ee572fb24 Respond to CR. 2018-05-31 16:36:16 -04:00
Matthew Chen
fefc9843b1 Modify views to observe changes when active, not just foreground. 2018-05-31 16:31:51 -04:00
Matthew Chen
812210a63c Modify views to observe changes when active, not just foreground. 2018-05-31 16:31:51 -04:00
Michael Kirk
97324eaae1 Load less messages initially
// FREEBIE
2018-05-31 16:20:15 -04:00
Matthew Chen
4f520646cc Avoid double layout in conversation view; but carefully. 2018-05-30 17:46:24 -04:00
Michael Kirk
273063e0aa ConversationView first load avoids redundant layout
We are laying out the collection view, invalidating the layout, and then
laying out the collection view again on first appearance of the
conversation view. This is quite expensive - removing it shaves off
about 30% of load time.

// FREEBIE
2018-05-30 17:46:24 -04:00
Matthew Chen
5f593bd736 Revert "Add temporary verbose logging around message creation."
This reverts commit f26ad5cd34.
2018-05-29 14:01:11 -04:00
Matthew Chen
0aa8306036 Revert "Add temporary verbose logging around message creation."
This reverts commit 5b0d806a6d.
2018-05-29 14:01:04 -04:00
Matthew Chen
5b0d806a6d Add temporary verbose logging around message creation. 2018-05-29 13:42:49 -04:00
Matthew Chen
f26ad5cd34 Add temporary verbose logging around message creation. 2018-05-29 11:49:42 -04:00
Michael Kirk
2709a91b5e Fixup attachment approval vis-a-vis call banner
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
1b60716759 Stop worrying about notification order by using delegate pattern
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
33eb4c38cd Centralize translucency configuration
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
a2b1793262 initial render is wrong, but settles somewhere nice
-[x] fix initial placement
-[x] add additional top safe area?

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk
3a9391f4fb notes on what didn't work 2018-05-24 12:28:20 -04:00
Michael Kirk
4dbd14ac41 WIP navbar resize
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[x] disable conversation view call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
2018-05-24 12:28:20 -04:00
Matthew Chen
e2d9c1187a Fix "group avatar doesn't update after local change." 2018-05-18 15:37:38 -04:00
Matthew Chen
692d0a7579 Don't mark messages as read if conversation view isn't 100% visible. 2018-05-17 16:07:23 -04:00
Matthew Chen
78de7a10f7 Don't mark messages as read if conversation view isn't 100% visible. 2018-05-17 16:07:23 -04:00
Matthew Chen
f436fc19c2 Make contact share "bubble/card" reflect share contents. 2018-05-16 17:19:05 -04:00
Matthew Chen
f6106512db Only mark messages read in conversation view if visible. 2018-05-16 16:30:01 -04:00
Michael Kirk
30cef1f084 start readtimer whenever we become active
// FREEBIE
2018-05-15 12:56:47 -04:00
Michael Kirk
117d7319d2 Add contact modally and restore navbar style when dismssing contacts
// FREEBIE
2018-05-14 18:40:56 -04:00
Michael Kirk
2cc3eabdb8 quote reply to contact share (no avatar)
// FREEBIE
2018-05-10 14:34:19 -04:00
Matthew Chen
acdc51ba3d Respond to CR. 2018-05-10 13:17:34 -04:00
Matthew Chen
37b8b368a6 Show "share contact" flow in single presented navigation controller. 2018-05-10 13:17:01 -04:00
Michael Kirk
c15fea4eca merge avatar with existing
// FREEBIE
2018-05-10 11:31:22 -04:00
Michael Kirk
0c469764f1 re-use contact picker for "add to existing"
Required refactor of contact picker to be presented non-modally.

TODO: merge emails, address, display names

// FREEBIE
2018-05-10 11:31:22 -04:00
Michael Kirk
609746abec clarify naming
// FREEBIE
2018-05-10 11:31:22 -04:00
Matthew Chen
4079cdb600 Apply more contact share assets. 2018-05-09 17:51:27 -04:00
Michael Kirk
42109593af Remove fromViewController state from ContactShareViewHelper
// FREEBIE
2018-05-09 10:21:00 -04:00
Michael Kirk
77bbbad70c Remove contactShare state from ContactShareViewHelper
// FREEBIE
2018-05-09 10:21:00 -04:00