Commit Graph

36 Commits

Author SHA1 Message Date
Michael Kirk 47a7114317 Gallery pager style changes 2018-11-15 10:16:51 -06:00
Michael Kirk 4c5d46e8f8 Custom photo picker, respects theme/call banner
- share GridViewCell
- Multiple image selection, with feature flag, cant currently approve multiple
2018-11-05 22:23:40 -06:00
Michael Kirk 432fcc016c Gallery tile landscape 2018-11-01 08:43:59 -06:00
Matthew Chen f9eab5cd24 Merge remote-tracking branch 'origin/release/2.29.2' 2018-09-07 15:27:50 -04:00
Matthew Chen 3437361d70 Use new thumbnails in media gallery thumbnails. 2018-09-06 15:30:00 -04:00
Matthew Chen 5b50e81b4f Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
Matthew Chen 7be8f30877 Apply -> Never. 2018-08-27 10:21:03 -04:00
Matthew Chen cf6f3841a8 Apply new Swift logging. 2018-08-27 10:02:28 -04:00
Michael Kirk 32f8795342 media tile toolbar respects theme by using UIAppearance defaults 2018-08-21 12:53:35 -06:00
Michael Kirk 8cd290ba2b fix section headers not appearing on iOS11/iPhoneX
// FREEBIE
2018-08-20 12:23:00 -06:00
Michael Kirk 92de745528 theme gallery section headers
// FREEBIE
2018-08-20 12:23:00 -06:00
Matthew Chen d34f83b445 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen 3964b78ff7 Reduce usage of JSQ. 2018-06-01 17:44:18 -04:00
Michael Kirk e4530a51bf Handle "current page view" deleted from tile
// FREEBIE
2018-03-26 18:07:43 -04:00
Michael Kirk 457d6c6d95 Don't scroll to bottom on load, since we scroll to focused when view
appears.

// FREEBIE
2018-03-26 18:07:42 -04:00
Michael Kirk 405edaa125 End select mode after hitting delete
// FREEBIE
2018-03-26 17:14:42 -04:00
Michael Kirk ae892525dd don't fade "selected" badge
// FREEBIE
2018-03-23 16:06:39 -04:00
Michael Kirk 2edf8384cd iPhoneX layout for gallery
// FREEBIE
2018-03-23 15:59:56 -04:00
Michael Kirk 3058cb8733 Batch Delete
// FREEBIE
2018-03-23 15:27:06 -04:00
Michael Kirk 6c877403cf Fix delete from message details
// FREEBIE
2018-03-22 19:54:19 -04:00
Michael Kirk 6e20f5b654 Fix Delete
from conversation settings > tile > tap for details > delete

TODO:

- Don't dismiss pager, show next item
- dismiss pager if deleting last media

// FREEBIE
2018-03-22 19:52:52 -04:00
Michael Kirk b5503cc00a Handle empty media gallery
// FREEBIE
2018-03-20 18:35:42 -04:00
Michael Kirk 6939b1749b remove gradient per myles
// FREEBIE
2018-03-20 18:18:36 -04:00
Michael Kirk 7754d3d94f Real assets
// FREEBIE
2018-03-20 17:27:07 -04:00
Michael Kirk 021c0db559 WIP: waiting on assets
// FREEBIE
2018-03-20 17:07:29 -04:00
Michael Kirk d9a2effff6 CR: remove "k" from non constant
// FREEBIE
2018-03-20 11:15:09 -04:00
Michael Kirk 10ee054d0c Avoid flicker when loading more on top
Adjusting content offset in the CollectionViewLayout.prepareLayout
method avoids a flicker vs. the previous way we were doing it.

// FREEBIE
2018-03-19 19:52:59 -04:00
Michael Kirk 19988a872a Improve scroll-jank on Gallery Tile View
- Don't fetch data unnecessarily
- Use CATransaction to avoid insertion animations. They are off screen
  anyway.

// FREEBIE
2018-03-19 19:42:03 -04:00
Michael Kirk 13d6d72a6f per myles, use lighter blur
// FREEBIE
2018-03-19 15:43:36 -04:00
Michael Kirk f4e68e0dfb l10n
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk fb4182c41f Ensure gallery is GC'd
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk a0bd2c2324 OrphanDataCleaner shouldn't delete active thumbnails
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk ae8dbeb8dd Access Media Gallery from conversation settings
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk 4aeff7ba67 Thumbnail generation
// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk dfd628250d Gallery performance
- [x] share uiDatabaseConnection to share cache
- [x] increase cache size
- [x] load less initially
- [x] lazy loading
  - [x] slider view
  - [x] tile view

// FREEBIE
2018-03-19 14:22:03 -04:00
Michael Kirk 985af76d0b WIP: All Media view
TODO

- [ ] label video/gif
- [ ] reasonable load perf
- [ ] reasonable scroll perf
- [ ] select / delete
- [ ] cancel share action from media details returns signal style

NICE TO HAVE

- [ ] fancy in/out animation from All Media <-> tiles
- [ ] label video thumbnail with duration stamp
- [ ] Other perf?
- [ ] dbModified?
- [ ] select / send
- [ ] darken section header a shade once it's "active"

DONE

- [x] tap to refocus on new media
- [x] generate test data
- [x] section headers
- [x] equal spacing around cells

// FREEBIE

WIP WIP extract datasouce to GalleryViewController

- [x] swipe through is broken
- [x] present animation
- [x] dismiss animation

// FREEBIE
2018-03-19 14:22:03 -04:00