Commit graph

455 commits

Author SHA1 Message Date
Michael Kirk
9d1e3dc223 We need to change file extensions when converting data
// FREEBIE
2017-11-29 12:43:05 -08:00
Michael Kirk
1a99b34913 Fix iOS8 crash on type
// FREEBIE
2017-11-29 10:15:57 -08:00
Michael Kirk
a542471bbe center "Loading More Messages" label
// FREEBIE
2017-11-22 13:32:20 -05:00
Matthew Chen
f9f0f1c27d Revert "Force conversation view cells to update layout immediately."
This reverts commit ef820a3719.
2017-11-22 13:12:15 -05:00
Matthew Chen
35bdc86ab5 Reload adjacent rows using original indices, not final indices. 2017-11-22 13:06:54 -05:00
Matthew Chen
71f5ef5940 Improve handling of unread indicator edge cases. 2017-11-22 10:39:38 -05:00
Matthew Chen
2ec1e7e925 Respond to CR. 2017-11-22 09:39:43 -05:00
Matthew Chen
2d241623b7 Improve handling of edge cases around unread indicator delimiting deleted message(s). 2017-11-21 18:17:19 -05:00
Matthew Chen
5ef9d53c91 Update conversation view UI to reflect unread state. 2017-11-21 17:53:52 -05:00
Matthew Chen
ef820a3719 Force conversation view cells to update layout immediately.
// FREEBIE
2017-11-21 17:52:14 -05:00
Michael Kirk
370364c936 Scroll down button scrolls to unread
// FREEBIE
2017-11-21 11:42:33 -05:00
Matthew Chen
b0c9add29c Update layout of "scroll down button" to reflect RTL. 2017-11-21 11:27:01 -05:00
Matthew Chen
92ef507810 Make swipe-for-details RTL-safe. 2017-11-21 11:17:05 -05:00
Matthew Chen
aea2bf3e00 Fix scroll state insets in conversation view. 2017-11-20 17:17:10 -05:00
Matthew Chen
5cfa7e35f4 Respond to CR. 2017-11-20 17:08:10 -05:00
Michael Kirk
34811a635b Fixes: "connected call" showing as "unconnected outgoing" call.
Expire viewItem cache when resetting mappings

// FREEBIE
2017-11-20 17:04:54 -05:00
Matthew Chen
b76d9a4e68 Remove redundant logTag methods. 2017-11-20 16:51:58 -05:00
Matthew Chen
a4879f6bb5 Remove redundant logTag methods. 2017-11-20 16:51:58 -05:00
Matthew Chen
8eb4e682d9 Revert "Show menu controller from centroid of message cells."
This reverts commit 08bb1c909d.
2017-11-20 15:21:48 -05:00
Matthew Chen
cebeea9189 Reduce extremes of Jumbomoji behavior. 2017-11-20 15:02:45 -05:00
Matthew Chen
d8ae5841d6 Respond to CR.
// FREEBIE
2017-11-20 14:50:43 -05:00
Matthew Chen
45c7d80d97 Improving handling of edge cases in conversation view. 2017-11-20 14:44:10 -05:00
Matthew Chen
6d4a05bbea Improving handling of edge cases in conversation view. 2017-11-20 14:44:10 -05:00
Matthew Chen
658746093d Use finalIndex in row changes. 2017-11-20 14:44:10 -05:00
Michael Kirk
8ee030bea1 Don't dismiss keyboard when view appears
// FREEBIE
2017-11-20 14:30:55 -05:00
Matthew Chen
7b1a846f79 Dismiss keyboard when leaving conversation view. 2017-11-20 13:12:57 -05:00
Matthew Chen
572de11763 Apply dynamic type sizing to Jumbomoji. 2017-11-16 18:25:59 -05:00
Matthew Chen
937ac5830d Skip animations in conversation view. 2017-11-16 17:59:32 -05:00
Matthew Chen
b67179b45d Skip animations in conversation view. 2017-11-16 17:53:05 -05:00
Matthew Chen
0ccddb696a Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
2017-11-16 17:32:39 -05:00
Matthew Chen
96274a60a9 Respond to CR.
// FREEBIE
2017-11-16 17:30:19 -05:00
Matthew Chen
7aae47b021 Reduce font size of "load more" indicator. 2017-11-16 17:30:19 -05:00
Matthew Chen
dffd776ace Increase the max text message length. 2017-11-16 17:29:26 -05:00
Michael Kirk
228e350e2a message details shows failed bubble when appropriate
// FREEBIE
2017-11-16 17:05:31 -05:00
Matthew Chen
6b8f4c7dde Dismiss menu controller if message cell is hidden or recycled. 2017-11-16 16:35:53 -05:00
Matthew Chen
08bb1c909d Show menu controller from centroid of message cells. 2017-11-16 15:38:11 -05:00
Matthew Chen
aad93d2d89 Fix broken assert in conversation view item. 2017-11-16 13:23:47 -05:00
Matthew Chen
ddf4bf28cc Load attachments for conversation view items using long-lived db connection. 2017-11-16 13:16:18 -05:00
Matthew Chen
df5aa5ef67 Update UI to reflect changes to disappearing messages configuration. 2017-11-16 12:25:43 -05:00
Michael Kirk
9675cbb1e1 Scroll only as far as necessary
// FREEBIE
2017-11-15 17:30:45 -05:00
Matthew Chen
cc90f4cb80 Respond to CR.
// FREEBIE
2017-11-15 15:46:27 -05:00
Matthew Chen
86fdd6dea2 Fix edge cases in conversation view. 2017-11-15 15:43:03 -05:00
Matthew Chen
6413bc8e4c Evacuate the view item cache. 2017-11-15 13:36:56 -05:00
Matthew Chen
19ba564f80 Respond to CR.
// FREEBIE
2017-11-15 13:21:31 -05:00
Matthew Chen
c6160a5a1e Rework the "update with..." methods to avoid re-saving deleted models. 2017-11-15 07:16:12 -05:00
Michael Kirk
8c69e00a3f Adapt ConversationViewController to iPhoneX
// FREEBIE
2017-11-14 12:37:09 -05:00
Matthew Chen
c3b6c9055e Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links. 2017-11-13 18:46:41 -05:00
Matthew Chen
3da1d8c63f Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links. 2017-11-13 11:18:38 -05:00
Matthew Chen
c91dda43e0 Disable partial text selection; ignore taps outside links; ignore taps on non-sent messages, link-icy all links. 2017-11-13 11:15:58 -05:00
Matthew Chen
c3087cf3df Don't dismiss keyboard when tapping in the conversation view. 2017-11-13 10:41:41 -05:00
Matthew Chen
bf0f33e4b0 Temporarily alter animations in conversation view. 2017-11-10 14:51:34 -05:00
Matthew Chen
af6a7c103c Add a comment. 2017-11-10 14:08:52 -05:00
Matthew Chen
42a70e0def Revert "Temporarily make logging around conversation view row updates more verbose."
This reverts commit 105b033761.
2017-11-10 14:04:56 -05:00
Matthew Chen
f0a8e08df9 Temporarily alter animations in conversation view. 2017-11-10 13:17:38 -05:00
Matthew Chen
0abdbffe1f Improve handling of attachment edge cases. 2017-11-10 13:12:43 -05:00
Matthew Chen
b5f7a4746f Temporarily alter animations in conversation view. 2017-11-10 12:41:11 -05:00
Matthew Chen
3814464595 Increase content insets of attachment button. 2017-11-10 11:47:56 -05:00
Matthew Chen
105b033761 Temporarily make logging around conversation view row updates more verbose. 2017-11-10 11:37:16 -05:00
Matthew Chen
c72f39e64b Layout cell content when presenting the cell. 2017-11-10 09:48:52 -05:00
Matthew Chen
87b0692af0 Fixes for scrolling in conversation view. 2017-11-10 09:41:27 -05:00
Matthew Chen
5cc292fb6c Don't ask for camera permissions if app is not active.
// FREEBIE
2017-11-09 03:02:05 -05:00
Matthew Chen
5e61307ce3 Don't ask for microphone permissions if app is not active.
// FREEBIE
2017-11-09 02:58:51 -05:00
Matthew Chen
6e840ff956 Fix build warnings from XCode 9. 2017-11-09 02:52:44 -05:00
Matthew Chen
2d21e2ae2c Fix build warnings from XCode 9. 2017-11-09 02:52:44 -05:00
Michael Kirk
90dad75446 CR: remove unnecessary property
// FREEBIE
2017-11-08 10:50:25 -05:00
Michael Kirk
1f5603760b Fix contact offer
We never assign interaction, but we can get it via the viewItem.

// FREEBIE
2017-11-08 10:46:46 -05:00
Matthew Chen
e3f7947da0 Emphasize borders of input toolbar.
// FREEBIE
2017-11-06 12:54:09 -05:00
Matthew Chen
a5c4140a12 Reduce max text message bubble size.
// FREEBIE
2017-11-03 15:48:08 -04:00
Matthew Chen
ea0b6065e3 Revert "Constrain the max text cell height to the height of the screen."
This reverts commit b9583a3c85a3b27f65b653a1d851c7c966fdc83d.

// FREEBIE
2017-11-03 15:48:08 -04:00
Matthew Chen
608cd2781f Constrain the max text cell height to the height of the screen.
// FREEBIE
2017-11-03 15:48:08 -04:00
Matthew Chen
7fd5b00d86 Fix text message links in conversation view.
// FREEBIE
2017-11-02 14:50:32 -04:00
Matthew Chen
af5489952c Don't animate message sends.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen
40e04ffb92 Respond to CR.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen
5df4ac92b7 Don't animate message sends.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen
5d4316755f Respond to CR.
// FREEBIE
2017-11-01 12:48:07 -04:00
Matthew Chen
d52b19a69e Let users with external keyboards send messages using modifier-return (shift, command, option).
// FREEBIE
2017-11-01 12:46:55 -04:00
Matthew Chen
0c92850d38 Log voice memo durations.
// FREEBIE
2017-11-01 12:45:22 -04:00
Matthew Chen
89dbcb0fe8 Respond to CR.
// FREEBIE
2017-11-01 12:36:37 -04:00
Matthew Chen
f95e599c55 Don't overwrite draft after GIF send.
// FREEBIE
2017-11-01 12:36:36 -04:00
Matthew Chen
a0ddb2a06d Respond to CR.
// FREEBIE
2017-10-31 15:01:29 -04:00
Matthew Chen
9053d038ac Remove extra logging.
// FREEBIE
2017-10-31 14:33:30 -04:00
Matthew Chen
5ac2f16ebc Skip redundant relayout.
// FREEBIE
2017-10-31 14:33:30 -04:00
Matthew Chen
841a2333e3 Respond to CR.
// FREEBIE
2017-10-30 12:11:42 -04:00
Matthew Chen
eb3ca43256 Jumbomoji.
// FREEBIE
2017-10-27 10:25:49 -04:00
Matthew Chen
bee70fa028 Respond to CR.
// FREEBIE
2017-10-27 00:19:58 -04:00
Matthew Chen
5e1c6c02a0 Add "failed message send" badges.
// FREEBIE
2017-10-27 00:17:46 -04:00
Matthew Chen
8cb3e5d35d Fix edge cases around oversize test messages.
// FREEBIE
2017-10-26 14:34:30 -04:00
Matthew Chen
9cc4521d07 Respond to CR.
// FREEBIE
2017-10-26 12:09:36 -04:00
Matthew Chen
bcf83a4c8e Rework handling of oversize text messages.
// FREEBIE
2017-10-26 11:56:03 -04:00
Michael Kirk
8f9311a6ac Show timer in navbar without reload
// FREEBIE
2017-10-25 14:40:05 -07:00
Michael Kirk
709010499f remove overzealous assert
// FREEBIE
2017-10-25 14:39:12 -07:00
Matthew Chen
7e585b72aa Fix tests broken by the JSQ rewrite.
// FREEBIE
2017-10-25 16:08:15 -04:00
Michael Kirk
2d7deff839 Make message bubbles a bit wider.
// FREEBIE
2017-10-25 11:43:12 -07:00
Michael Kirk
cd291e19ff We conceivably want to to initiate calls more than once without leaving
the conversation view. e.g. from Contacts.app

// FREEBIE
2017-10-25 11:37:04 -07:00
Michael Kirk
4000760cf7 Fix "back button count" flash. Only call once.
This affects returning from message info or when leaving conversation
settings.

// FREEBIE
2017-10-25 11:31:06 -07:00
Matthew Chen
df7d40ed4c Respond to CR.
// FREEBIE
2017-10-25 10:00:22 -04:00
Matthew Chen
a23b8b717b RTL fixes for JSQ rewrite.
// FREEBIE
2017-10-25 09:36:43 -04:00
Michael Kirk
43dd3abf6c clamp value per CR
// FREEBIE
2017-10-24 15:29:04 -07:00
Michael Kirk
59b125c3fb Add clarifying comment per CR
// FREEBIE
2017-10-24 15:29:04 -07:00
Michael Kirk
d87f000051 Interactive/Cancelable slide left for details
// FREEBIE
2017-10-24 15:29:03 -07:00
Matthew Chen
fb3bb852ca Tap image attachment preview to view full screen.
// FREEBIE
2017-10-24 17:12:26 -04:00
Matthew Chen
722fc4d7a7 Fix size of message previews.
// FREEBIE
2017-10-24 17:12:26 -04:00
Matthew Chen
0eafbd8fe4 Respond to CR.
// FREEBIE
2017-10-24 17:09:25 -04:00
Matthew Chen
188b733d57 Don't send with return key.
// FREEBIE
2017-10-24 17:08:10 -04:00
Matthew Chen
27af310235 Auto-dismiss keyboard if user scrolls away from bottom of the conversation.
// FREEBIE
2017-10-24 13:58:56 -04:00
Matthew Chen
3fa2f22beb Fixes for input toolbar.
// FREEBIE
2017-10-24 11:43:42 -04:00
Matthew Chen
c9e385920a Fix spacing around date headers.
// FREEBIE
2017-10-24 11:03:05 -04:00
Matthew Chen
429f833913 Center the progress bar within the bubble mask.
// FREEBIE
2017-10-24 10:01:04 -04:00
Matthew Chen
658c3c5599 Only show attachment upload UI for not-yet-uploaded attachments.
// FREEBIE
2017-10-24 09:55:58 -04:00
Matthew Chen
067b16903c Fix attachment uploads.
// FREEBIE
2017-10-24 09:54:08 -04:00
Matthew Chen
c1f35a0ea6 Respond to CR.
// FREEBIE
2017-10-24 09:42:29 -04:00
Matthew Chen
2fa3cf1bc6 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Matthew Chen
cbb0030b12 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Matthew Chen
d04f9111db Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Michael Kirk
1fee5d97e6 Merge branch 'release/2.18.0' 2017-10-23 16:02:11 -07:00
Matthew Chen
a1d8c7765d Respond to CR.
// FREEBIE
2017-10-23 17:35:35 -04:00
Matthew Chen
54c56f1c4b Fix layout of generic and audio messages.
// FREEBIE
2017-10-23 17:30:56 -04:00
Matthew Chen
a16197f193 Respond to CR.
// FREEBIE
2017-10-23 17:30:03 -04:00
Matthew Chen
b1b0ddbf2e Fix layout glitches in JSQ rewrite.
// FREEBIE
2017-10-23 17:25:34 -04:00
Michael Kirk
21df2dc047 Never hide "failed to send" footer
// FREEBIE
2017-10-23 08:40:26 -07:00
Michael Kirk
bd4b4f0041 Use proper color when messages fail to send.
// FREEBIE
2017-10-21 18:59:21 -07:00
Michael Kirk
f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons."
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
2017-10-20 16:37:07 -07:00
Michael Kirk
66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 2017-10-20 16:23:58 -07:00
Michael Kirk
2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 2017-10-20 16:23:10 -07:00
Michael Kirk
68e755ade9 Merge branch 'release/2.18.0' 2017-10-20 16:10:07 -07:00
Michael Kirk
0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
2017-10-20 12:35:21 -07:00
Matthew Chen
7fa7d5d526 Fix "mark as read."
// FREEBIE
2017-10-20 09:53:33 -04:00
Matthew Chen
b0aa84e420 Clean up conversation view.
// FREEBIE
2017-10-19 23:02:59 -04:00
Matthew Chen
d355b45bae Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen
c2608785e1 Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen
4dc6934fc7 End text editing if we leave conversation view.
// FREEBIE
2017-10-19 22:48:28 -04:00
Matthew Chen
bd5639baaf Linkify text messages.
// FREEBIE
2017-10-19 22:41:32 -04:00
Matthew Chen
bf80e6dd36 Fix broken message cell layout.
// FREEBIE
2017-10-19 22:40:52 -04:00
Matthew Chen
45ba79d296 Auto-load more message if user scrolls near the top of the conversation.
// FREEBIE
2017-10-19 22:39:42 -04:00
Matthew Chen
f28abbc2a1 Revert from numeric to default keyboard after message send.
// FREEBIE
2017-10-19 22:36:25 -04:00
Matthew Chen
4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 22:33:51 -04:00
Matthew Chen
fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 10:04:49 -07:00
Matthew Chen
f3102e2761 Fix presentation animation of new "attachment approval" state of input toolbar.
// FREEBIE
2017-10-18 12:50:16 -07:00
Matthew Chen
0fe76aaab8 Move "attachment approval" into input toolbar.
// FREEBIE
2017-10-18 12:50:16 -07:00
Matthew Chen
06eb794db6 Simplify and fix edge cases around long pressing on system message cells.
// FREEBIE
2017-10-18 12:31:23 -07:00
Matthew Chen
37841d9b67 Respond to CR.
// FREEBIE
2017-10-18 12:21:17 -07:00
Matthew Chen
4a94d039e8 Restore the input toolbar's placeholder text.
// FREEBIE
2017-10-18 12:18:15 -07:00
Matthew Chen
c47573334b Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
3b945a9da2 Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
88c874e4e6 Clean up ahead of PR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
257f8249bf Cull cached cell media outside a load window.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
65efa7f836 Lazy load, eagerly unload & cache cell media.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
e77292c2a9 Add contentWidth property to ConversationViewCell.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen
b269c72acb Respond to CR.
// FREEBIE
2017-10-18 09:43:24 -07:00
Matthew Chen
f36ecbdfa6 Button locations in input toolbar should reflect RTL.
// FREEBIE
2017-10-18 09:37:08 -07:00