Commit graph

9887 commits

Author SHA1 Message Date
Matthew Chen 5010b027b1 Sketch out the backup restore view. 2018-11-27 09:21:44 -05:00
Matthew Chen 5c0d98b83a Show 'restore backup' view after registration. 2018-11-27 09:21:44 -05:00
Michael Kirk b2d75eb1ae "Bump build to 2.33.0.0." 2018-11-26 14:59:23 -07:00
Michael Kirk d7f94b6d16 Merge branch 'mkirk/fix-resign-animation' 2018-11-26 14:58:57 -07:00
Michael Kirk 26ca47b511 Avoid CaptionTextView animation glitch while dismissing MessageTextView 2018-11-26 14:11:13 -07:00
Michael Kirk 78c74d87bc Merge tag '2.32.0.16' 2018-11-26 13:03:27 -07:00
Michael Kirk d9942aa5eb Merge branch 'mkirk/multisend-design' 2018-11-26 12:58:02 -07:00
Michael Kirk 9317ee9c99 design comment 2018-11-26 12:57:50 -07:00
Michael Kirk e3120a5b87 cleanup keyboard animation code 2018-11-26 12:52:05 -07:00
Michael Kirk 0562619ca9 smaller margins between rail images, avoid choppy change as the margin updates
are not being animated smoothly.
2018-11-26 12:43:28 -07:00
Michael Kirk 55807f9a4d iPhoneX compatible keyboard animations 2018-11-26 12:43:28 -07:00
Michael Kirk 279694e704 keyboard animation cleanup 2018-11-26 12:43:28 -07:00
Michael Kirk 0808458392 fix caption dismiss animation/placeholder for multiline message body 2018-11-26 12:43:28 -07:00
Michael Kirk 4f1f09f231 Use snapshot view to avoid momentary missing bottomToolbar while switching
firstResponder from CaptionView to AttachmentApprovalViewController.
2018-11-26 12:43:28 -07:00
Michael Kirk 3bfda7ea81 Smooth kbd dismiss: avoid bouncing CaptionView due to quick transition of firstResponder 2018-11-26 12:43:28 -07:00
Michael Kirk b108f284bd WIP: hide caption keyboard
It's tricky because we're hopping from one first responder to another.

Specifically, from the CaptionView.textView, which shows the keyboard, to
making the AttachmentApprovalViewController first responder, which shows the
BottomToolbar message text field, so in short order, we're getting multiple
notifications.

User hit's "Done" with caption

- Point A - CaptionView is positioned at the top of the keyboard
- Hide keyboard (frame change details must be calculated by y offset, since willChanage notification doesn't "shrink" the keyboard frame, it just offsets it to be non-visible.
- Point B - caption view is positioned at the bottom of the screen, input accessory view not visible
- Show Keyboard (not actually showing the *keyboard* here, but rather the VC's input accessory view)
- Point C - caption view is positioned atop the input accessory view

We want to animated smoothly from A->C, skipping B. But how do we do that robustly? We could track something like "last known input accessory view height" and never present the captionView below that. But I'm worried it won't be very robust since the input accessory view can change height, e.g. text view grows with text content or dynamic text changes.
2018-11-26 12:43:28 -07:00
Michael Kirk 838012d1ec Caption length limit and label 2018-11-26 12:43:28 -07:00
Michael Kirk e0f7513df0 white tint for attachment approval textview cursors 2018-11-26 12:43:28 -07:00
Michael Kirk a946ec0056 new icon assets per design 2018-11-26 12:43:28 -07:00
Michael Kirk 8776dd1909 New "add caption" and "done" assets 2018-11-26 12:43:28 -07:00
Michael Kirk feb5a0c444 fix initial CaptionView layout glitch 2018-11-26 12:43:28 -07:00
Michael Kirk e65eeff0fd Keyboard should cover _Caption_ TextView when _Message_ TextView becomes first responder. 2018-11-26 12:43:28 -07:00
Michael Kirk 33750baf67 finally got dismiss-before-swipe 2018-11-26 12:43:28 -07:00
Michael Kirk dd82803a10 second abandoned attempt to require dismiss before page 2018-11-26 12:43:28 -07:00
Michael Kirk b98b3d1fdd WIP: require dismiss before swipe 2018-11-26 12:43:28 -07:00
Michael Kirk 706dd3d0c1 initial layout of keyboard is correct across pages 2018-11-26 12:43:28 -07:00
Michael Kirk 280664c763 WIP: keyboard 2018-11-26 12:43:28 -07:00
Michael Kirk eed2558050 Avoid glitch in keyboard dismiss.
iOS adjusts the inputAccessoryView's host input views layout margins when
popping/dismissing the keyboard, which causes a noticeable glitch.
2018-11-26 12:43:28 -07:00
Michael Kirk 8b5d1d9e69 Only add delete button once 2018-11-26 12:43:28 -07:00
Michael Kirk 31637656fb Merge branch 'mkirk/separate-caption-and-body' 2018-11-26 12:38:12 -07:00
Michael Kirk 28f8fc5911 per cr, avoid unnecessary 2018-11-26 12:37:58 -07:00
Michael Kirk fcc4b516a5 fix typo in logging 2018-11-26 12:37:58 -07:00
Michael Kirk 4f0092615a Support captions *and* independent message body 2018-11-26 12:37:58 -07:00
Michael Kirk cd88ef2bec CaptionView text field per page 2018-11-26 12:37:58 -07:00
Michael Kirk 79995cc52c rename captioning -> messageText
TODO
-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Michael Kirk 47affb81c0 Move gallery rail into input accessory view
TODO

-[] caption field per photo, separate from album message
-[] caption field sticks to keyboard on becoming first responder
-[] swipe updates caption field (not album message)
-[] limit caption length to 240 chars
-[] add more asset

TODO picker
-[] Done becomes "next"
-[] shared navbar, album picker doesn't cover entire screen
-[] new selected checkmark asset
2018-11-26 12:37:58 -07:00
Matthew Chen f65708c36f Merge branch 'charlesmchen/registrationEdgeCases' 2018-11-26 10:00:42 -05:00
Matthew Chen fa8095bf2d Respond to CR. 2018-11-26 10:00:25 -05:00
Matthew Chen 544bdbd7f5 Fix edge cases around registration. 2018-11-26 09:58:59 -05:00
Michael Kirk dd6faa647d "Bump build to 2.32.0.16." 2018-11-25 18:04:38 -06:00
Michael Kirk 31782af2f1 dark theme section headers in tile gallery 2018-11-25 18:03:20 -06:00
Michael Kirk 6cdef57e2a Merge tag '2.32.0.15' 2018-11-25 12:54:59 -06:00
Michael Kirk 8ebe860ff1 pull latest translations 2018-11-25 11:11:04 -06:00
Michael Kirk 894ffa4845 "Bump build to 2.32.0.15." 2018-11-24 17:38:23 -06:00
Michael Kirk 7a3de0bebd Merge branch 'mkirk/fix-sync-processing' into release/2.32.0 2018-11-24 17:37:51 -06:00
Michael Kirk 4a70f8dc0f only process attachments if they exist 2018-11-24 17:35:15 -06:00
Michael Kirk 18766280f6 fix crash when non-registered user upgrades 2018-11-23 11:38:51 -06:00
Michael Kirk a5dec2321e "Bump build to 2.32.0.14." 2018-11-21 22:32:02 -06:00
Michael Kirk c29224e4ea sync translations 2018-11-21 22:31:48 -06:00
Michael Kirk 68a7a6da03 Merge branch 'mkirk/fix-tap-crash-on-iOS10' into release/2.32.0 2018-11-21 22:27:14 -06:00