Commit graph

1412 commits

Author SHA1 Message Date
Michael Kirk fa2d5b422b maintain body text navigating to/from approval view 2019-03-28 11:58:43 -06:00
Michael Kirk 1a4062dd89 Nav buttons: batch, camera/library switch, done 2019-03-28 10:30:47 -06:00
Michael Kirk 7dbb9517af Centralize attachment state in nav controller 2019-03-28 10:30:47 -06:00
Michael Kirk 6502d7d4a5 remove isMultiSendEnabled feature flag 2019-03-28 10:30:47 -06:00
Michael Kirk 1357449dcc Make OrderedDictionary keys generic 2019-03-28 10:30:47 -06:00
Matthew Chen db958f4a01 Preserve caption text of edited images. 2019-03-26 21:24:25 -06:00
Matthew Chen d9760b6bbc Fix bug around layer ordering when rendering image editor output. 2019-03-26 21:22:35 -06:00
Matthew Chen 5973c326de Ensure new text items are on the canvas. 2019-03-26 21:21:52 -06:00
Michael Kirk f8244eeefe Fix SAE crash for iOS9 2019-03-26 17:08:36 -06:00
Michael Kirk 58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 2019-03-26 11:21:30 -06:00
Matthew Chen 3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 2019-03-25 09:31:55 -04:00
Matthew Chen f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 2019-03-25 09:31:55 -04:00
Matthew Chen 4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 2019-03-25 09:31:19 -04:00
Matthew Chen 95e125d55e Simplify usage of accessibilityIdentifiers. 2019-03-25 09:31:19 -04:00
Matthew Chen 2d854406a1 Add accessibilityIdentifiers to home view. 2019-03-25 09:31:19 -04:00
Michael Kirk ed6b461662 search icon 2019-03-22 18:18:56 -07:00
Matthew Chen a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 2019-03-22 10:26:25 -04:00
Matthew Chen 558b5f5816 Tap to dismiss caption editor. 2019-03-21 15:21:36 -04:00
Matthew Chen 4ea608cd45 Ensure status bar is hidden in image editor subviews. 2019-03-21 15:21:36 -04:00
Michael Kirk e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 2019-03-21 12:04:37 -07:00
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
2019-03-21 10:37:54 -07:00
Matthew Chen 908fe1d0c9 Apply presentAlert() throughout codebase. 2019-03-21 10:58:49 -04:00
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 2019-03-21 10:55:04 -04:00
Matthew Chen c9d62f47cc Respond to CR. 2019-03-21 10:26:38 -04:00
Matthew Chen 1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:57 -04:00
Matthew Chen cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:25 -04:00
Matthew Chen f37a3059fa Add accessibility identifiers to debug log popups. 2019-03-21 10:08:25 -04:00
Matthew Chen 81508e9d02 Add accessibility identifiers to settings popups. 2019-03-21 10:08:25 -04:00
Matthew Chen d7b1e65a71 Add accessibility identifiers to blocklist popups. 2019-03-21 10:08:25 -04:00
Matthew Chen f1520d760e Add accessibility identifiers to other settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen b48e204b90 Add accessibility identifiers to notification settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen 931d249677 Modify OWSFlatButton to propagate the accessibility identifier to wrapper button. 2019-03-21 10:08:25 -04:00
Matthew Chen 41a3c95831 Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen 8bcc19e36c Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen 52d6aa69b8 Improve measurement of image editor text layers. 2019-03-19 09:42:38 -04:00
Michael Kirk 0b638f4831 link checks 2019-03-18 15:21:19 -07:00
Michael Kirk 78ce3583ed fix rotation issue 2019-03-18 15:17:13 -07:00
Matthew Chen 050a9676f6 Add accessibility identifiers to select recipient views. 2019-03-18 14:11:37 -04:00
Matthew Chen c3857e5dff Add accessibility identifiers to select recipient views. 2019-03-18 14:11:37 -04:00
Matthew Chen 79d6384bc9 Add accessibility identifiers to privacy settings view. 2019-03-18 14:11:37 -04:00
Matthew Chen c37f425d5f Reduce logging. 2019-03-15 16:27:08 -04:00
Matthew Chen 3795fd1381 Enable image editor in production. 2019-03-14 16:42:25 -04:00
Matthew Chen 441c784146 Add preview view to the color palette control. 2019-03-14 15:48:58 -04:00
Michael Kirk 284357137f Photo/Movie Capture 2019-03-14 12:20:21 -07:00
Matthew Chen 684cebf2df Respond to CR. 2019-03-14 13:29:40 -04:00
Matthew Chen a48c3d8d20 Ensure attachment approval becomes first responder if app returns from background. 2019-03-14 12:54:49 -04:00
Matthew Chen f9445359d9 Fix layout glitch related to attachment approval input accessory background. 2019-03-14 12:54:49 -04:00
Matthew Chen a559b61056 Fix keyboard return behavior in attachment approval. 2019-03-14 12:54:49 -04:00
Matthew Chen 660f35147f Hide status bar in image editor modals. 2019-03-14 12:54:49 -04:00
Matthew Chen 25e7818f56 Ensure proper z-ordering of item layers. 2019-03-14 12:54:49 -04:00
Matthew Chen d824c49c07 Respond to CR. 2019-03-14 12:53:54 -04:00
Matthew Chen d80f086f31 Rework attachment captioning. 2019-03-14 12:40:29 -04:00
Matthew Chen 625656deb9 Pull out attachment text toolbar and text view classes. 2019-03-14 12:40:29 -04:00
Matthew Chen 581d0a7bff Respond to CR. 2019-03-13 12:43:30 -04:00
Matthew Chen 4fd16a7614 Remove top gradient from attachment approval. 2019-03-13 12:25:02 -04:00
Matthew Chen 745ec2adb8 Remove top gradient from attachment approval. 2019-03-13 12:10:56 -04:00
Matthew Chen 0826864525 Decompose attachment approval into multiple source files. 2019-03-13 11:45:42 -04:00
Matthew Chen c315c1c9ef Fix translation normalization of the image editor transform. 2019-03-13 11:44:31 -04:00
Matthew Chen 88c07fc534 Pinch to change text size in image editor text tool. 2019-03-13 11:41:44 -04:00
Matthew Chen d6c91c2753 Respond to CR. 2019-03-13 11:40:43 -04:00
Matthew Chen fedbe3a5d0 Fix shadow on palette view. 2019-03-12 17:34:31 -04:00
Matthew Chen 75cfd979ba Modify brush stroke width to reflect current scale. 2019-03-12 17:34:31 -04:00
Matthew Chen c0ca55b1e0 Fix shadow on palette view. 2019-03-12 17:34:31 -04:00
Matthew Chen 337e32a909 Fix a shadow. 2019-03-12 17:34:31 -04:00
Matthew Chen 66efcb4639 Update rail icons. 2019-03-12 17:34:31 -04:00
Matthew Chen 2f7880af8e Fix hit testing of text layers. 2019-03-12 17:34:31 -04:00
Matthew Chen 7521b3a145 Update "attachment has caption" indicator. 2019-03-12 17:22:46 -04:00
Matthew Chen dd16986d79 Avoid layout changes due to selection changes in media rail. 2019-03-12 17:22:46 -04:00
Matthew Chen e63b1169a3 Hide controls while moving text items. 2019-03-12 17:22:46 -04:00
Matthew Chen 9e636b0fc9 Hide controls during stroke. 2019-03-12 17:22:46 -04:00
Matthew Chen c77835926d Tap to create new text item. 2019-03-12 17:22:46 -04:00
Matthew Chen fb6631df5f Remove cancel button from attachment caption view. 2019-03-12 17:22:46 -04:00
Matthew Chen 5aaa667927 Modify the image editor's crop tool to render the cropped and uncropped content. 2019-03-12 17:22:46 -04:00
Matthew Chen 0a6ad365d4 Refine the image editor crop tool's gestures. 2019-03-12 17:22:46 -04:00
Matthew Chen e9a4ae7add Fix image editor navigation bar button shadows. 2019-03-12 17:22:46 -04:00
Matthew Chen eff929dd1a Add border and shadow to image editor's palette view. 2019-03-12 17:22:46 -04:00
Matthew Chen 6f44167e5c Tweak navigation bar button spacing. 2019-03-12 17:22:46 -04:00
Matthew Chen e2d54d082e Modify attachment approval back button to not have "back" text. 2019-03-12 17:22:46 -04:00
Matthew Chen 7a67a7b6b5 Hide the status bar in the image picker / attachment approval. 2019-03-12 17:22:46 -04:00
Matthew Chen ff08919206 Respond to CR. 2019-03-11 23:25:13 -04:00
Matthew Chen 6fe3ce6d87 Deconflict "bottom view" layout and keyboard animations. 2019-03-11 23:23:08 -04:00
Matthew Chen 6e7c135348 Ensure onboarding views never reclaim layout space from dismissed keyboard. 2019-03-11 23:23:08 -04:00
Matthew Chen d72c26796d Ensure onboarding views never reclaim layout space from dismissed keyboard. 2019-03-11 23:23:08 -04:00
Matthew Chen 53802d1a48 Deconflict "bottom view" layout and keyboard animations. 2019-03-11 23:23:08 -04:00
Matthew Chen 97603e64cc Deconflict "bottom view" layout and keyboard animations. 2019-03-11 23:23:07 -04:00
Michael Kirk be523d5fe9 Merge branch 'release/2.37.0' 2019-03-04 14:43:48 -07:00
Matthew Chen 6cae61bf18 Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
2019-03-02 15:40:38 -05:00
Matthew Chen 49685c52bb Temporarily enable image editor. 2019-03-02 15:40:24 -05:00
Matthew Chen 3209ce6cd9 Normalize images in the image editor. 2019-03-02 15:30:32 -05:00
Matthew Chen 22626bdffd Revert "Temporarily enable image editor."
This reverts commit 1078756bc6.
2019-03-01 16:49:35 -05:00
Matthew Chen 1078756bc6 Temporarily enable image editor. 2019-03-01 16:49:10 -05:00
Matthew Chen 6052ce477a Revert "Temporarily enable image editor."
This reverts commit 66c0419131.
2019-03-01 16:00:07 -05:00
Matthew Chen 66c0419131 Temporarily enable image editor. 2019-03-01 15:59:28 -05:00
Matthew Chen ddbef4e311 Respond to CR. 2019-03-01 15:56:52 -05:00
Matthew Chen c31d469651 Improve new text item continuity. 2019-03-01 15:42:22 -05:00
Matthew Chen 371c12bd40 Show caption indicators in attachment approval media rail. 2019-03-01 15:42:22 -05:00
Matthew Chen 80d297c10a Render strokes behind text. 2019-03-01 15:42:22 -05:00
Matthew Chen 871dceac3a Improve palette interactions. 2019-03-01 11:21:19 -05:00
Matthew Chen 1a159d4d70 Clean up brush stroke gesture usage. 2019-03-01 10:37:36 -05:00
Matthew Chen 3d96cd488e Improve color continuity in the image editor. 2019-03-01 10:37:22 -05:00