oxen-io/session-ios
1
0
Fork 0
mirror of https://github.com/oxen-io/session-ios.git synced 2023-12-13 21:30:14 +01:00
Code Issues Projects Releases Wiki Activity
11464 commits 5 branches 133 tags 218 MiB
Commit graph

11464 commits

This branch
This branch
All branches
Author SHA1 Message Date
Matthew Chen 76ac745f8b Merge branch 'charlesmchen/imageEditorFixes3' 2019-03-21 15:22:10 -04:00
Matthew Chen 558b5f5816 Tap to dismiss caption editor. 2019-03-21 15:21:36 -04:00
Matthew Chen 4ea608cd45 Ensure status bar is hidden in image editor subviews. 2019-03-21 15:21:36 -04:00
Michael Kirk 607adbf261 Merge branch 'mkirk/search-qa' 2019-03-21 12:04:49 -07:00
Michael Kirk e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 2019-03-21 12:04:37 -07:00
Michael Kirk 2c72775815 Merge branch 'mkirk/keyboard-dismiss-bug2' 2019-03-21 10:37:59 -07:00
Michael Kirk 3850ca29b0 Bigger hack to fix problem with lesser hack. 
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
 2019-03-21 10:37:54 -07:00
Matthew Chen a4c4ac9be4 Merge branch 'charlesmchen/callkitLocale' 2019-03-21 11:16:38 -04:00
Matthew Chen 1b9eb3c572 Ensure Callkit is enabled for locale. 2019-03-21 11:16:11 -04:00
Matthew Chen 6a82dd2ba7 Merge branch 'charlesmchen/accessibilityIdentifiers2' 2019-03-21 11:12:16 -04:00
Matthew Chen 40c9c196aa Fix memory leaks. 2019-03-21 11:12:04 -04:00
Matthew Chen 908fe1d0c9 Apply presentAlert() throughout codebase. 2019-03-21 10:58:49 -04:00
Matthew Chen 882dd16d7c Apply presentAlert() throughout codebase. 2019-03-21 10:55:04 -04:00
Matthew Chen c9d62f47cc Respond to CR. 2019-03-21 10:26:38 -04:00
Matthew Chen 1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:57 -04:00
Matthew Chen cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:25 -04:00
Matthew Chen f37a3059fa Add accessibility identifiers to debug log popups. 2019-03-21 10:08:25 -04:00
Matthew Chen 81508e9d02 Add accessibility identifiers to settings popups. 2019-03-21 10:08:25 -04:00
Matthew Chen d7b1e65a71 Add accessibility identifiers to blocklist popups. 2019-03-21 10:08:25 -04:00
Matthew Chen f1520d760e Add accessibility identifiers to other settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen b48e204b90 Add accessibility identifiers to notification settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen 02340864f8 Add accessibility identifiers to blocklist view. 2019-03-21 10:08:25 -04:00
Matthew Chen f7d86028da Add accessibility identifiers to profile view. 2019-03-21 10:08:25 -04:00
Matthew Chen c619f815b5 Add accessibility identifiers to app settings view. 2019-03-21 10:08:25 -04:00
Matthew Chen 931d249677 Modify OWSFlatButton to propagate the accessibility identifier to wrapper button. 2019-03-21 10:08:25 -04:00
Matthew Chen 41a3c95831 Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen 8bcc19e36c Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen 3397c257d9 Merge branch 'charlesmchen/attachmentDownloadProgress2' 2019-03-21 10:07:46 -04:00
Matthew Chen 6ee4317590 Add "track" to attachment download progress indicator. 2019-03-21 10:07:38 -04:00
Matthew Chen 5e1df366f0 Merge branch 'charlesmchen/validMediaAsserts' 2019-03-21 10:07:17 -04:00
Matthew Chen c2c08d0712 Remove overzealous valid media asserts. 2019-03-20 14:43:18 -04:00
Matthew Chen ca6f3b52a1 Merge branch 'charlesmchen/constantBubbleSizes2' 2019-03-20 11:33:47 -04:00
Matthew Chen 31b4612746 Rework attachment download progress for generic attachments. 2019-03-20 11:33:36 -04:00
Matthew Chen 5df4a0bc17 Rework attachment download progress for audio files. 2019-03-20 11:33:36 -04:00
Michael Kirk 4b5994d1b3 Merge branch 'mkirk/video-call-hint' 2019-03-19 13:56:36 -07:00
Michael Kirk 93c9c83ac5 Haptic feedback when remote enables video 2019-03-19 13:56:20 -07:00
Michael Kirk 179dec299f Show hint when other party enables video 2019-03-19 13:56:20 -07:00
Michael Kirk 6ccd73837c rename haptic classes, no change in functionality 2019-03-19 13:56:20 -07:00
Michael Kirk 7d72244315 autogenstrings 2019-03-19 12:09:53 -07:00
Michael Kirk aa46113b4a disable custom capture flow for now 2019-03-19 12:08:40 -07:00
Michael Kirk 96dda0cacf "Bump build to 2.38.0.5." 2019-03-19 12:06:13 -07:00
Matthew Chen e985d2631a Merge branch 'charlesmchen/alwaysObserveCVM' 2019-03-19 11:17:27 -04:00
Matthew Chen 9fe3aa06ed Respond to CR. 2019-03-19 11:15:09 -04:00
Matthew Chen 6ab8ea9b6e Respond to CR. 2019-03-19 11:13:06 -04:00
Matthew Chen a8e9b87f03 Rework menu actions focus item layout. 2019-03-19 11:12:30 -04:00
Matthew Chen 4f06e6dd6e Conversation view always observes view model. 2019-03-19 10:03:58 -04:00
Matthew Chen 13f24002c6 Merge branch 'charlesmchen/textLayerMeasurement' 2019-03-19 09:42:49 -04:00
Matthew Chen 52d6aa69b8 Improve measurement of image editor text layers. 2019-03-19 09:42:38 -04:00
Michael Kirk 204098f38a update pods 2019-03-18 15:23:40 -07:00
Michael Kirk 4a905edce2 Merge branch 'mkirk/url-detection' 2019-03-18 15:21:31 -07:00