Commit graph

336 commits

Author SHA1 Message Date
Matthew Chen 658746093d Use finalIndex in row changes. 2017-11-20 14:44:10 -05:00
Michael Kirk 8ee030bea1 Don't dismiss keyboard when view appears
// FREEBIE
2017-11-20 14:30:55 -05:00
Matthew Chen 937ac5830d Skip animations in conversation view. 2017-11-16 17:59:32 -05:00
Matthew Chen b67179b45d Skip animations in conversation view. 2017-11-16 17:53:05 -05:00
Matthew Chen 0ccddb696a Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
2017-11-16 17:32:39 -05:00
Matthew Chen 96274a60a9 Respond to CR.
// FREEBIE
2017-11-16 17:30:19 -05:00
Matthew Chen 7aae47b021 Reduce font size of "load more" indicator. 2017-11-16 17:30:19 -05:00
Matthew Chen ddf4bf28cc Load attachments for conversation view items using long-lived db connection. 2017-11-16 13:16:18 -05:00
Matthew Chen df5aa5ef67 Update UI to reflect changes to disappearing messages configuration. 2017-11-16 12:25:43 -05:00
Michael Kirk 9675cbb1e1 Scroll only as far as necessary
// FREEBIE
2017-11-15 17:30:45 -05:00
Matthew Chen cc90f4cb80 Respond to CR.
// FREEBIE
2017-11-15 15:46:27 -05:00
Matthew Chen 86fdd6dea2 Fix edge cases in conversation view. 2017-11-15 15:43:03 -05:00
Matthew Chen 6413bc8e4c Evacuate the view item cache. 2017-11-15 13:36:56 -05:00
Matthew Chen 19ba564f80 Respond to CR.
// FREEBIE
2017-11-15 13:21:31 -05:00
Matthew Chen c6160a5a1e Rework the "update with..." methods to avoid re-saving deleted models. 2017-11-15 07:16:12 -05:00
Michael Kirk 8c69e00a3f Adapt ConversationViewController to iPhoneX
// FREEBIE
2017-11-14 12:37:09 -05:00
Matthew Chen bf0f33e4b0 Temporarily alter animations in conversation view. 2017-11-10 14:51:34 -05:00
Matthew Chen af6a7c103c Add a comment. 2017-11-10 14:08:52 -05:00
Matthew Chen 42a70e0def Revert "Temporarily make logging around conversation view row updates more verbose."
This reverts commit 105b033761.
2017-11-10 14:04:56 -05:00
Matthew Chen f0a8e08df9 Temporarily alter animations in conversation view. 2017-11-10 13:17:38 -05:00
Matthew Chen b5f7a4746f Temporarily alter animations in conversation view. 2017-11-10 12:41:11 -05:00
Matthew Chen 105b033761 Temporarily make logging around conversation view row updates more verbose. 2017-11-10 11:37:16 -05:00
Matthew Chen 87b0692af0 Fixes for scrolling in conversation view. 2017-11-10 09:41:27 -05:00
Matthew Chen 5cc292fb6c Don't ask for camera permissions if app is not active.
// FREEBIE
2017-11-09 03:02:05 -05:00
Matthew Chen 5e61307ce3 Don't ask for microphone permissions if app is not active.
// FREEBIE
2017-11-09 02:58:51 -05:00
Matthew Chen 6e840ff956 Fix build warnings from XCode 9. 2017-11-09 02:52:44 -05:00
Matthew Chen 2d21e2ae2c Fix build warnings from XCode 9. 2017-11-09 02:52:44 -05:00
Matthew Chen af5489952c Don't animate message sends.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen 40e04ffb92 Respond to CR.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen 5df4ac92b7 Don't animate message sends.
// FREEBIE
2017-11-01 20:43:43 -04:00
Matthew Chen d52b19a69e Let users with external keyboards send messages using modifier-return (shift, command, option).
// FREEBIE
2017-11-01 12:46:55 -04:00
Matthew Chen 0c92850d38 Log voice memo durations.
// FREEBIE
2017-11-01 12:45:22 -04:00
Matthew Chen 89dbcb0fe8 Respond to CR.
// FREEBIE
2017-11-01 12:36:37 -04:00
Matthew Chen f95e599c55 Don't overwrite draft after GIF send.
// FREEBIE
2017-11-01 12:36:36 -04:00
Matthew Chen a0ddb2a06d Respond to CR.
// FREEBIE
2017-10-31 15:01:29 -04:00
Matthew Chen 5ac2f16ebc Skip redundant relayout.
// FREEBIE
2017-10-31 14:33:30 -04:00
Matthew Chen 9cc4521d07 Respond to CR.
// FREEBIE
2017-10-26 12:09:36 -04:00
Matthew Chen bcf83a4c8e Rework handling of oversize text messages.
// FREEBIE
2017-10-26 11:56:03 -04:00
Michael Kirk 8f9311a6ac Show timer in navbar without reload
// FREEBIE
2017-10-25 14:40:05 -07:00
Michael Kirk 709010499f remove overzealous assert
// FREEBIE
2017-10-25 14:39:12 -07:00
Michael Kirk cd291e19ff We conceivably want to to initiate calls more than once without leaving
the conversation view. e.g. from Contacts.app

// FREEBIE
2017-10-25 11:37:04 -07:00
Michael Kirk 4000760cf7 Fix "back button count" flash. Only call once.
This affects returning from message info or when leaving conversation
settings.

// FREEBIE
2017-10-25 11:31:06 -07:00
Michael Kirk 43dd3abf6c clamp value per CR
// FREEBIE
2017-10-24 15:29:04 -07:00
Michael Kirk 59b125c3fb Add clarifying comment per CR
// FREEBIE
2017-10-24 15:29:04 -07:00
Michael Kirk d87f000051 Interactive/Cancelable slide left for details
// FREEBIE
2017-10-24 15:29:03 -07:00
Matthew Chen fb3bb852ca Tap image attachment preview to view full screen.
// FREEBIE
2017-10-24 17:12:26 -04:00
Matthew Chen 27af310235 Auto-dismiss keyboard if user scrolls away from bottom of the conversation.
// FREEBIE
2017-10-24 13:58:56 -04:00
Matthew Chen cbb0030b12 Rework attachment approval UI.
// FREEBIE
2017-10-24 09:42:29 -04:00
Michael Kirk 1fee5d97e6 Merge branch 'release/2.18.0' 2017-10-23 16:02:11 -07:00
Michael Kirk 21df2dc047 Never hide "failed to send" footer
// FREEBIE
2017-10-23 08:40:26 -07:00
Michael Kirk f3f0d591ea Revert "Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons."
This reverts commit 7c82f6d448.

This wasn't helping our crash rate, and on my device, as of iOS11.1B2,
the button is easily tappable, not detectably different from prior iOS
releases.
2017-10-20 16:37:07 -07:00
Michael Kirk 66ab4e2549 Merge tag '2.16.2.0' into release/2.18.0 2017-10-20 16:23:58 -07:00
Michael Kirk 2d10080c33 Merge tag '2.17.1.1' into release/2.18.0 2017-10-20 16:23:10 -07:00
Michael Kirk 68e755ade9 Merge branch 'release/2.18.0' 2017-10-20 16:10:07 -07:00
Michael Kirk 0cd56d4bcc On iOS11 doc picker requires system appearance.
Otherwise nav items are illegible.

// FREEBIE
2017-10-20 12:35:21 -07:00
Matthew Chen 7fa7d5d526 Fix "mark as read."
// FREEBIE
2017-10-20 09:53:33 -04:00
Matthew Chen b0aa84e420 Clean up conversation view.
// FREEBIE
2017-10-19 23:02:59 -04:00
Matthew Chen d355b45bae Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen c2608785e1 Reduce relayout and reload churn; respond to dynamic type changes.
// FREEBIE
2017-10-19 22:53:06 -04:00
Matthew Chen 4dc6934fc7 End text editing if we leave conversation view.
// FREEBIE
2017-10-19 22:48:28 -04:00
Matthew Chen 45ba79d296 Auto-load more message if user scrolls near the top of the conversation.
// FREEBIE
2017-10-19 22:39:42 -04:00
Matthew Chen f28abbc2a1 Revert from numeric to default keyboard after message send.
// FREEBIE
2017-10-19 22:36:25 -04:00
Matthew Chen 4dabb71815 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 22:33:51 -04:00
Matthew Chen fb4d43d542 Fix "can't send same GIF twice" issue.
// FREEBIE
2017-10-19 10:04:49 -07:00
Matthew Chen 0fe76aaab8 Move "attachment approval" into input toolbar.
// FREEBIE
2017-10-18 12:50:16 -07:00
Matthew Chen 06eb794db6 Simplify and fix edge cases around long pressing on system message cells.
// FREEBIE
2017-10-18 12:31:23 -07:00
Matthew Chen 4a94d039e8 Restore the input toolbar's placeholder text.
// FREEBIE
2017-10-18 12:18:15 -07:00
Matthew Chen c47573334b Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen 3b945a9da2 Respond to CR.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen 257f8249bf Cull cached cell media outside a load window.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen e77292c2a9 Add contentWidth property to ConversationViewCell.
// FREEBIE
2017-10-18 12:13:26 -07:00
Matthew Chen b9f6bbb369 Clean up ahead of PR.
// FREEBIE
2017-10-18 09:30:03 -07:00
Matthew Chen 163e66dd4f Restore "load more messages" functionality.
// FREEBIE
2017-10-18 09:30:03 -07:00
Matthew Chen ed350f8ea6 Add vertical scroll indicator to conversation view.
// FREEBIE
2017-10-18 08:37:47 -07:00
Matthew Chen 032ec59d1c Respond to CR.
// FREEBIE
2017-10-16 21:05:29 -07:00
Matthew Chen 132d5b3408 Clean up ahead of PR.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen 3723a4845f Restore message cell footers.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen c2f07bb3d8 Restore message cell footers.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen 227fd5280d Resize conversation view cells as necessary.
// FREEBIE
2017-10-16 20:41:14 -07:00
Matthew Chen f7bd813c9f Restore the date headers to the conversation view cells.
// FREEBIE
2017-10-16 20:41:14 -07:00
Michael Kirk 0f859d6b20 Merge branch 'release/2.18.0' 2017-10-16 12:27:20 -07:00
Michael Kirk 3080cb512b Compose View: collation index and group search
- Include table index for contacts
- Fix extra spacing in OWS table view
- Separate search results into contact/invite sections
- Include groups in search results when composing new message
- Compose Screen search matches on group member names

// FREEBIE
2017-10-16 12:22:02 -07:00
Matthew Chen 7c82f6d448 Add workaround for bug in iOS 11.1 beta around hit area of custom back buttons.
// FREEBIE
2017-10-13 12:57:44 -04:00
Matthew Chen 49501a5d1b Respond to CR.
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen 5621fe893c Clean up ahead of PR.
// FREEBIE
2017-10-12 16:23:48 -04:00
Matthew Chen fb408f980c Remove JSQ.
// FREEBIE
2017-10-12 16:23:48 -04:00
Michael Kirk 796be18c56 enable gif picker
// FREEBIE
2017-10-12 14:58:25 -04:00
Matthew Chen 380ed0f82b Create & access groups more carefully.
// FREEBIE
2017-10-04 09:45:09 -04:00
Matthew Chen cef1f9186d Fix the scroll down button margins.
// FREEBIE
2017-10-03 11:18:57 -04:00
Matthew Chen fd9188415f Respond to CR.
// FREEBIE
2017-10-02 14:26:03 -04:00
Matthew Chen 801734a938 Clean up ahead of PR.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen 5b70116209 Unify the "message was sent" logic in conversation view. Ensure "message sent" sounds are played after sending attachments.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen a65a4b133c Clean up ahead of PR.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen 2dfd7aa0e9 Actually send GIFs.
// FREEBIE

SQUASH ME.

SQUASH ME.
2017-10-02 13:37:32 -04:00
Matthew Chen 62ba5701f6 Sketch out GIF picker.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen 27e5a2f1b2 Sketch out GIF picker.
// FREEBIE
2017-10-02 13:37:32 -04:00
Matthew Chen dbe2c6aa76 Fix scroll down button.
// FREEBIE
2017-10-01 14:22:01 -04:00
Matthew Chen f99ce23e69 Fix wrongful "add to contacts offer" issue.
// FREEBIE
2017-09-29 16:38:57 -04:00
Matthew Chen 6abc4bed90 Increase hot area of scroll down button.
// FREEBIE
2017-09-29 14:39:35 -04:00
Michael Kirk e2445e6ed2 Fix RTL bubbles in conversation and message detail view
// FREEBIE
2017-09-28 16:34:10 -04:00
Michael Kirk c3bb8a0190 on main thread, per CR
// FREEBIE
2017-09-28 14:59:00 -04:00
Michael Kirk 5704bf1765 message bubbles for message detail view controller
// FREEBIE
2017-09-28 14:58:15 -04:00
Michael Kirk e77a7e09bb Fix assert for empty thread
// FREEBIE
2017-09-28 13:06:29 -04:00
Matthew Chen d557817bb4 Format message statuses with date if possible.
// FREEBIE
2017-09-27 16:38:48 -04:00
Matthew Chen af7fd60d76 Fix NPE in conversation view.
// FREEBIE
2017-09-27 11:31:48 -04:00
Matthew Chen 9f9ac746d1 Sketch out message metadata view.
* Show message metadata view from conversation view.
* Pull out MediaMessageView class.
* Track recipient read timestamps.
* Add per-recipient status to message metadata view.
* Add share button to message metadata view.

// FREEBIE
2017-09-25 17:25:49 -04:00
Matthew Chen 315c1d7dc4 Hide all read receipts in UI if not enabled.
// FREEBIE
2017-09-25 17:22:27 -04:00
Matthew Chen 11cadf4200 Send, receive & show read receipts to senders/from receivers.
* Send read receipts to senders.
* Honor "send read receipts" preference.
* Process read receipts from recipients.
* Refactor "mark as read" logic.
* Serialize and apply recipient read receipts received before sync transcript.
* Show recipient read receipts in conversation view.

// FREEBIE
2017-09-22 14:24:17 -04:00
Matthew Chen c92c6de7b9 Add stress group to debug UI.
// FREEBIE
2017-09-22 10:40:23 -04:00
Matthew Chen 7268bde506 Add stress group to debug UI.
// FREEBIE
2017-09-22 10:30:35 -04:00
Matthew Chen bd416176ae Add stress group to debug UI.
// FREEBIE
2017-09-22 00:31:13 -04:00
Matthew Chen 35a2470cb7 Post notifications asynchronously.
// FREEBIE
2017-09-21 17:03:57 -04:00
Matthew Chen b28c4b74b2 Pull out TSMessageDecrypter class.
// FREEBIE
2017-09-21 14:38:30 -04:00
Matthew Chen f1b7d895e2 Modify precommit script to clean up includes and forward declarations.
// FREEBIE
2017-09-20 15:33:17 -04:00
Matthew Chen fa353259c3 Process messages in a single transaction (wherever possible).
// FREEBIE
2017-09-20 10:56:04 -04:00
Matthew Chen 6fce2c26b7 Process messages in a single transaction (wherever possible).
// FREEBIE
2017-09-20 09:40:46 -04:00
Matthew Chen 80e5f281c6 Rename app preferences class.
// FREEBIE
2017-09-19 17:35:42 -04:00
Matthew Chen c0f5bda2be Respond to CR.
// FREEBIE
2017-09-19 09:39:38 -04:00
Matthew Chen 400f536e37 Respond to CR.
// FREEBIE
2017-09-19 09:30:01 -04:00
Matthew Chen 872ce17dd6 Clean up data source temp files when complete.
// FREEBIE
2017-09-19 09:30:01 -04:00
Matthew Chen 541966aaf6 Fix NPEs when profiles change while entering conversation view.
// FREEBIE
2017-09-18 16:36:58 -04:00
Matthew Chen 2c68b06412 Respond to CR.
// FREEBIE
2017-09-18 16:12:51 -04:00
Matthew Chen 05b1818874 Don't "scroll to bottom" when messages are sent from desktop.
// FREEBIE
2017-09-18 15:49:33 -04:00
Matthew Chen 48121e5eac Don't "scroll to bottom" when messages are sent from desktop.
// FREEBIE
2017-09-18 15:49:32 -04:00
Matthew Chen 5be2014ec7 Create Flat UI rounded button class.
// FREEBIE
2017-09-12 14:45:57 -04:00
Matthew Chen ab00342d67 Add modal activity indicator view.
// FREEBIE
2017-09-11 12:49:14 -04:00
Matthew Chen 9dfebb2d4b Apply OWSFail() in more places.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen c21a7673c8 Rework preservation of attachment filenames.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen b95b5f69de Apply DataSource to message sender.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 20e5013aae Convert DataSource to Objective-C.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 69816cdf0e Convert DataSource to Objective-C.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 2282733fa9 Add data source class.
// FREEBIE
2017-09-11 10:20:48 -04:00
Matthew Chen 26a6e76f3c Rework conversation view header.
// FREEBIE
2017-09-07 10:47:35 -04:00
Matthew Chen b626fb5bf8 Rework conversation view header.
// FREEBIE
2017-09-07 10:36:28 -04:00
Matthew Chen 644f435b16 Rework conversation view header.
// FREEBIE
2017-09-07 10:35:11 -04:00
Matthew Chen c106794fe8 Rename conversation view.
// FREEBIE
2017-09-06 14:13:18 -04:00
Renamed from Signal/src/ViewControllers/ConversationView/MessagesViewController.m (Browse further)