Commit graph

219 commits

Author SHA1 Message Date
Matthew Chen 9845ef6dac Add message approval view. 2018-01-25 13:26:40 -05:00
Matthew Chen 3cfc778358 Add message approval view. 2018-01-25 13:26:40 -05:00
Matthew Chen 2af858c529 Add message approval view. 2018-01-25 13:26:39 -05:00
Matthew Chen 979386ee9e Improve handling of text and url shares. 2018-01-25 13:26:10 -05:00
Matthew Chen 5770a18b08 Handle text shares like URLs. 2018-01-25 13:26:10 -05:00
Matthew Chen 9718387af5 Send URLs as text messages. 2018-01-25 13:26:10 -05:00
Matthew Chen 085975ebe9 Prepopulate caption field with URL. 2018-01-25 13:26:10 -05:00
Matthew Chen 2e8a53b4a5 Don't add captions to text messages. 2018-01-25 13:26:10 -05:00
Matthew Chen 992e926142 Unpack oversize text messages if possible. 2018-01-25 13:26:10 -05:00
Matthew Chen b9bd21e73f Improve presentation of text attachments in attachment approval view. 2018-01-25 13:24:22 -05:00
Matthew Chen 6a80db7844 Enable support for sharing urls in SAE. 2018-01-25 13:23:00 -05:00
Michael Kirk 5dde17d939 Show approval/caption view in app.
ApprovalView/Captioning is shown for:
- Images/Videos from Library
- Images/Video from Camera
- Document Picker
- GIFs

Voice notes are intentionally not captionable.

Also, in main app, hide status bar when ApprovalView is presented

// FREEBIE
2018-01-17 18:19:48 -05:00
Michael Kirk 94d58b88b8 Play video inline in approval view
Previously we launched the MPMoviePlayerController

// FREEBIE
2018-01-16 17:57:14 -05:00
Michael Kirk 0c6a42003f clang-format after RI
// FREEBIE
2018-01-16 15:27:53 -05:00
Michael Kirk a423fe8a0e WIP Merge tag '2.19.4.4'
- restore video playback in fullscreen

This was a large merge, so I'm opting to make some changes in separate
commits.
2018-01-16 15:25:58 -05:00
Matthew Chen e77c3e6717 Retain changes from session database branch. 2018-01-10 12:18:23 -05:00
sdkjfhsdkjhfsdlkjhfsdf 3a6ddd4bf8 CR: cleanup
// FREEBIE
2018-01-02 11:24:36 -06:00
sdkjfhsdkjhfsdlkjhfsdf 6e2d9c8141 identity change vs. share extension
// FREEBIE
2018-01-02 11:24:36 -06:00
sdkjfhsdkjhfsdlkjhfsdf 6b5883dc10 Don't resize attachment view when switching between alerts.
// FREEBIE
2018-01-02 11:24:36 -06:00
sdkjfhsdkjhfsdlkjhfsdf 01fa3c89cc CR: cleanup comments, extract callback into method
// FREEBIE
2017-12-21 10:36:42 -06:00
sdkjfhsdkjhfsdlkjhfsdf b87079d4b4 Sharing attachment shows progress / retry dialog
// FREEBIE
2017-12-20 20:57:17 -06:00
sdkjfhsdkjhfsdlkjhfsdf 42ea1dfbbe CR: more margin, match button size to default text field, fix layout
when rotated.

There was an issue with captions changing line-count when rotated.

// FREEBIE
2017-12-20 16:58:51 -06:00
sdkjfhsdkjhfsdlkjhfsdf 7907a64dfe move gradient up with keyboard
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf 653a272b54 Don't obscure attachment when keyboard is popped.
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf 38d94952f7 Shadow for Send button, clean up color accessors
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf cfa147831a "Done" button for caption toolbar
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf 9eb4178c6f style for captioning toolbar
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf 513e33b0fd Cleanup before code review
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf 2c20cb9e7b make sure mediaview isn't too tall in detail view
// FREEBIE
2017-12-20 14:26:53 -06:00
sdkjfhsdkjhfsdlkjhfsdf 0e9c9a9bb3 Separate gestures for text/vs media
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk e20f44024c WIP: Support sending attachment captions
Looks fine on other clients, but locally we don't display the caption.

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk 0964c16417 cleanup, plus ill fated attempt to offset content beyond keyboard height.
Probably should just pin scrollview above initial toolbar height. I
think it's somewhat convoluted because of the scroll view zoom
functionality that we already use in this view.

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk 26be69975a cleanup constraint based layout 2017-12-20 14:26:53 -06:00
Michael Kirk 3a078c831d lays out in iOS11, but doesn't resize 2017-12-20 14:26:53 -06:00
Michael Kirk 03e786a145 input toolbar looks good on iOS9/10, but totally broken on 11
// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk 96906440a7 remove height animation, ensure growing text area has content in proper
place.

// FREEBIE
2017-12-20 14:26:53 -06:00
Michael Kirk 562e706ec9 animate height change, but looks goofy 2017-12-20 14:26:53 -06:00
Michael Kirk a5c5dd3f96 WIP, extract subclass 2017-12-20 14:26:53 -06:00
Michael Kirk 9ee9a0efeb resizing input accessory view.
// FREEBIE
2017-12-20 14:26:52 -06:00
Michael Kirk f9524b02e2 multiline must be textview, not textfield
// FREEBIE
2017-12-20 14:26:52 -06:00
Michael Kirk 57a5e62db8 WIP - attachment caption 2017-12-20 14:26:52 -06:00
Matthew Chen 9a990b58e8 Respond to CR. 2017-12-19 11:38:25 -05:00
Michael Kirk 6fb5990faa Don't zoom for audio/generic attachments
// FREEBIE
2017-12-12 13:03:53 -05:00
Michael Kirk 73b215229f Fixup approval view for audio and generic attachments
// FREEBIE
2017-12-12 12:55:27 -05:00
Michael Kirk 813f4e474e Respond to CR
// FREEBIE
2017-12-12 11:09:39 -05:00
Michael Kirk 8996741277 DocumentPicker converts to mp4 when necessary
// FREEBIE
2017-12-11 20:34:47 -05:00
Michael Kirk 031e40d090 Use SignalAttachment logic in conversation view too
// FREEBIE
2017-12-11 20:16:34 -05:00
Michael Kirk 56f1bf0305 cleanup 2017-12-11 19:37:49 -05:00
Michael Kirk 90e9b4a4f2 WIP - send all video types 2017-12-11 14:05:55 -05:00
Michael Kirk 538b3e5fd5 Async API for video export
// FREEBIE
2017-12-11 14:04:26 -05:00
Michael Kirk 21fd7b040e Ensure sent video is mp4
// FREEBIE
2017-12-11 14:03:40 -05:00
Michael Kirk d3e7c99a63 Attachment approval: cancel/confirm to top/bottom toolbars
- avoid double-submit by disabling after hitting send.
- Animate SAE dismissal as modal
  Requires hiding the load view
- attachment is centered in screen
- add gradient to ensure controls are visible
- Fix clamp constraints - I think this was a typo
  Otherwise we couldn't show an image which was 1" wide by 2" tall
- set max zoom, hide scroll indicators
- use media view
- slower panning feels right
- white send button
- can share GIF, static, and sort of video...
- Play button for attachment approval
  - move to image assets so we can use it in SAE
  - slightly larger button for full-screen approval view
  - don't launch redundant fullscreen UI for images when in approval view
- fix scrollOffset in AttachmentApproval
- consolidate view initialization logic in loadView and fix white background
- CR: more legible arithmetic

// FREEBIE
2017-12-11 13:58:03 -05:00
Matthew Chen bf09c805b9 Respond to CR. 2017-12-11 11:27:53 -05:00
Matthew Chen c918279597 Convert image attachment thresholds to be based on file size. 2017-12-11 10:37:20 -05:00
Matthew Chen 80ae5e0fcf Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 11b4848530 Respond to CR. 2017-12-11 10:37:20 -05:00
Matthew Chen 84061cca9f Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Matthew Chen 55aa5eef6c Clean up ahead of PR. 2017-12-11 10:37:20 -05:00
Matthew Chen 125aabb0a3 Change image resizing/quality behavior, preferring smaller images in the common case. 2017-12-11 10:37:20 -05:00
Michael Kirk d9cca77e23 update header references
// FREEBIE
2017-12-08 13:32:52 -05:00
Michael Kirk 3ecf0a7537 Cancelling dismisses share extension, remove "import with signal"
Usinig the new ShareViewDelegate to dismiss the share extension, might
have broken the "import with signal" functionality. But because we
want to remove it anyway, I've done that now, rather than fix it up.

// FREEBIE
2017-12-07 17:12:03 -05:00
Michael Kirk 0429836ff9 CR: rename keyWindow -> keyReferenceView, split long line
// FREEBIE
2017-12-07 10:39:44 -05:00
Michael Kirk 3f6f881d3f Use assets from duplicated main bundle
// FREEBIE
2017-12-07 10:14:30 -05:00
Michael Kirk eca19e5874 Reconcile MediaMessageView zoom behavior with AppExtension
Previously it was predicated on UIApplication.shared

// FREEBIE
2017-12-07 10:14:30 -05:00
Michael Kirk 3eceb86371 Show alert if we fail to build the attachment
// FREEBIE
2017-12-07 10:14:30 -05:00
Michael Kirk 89b9887f1d Make DeviceSleepManager extension compatible
// FREEBIE
2017-12-07 10:13:47 -05:00
Michael Kirk e20072ff2b CR: remove bundle specific image assets
// FREEBIE
2017-12-07 10:13:06 -05:00
Michael Kirk 56fe9d057d Attachment Approval
// FREEBIE
2017-12-07 10:13:06 -05:00
Michael Kirk a58f1f385c Share a photo from photos app
Shows the conversation picker, and sends the attachment to that
conversation.

There's still a lot TODO

-[ ] resolve JSQ dependency
-[ ] properly wait for app to load
-[ ] dismiss share extension after send is complete
-[ ] support non jpeg file types
-[ ] Fix device sleep manager

// FREEBIE
2017-12-07 10:13:06 -05:00