Commit Graph

4562 Commits

Author SHA1 Message Date
Michael Kirk 9e348f2a27 update ubsan 2018-07-19 13:41:15 -06:00
Nancy Mast 4ab6892e27 changed string text for MULTIDEVICE_PAIRING_MAX_DESC, ATTACHMENT_PICKER_DOCUMENTS_PICKED_DIRECTORY_FAILED_ALERT_BODY, CONTACT_FIELD_ADDRESS_POSTCODE, END_CALL_RESPONDER_IS_BUSY. changed comment for SETTINGS_INVITE_TWITTER_TEXT 2018-07-19 09:45:44 -06:00
Nancy Mast c2f7c15f72 removed jsq strings, modified MULTIDEVICE_PAIRING_MAX_RECOVERY text and comment 2018-07-19 09:45:44 -06:00
Matthew Chen 7f33236d6c Respond to CR. 2018-07-18 13:57:22 -04:00
Matthew Chen ace07ac62a Respond to CR. 2018-07-18 13:57:22 -04:00
Matthew Chen ebe87348a2 Streamline SignalRecipient. 2018-07-18 13:57:21 -04:00
Matthew Chen d14f764b50 Streamline SignalRecipient. 2018-07-18 13:57:21 -04:00
Michael Kirk ef9a0880ae Fix analyzer warnings 2018-07-18 10:24:08 -06:00
Michael Kirk baacebc956 Enable (quick) static analyzer for normal builds
// FREEBIE
2018-07-18 10:24:08 -06:00
Michael Kirk 12ef25420a Fixup SSK tests 2018-07-17 19:32:44 -06:00
Michael Kirk d591fb7f2c Fix some compiler warnings 2018-07-17 19:22:58 -06:00
Michael Kirk c19a8ce07e Fixup tests
// FREEBIE
2018-07-17 18:17:17 -06:00
Michael Kirk 1c9a47416a "Bump build to 2.28.0.10." 2018-07-17 14:54:07 -06:00
Michael Kirk 89f02a8510 sync translations 2018-07-17 14:54:00 -06:00
Michael Kirk 2b5db4fd1a Add header view to info messages.
I considered extracting this from OWSMessageCell and putting it into
ConversationCell, but that would be a pretty large change.

// FREEBIE
2018-07-17 14:49:43 -06:00
Michael Kirk a6a09f4d9f fix squashed cells on ios9/10
must specify rowHeight automatic

Furthermore, we can't mix static and automatic sizing within a single tableView
2018-07-17 14:36:37 -06:00
Michael Kirk 17e79a522a fixup audio/generic atachment margins 2018-07-17 12:58:39 -06:00
Michael Kirk c2063d8600 replace bullet with center-dot unicode
// FREEBIE
2018-07-17 12:53:01 -06:00
Michael Kirk 7b85410136 per design: MessageStatus 1pt below baseline 2018-07-17 10:06:08 -06:00
Michael Kirk 567f625902 touch instead of reload to make sure any adjacent bubbles are updated appropriately. 2018-07-17 09:53:45 -06:00
Michael Kirk 2c3f7db4e4 Only add one 'incoming message' unread indicator per foreground.
// FREEBIE
2018-07-17 09:53:45 -06:00
Michael Kirk f2f3b9eaed reload cell after removing unread indicator
// FREEBIE
2018-07-17 09:53:45 -06:00
Michael Kirk 1b78882660 per design: tweak quote corner radius
// FREEBIE
2018-07-16 17:49:14 -06:00
Michael Kirk b9f3e08e93 "Bump build to 2.28.0.9." 2018-07-16 17:27:20 -06:00
Michael Kirk 089010cc51 Sync translations 2018-07-16 17:27:11 -06:00
Óscar Morales Vivó 24f30e015a Fixed settings button margin in home view controller, also fixes land scape button image glitch. 2018-07-16 16:09:39 -06:00
Michael Kirk c53f777bc1 CR: explanatory comment 2018-07-16 13:51:22 -06:00
Michael Kirk 898d64ae1c Fix compose picker content scrolls behind navbar
// FREEBIE
2018-07-16 13:51:22 -06:00
Matthew Chen e3622739b2 Remove media thumbnail shadows. 2018-07-16 12:55:29 -06:00
Matthew Chen 15bfe44b1e Update icon for generic attachments. 2018-07-16 12:54:17 -06:00
Michael Kirk 24060c17d0 CR: proper width calculation for header view 2018-07-16 12:52:00 -06:00
Michael Kirk f33e5c019c CR: assign gutter trailing/leading in HeaderView
// FREEBIE
2018-07-16 12:52:00 -06:00
Michael Kirk fef6c64bdc decrease header spacing from 32->28.
Previous spacing was based on applying the "full width" gutter spacing twice.
2018-07-16 12:52:00 -06:00
Michael Kirk 8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
2018-07-16 10:20:05 -06:00
Michael Kirk 9df6b4bb78 Fix "contact cell too close to edge" in detail view (iOS9/iOS10)
Don't mix concepts of left/right with leading/trailing.
2018-07-16 10:20:05 -06:00
Michael Kirk 7d0733fa88 "Bump build to 2.28.0.8." 2018-07-13 17:05:48 -06:00
Michael Kirk 8984e1a717 Sync translations 2018-07-13 17:05:35 -06:00
Michael Kirk 0847c0bafb ScrollToBottom accounts for top inset
// FREEBIE
2018-07-13 14:25:11 -06:00
Matthew Chen 687efabede Respond to CR. 2018-07-13 16:24:36 -04:00
Matthew Chen 96a8df5f88 Fix "new unread indicator animation" issue. 2018-07-13 16:21:57 -04:00
Matthew Chen f69945ea20 Fix 'breaks vs. collapse' issue. 2018-07-13 16:21:57 -04:00
Michael Kirk e911de01e9 Ensure delegate is informed of dismissal
// FREEBIE
2018-07-13 13:00:27 -06:00
Michael Kirk 39bbcca738 CR: cleanup / copy tweak 2018-07-13 13:00:27 -06:00
Michael Kirk dde2fd6f33 Hide menu window when vc dismisses.
Normally this isn't possible, just being paranoid.

// FREEBIE
2018-07-13 13:00:27 -06:00
Michael Kirk 82fdd5b883 Split out generic action sheet components
Keep the message specific components separte, so we could re-use the
MenuActionsViewController.
2018-07-13 13:00:27 -06:00
Michael Kirk 093a5eaa68 don't dismiss if pan is over actionsheet 2018-07-13 13:00:27 -06:00
Michael Kirk 41af4f8c9d highlight on press 2018-07-13 13:00:27 -06:00
Michael Kirk 2606ac47f8 swipe gesture / code reorg 2018-07-13 13:00:27 -06:00
Michael Kirk 41c1c2fcd5 scroll focused view to maximize visability
// FREEBIE
2018-07-13 13:00:27 -06:00
Michael Kirk d31b91663c new icons 2018-07-13 13:00:27 -06:00