Commit graph

1376 commits

Author SHA1 Message Date
Michael Kirk
a1e008f930 apply new rounding/highlight design 2019-04-22 13:44:48 -07:00
Michael Kirk
4af9fa6789 "add more" as rail cell 2019-04-22 13:44:48 -07:00
Michael Kirk
da79a53d96 cleanup compiler warnings 2019-04-15 14:35:35 -06:00
Michael Kirk
fa45339f83 move to public category 2019-04-15 14:35:35 -06:00
Michael Kirk
cfebb53719 more concise constants post translation 2019-04-04 13:44:42 -06:00
Michael Kirk
57b1aaa3dc inline enum converters 2019-04-04 13:44:42 -06:00
Michael Kirk
30266bf65e autoformatted 2019-04-04 13:44:42 -06:00
Michael Kirk
64a0c4bfaa auto-migrate to Swift5 2019-04-04 13:44:42 -06:00
Michael Kirk
501e2c761f Merge tag '2.38.1.2' 2019-04-04 13:42:07 -06:00
Michael Kirk
1fae83a777 respect any CDN headers (eg Host for front) 2019-04-02 20:01:04 -06:00
Michael Kirk
07e88009e4 Merge tag '2.38.0.11' 2019-04-01 14:04:43 -06:00
Matthew Chen
a3efb58d15 Respond to CR. 2019-03-28 18:29:19 -04:00
Matthew Chen
517a550593 Further improve "first responder" behavior in the image editor. 2019-03-28 18:06:35 -04:00
Matthew Chen
eb5cf3978c Fix first responder issue in image editor. 2019-03-28 18:05:46 -04:00
Michael Kirk
fa2d5b422b maintain body text navigating to/from approval view 2019-03-28 11:58:43 -06:00
Michael Kirk
1a4062dd89 Nav buttons: batch, camera/library switch, done 2019-03-28 10:30:47 -06:00
Michael Kirk
7dbb9517af Centralize attachment state in nav controller 2019-03-28 10:30:47 -06:00
Michael Kirk
6502d7d4a5 remove isMultiSendEnabled feature flag 2019-03-28 10:30:47 -06:00
Michael Kirk
1357449dcc Make OrderedDictionary keys generic 2019-03-28 10:30:47 -06:00
Matthew Chen
db958f4a01 Preserve caption text of edited images. 2019-03-26 21:24:25 -06:00
Matthew Chen
d9760b6bbc Fix bug around layer ordering when rendering image editor output. 2019-03-26 21:22:35 -06:00
Matthew Chen
5973c326de Ensure new text items are on the canvas. 2019-03-26 21:21:52 -06:00
Michael Kirk
f8244eeefe Fix SAE crash for iOS9 2019-03-26 17:08:36 -06:00
Michael Kirk
58d99a480f Notify iOS9 users occasionally that iOS10 will soon be required 2019-03-26 11:21:30 -06:00
Matthew Chen
3ce3f9faaa Add accessibilityIdentifiers to conversation settings view. 2019-03-25 09:31:55 -04:00
Matthew Chen
f073dd9a52 Add accessibilityIdentifiers to conversation settings view. 2019-03-25 09:31:55 -04:00
Matthew Chen
4188993fc5 Add accessibilityIdentifiers to 'new contact thread' view. 2019-03-25 09:31:19 -04:00
Matthew Chen
95e125d55e Simplify usage of accessibilityIdentifiers. 2019-03-25 09:31:19 -04:00
Matthew Chen
2d854406a1 Add accessibilityIdentifiers to home view. 2019-03-25 09:31:19 -04:00
Michael Kirk
ed6b461662 search icon 2019-03-22 18:18:56 -07:00
Matthew Chen
a7ae79aaad Ignore keyboard notifications while the view is disappearing or has disappeared. 2019-03-22 10:26:25 -04:00
Matthew Chen
558b5f5816 Tap to dismiss caption editor. 2019-03-21 15:21:36 -04:00
Matthew Chen
4ea608cd45 Ensure status bar is hidden in image editor subviews. 2019-03-21 15:21:36 -04:00
Michael Kirk
e3cc8bb101 Keep results bar visible when dismissing keyboard or returning to view. 2019-03-21 12:04:37 -07:00
Michael Kirk
3850ca29b0 Bigger hack to fix problem with lesser hack.
There were two symptoms to this bad "leave app while dismissing keyboard"
state...

The first, most noticeable symptom was that the main window no longer respected
the device orientation. This was caused by UIKit temporarily disabling
autorotate during an interactive keyboard dismissal, and not cleaning up after
itself when we hid the window mid dismissal due to our screen protection
feature. This was solved previously in: ca0a555f8

The second symptom remained, and is solved by this commit. Wherein after
getting in this bad state, the interactive keyboard dismiss function behaves
oddly. Normally when interactively dismissing the keyboard in a scroll view,
the keyboard top follows your finger, until you lift up your finger, at which
point, depending on how close you are to the bottom, the keyboard should
completely dismiss, or cancel and return to its fully popped position. In the
degraded state, the keyboard would follow your finger, but when you lifted your
finger, it would stay where your finger left it, it would not complete/cancel
the dismiss.

The solution is, instead of only re-enabling autorotate, to use a higher level
private method which is called upon complete/cancellation of the interactive
dismissal. The method, `UIScrollToDismissSupport#finishScrollViewTransition`,
as well as re-enabling autorotate, does some other work to restore the UI to
it's normal post interactive-keyboard-dismiss gesture state.

For posterity here's the decompiled pseudocode:

```
/* @class UIScrollToDismissSupport */
-(void)finishScrollViewTransition {
    *(int8_t *)&self->_scrollViewTransitionFinishing = 0x0;
    [self->_controller setInterfaceAutorotationDisabled:0x0];
    [self hideScrollViewHorizontalScrollIndicator:0x0];
    ebx = *ivar_offset(_scrollViewNotificationInfo);
    [*(self + ebx) release];
    *(self + ebx) = 0x0;
    esi = *ivar_offset(_scrollViewForTransition);
    [*(self + esi) release];
    *(self + esi) = 0x0;
    return;
}
```
2019-03-21 10:37:54 -07:00
Matthew Chen
908fe1d0c9 Apply presentAlert() throughout codebase. 2019-03-21 10:58:49 -04:00
Matthew Chen
882dd16d7c Apply presentAlert() throughout codebase. 2019-03-21 10:55:04 -04:00
Matthew Chen
c9d62f47cc Respond to CR. 2019-03-21 10:26:38 -04:00
Matthew Chen
1a80f0c293 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:57 -04:00
Matthew Chen
cb5ce42e76 Add accessibility identifiers to privacy popups and subviews. 2019-03-21 10:08:25 -04:00
Matthew Chen
f37a3059fa Add accessibility identifiers to debug log popups. 2019-03-21 10:08:25 -04:00
Matthew Chen
81508e9d02 Add accessibility identifiers to settings popups. 2019-03-21 10:08:25 -04:00
Matthew Chen
d7b1e65a71 Add accessibility identifiers to blocklist popups. 2019-03-21 10:08:25 -04:00
Matthew Chen
f1520d760e Add accessibility identifiers to other settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen
b48e204b90 Add accessibility identifiers to notification settings views. 2019-03-21 10:08:25 -04:00
Matthew Chen
931d249677 Modify OWSFlatButton to propagate the accessibility identifier to wrapper button. 2019-03-21 10:08:25 -04:00
Matthew Chen
41a3c95831 Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen
8bcc19e36c Add missing accessibility ids in block list view. 2019-03-21 10:08:25 -04:00
Matthew Chen
52d6aa69b8 Improve measurement of image editor text layers. 2019-03-19 09:42:38 -04:00
Michael Kirk
0b638f4831 link checks 2019-03-18 15:21:19 -07:00