Commit Graph

17361 Commits

Author SHA1 Message Date
Morgan Pretty a3b3d2a485
Merge pull request #873 from oxen-io/dev
Release 2.3.2
2023-07-24 12:56:13 +10:00
Morgan Pretty 8a47adfe79
Merge pull request #868 from mpretty-cyro/fix/user-config-crashes
Fixes for user config crashes
2023-07-24 12:55:06 +10:00
Morgan Pretty 6ad303d450 Updated build and version numbers 2023-07-24 12:30:30 +10:00
Morgan Pretty a3adb23bad Merge remote-tracking branch 'upstream/dev' into fix/user-config-crashes
# Conflicts:
#	Session/Media Viewing & Editing/PhotoCapture.swift
2023-07-24 12:28:55 +10:00
Morgan Pretty 7aa3c9ff66
Merge pull request #870 from oxen-io/dev
Release 2.3.1
2023-07-21 10:42:31 +10:00
Morgan Pretty 8ac44b132d
Merge pull request #869 from mpretty-cyro/fix/cherry-pick-certain-fixes
Include specific fixes from the other branch
2023-07-21 10:41:56 +10:00
Morgan Pretty b12497e305 Include specific fixes from the other branch
Fixed a crash with the QRCode scanner
Fixed a crash when trying to take a video attachment
2023-07-21 10:41:18 +10:00
Morgan Pretty f373a989a8 Fixes for user config crashes
Added a method to determine if the database is suspended
Updated the code to show the "Failed" state if sending a message fails due to a suspended database
Prevented a crash which could occur in rare cases when accessing the Seed via the home screen prompt (direct user to share logs with session - db locked or device in an invalid state)
Prevented a crash which could occur when trying to send a message due to failing to retrieve the mnemonic (db locked or device in an invalid state)
Fixed a bug where optimistic messages could end up appearing multiple times
Fixed a crash with the QRCode scanner
Fixed a crash when trying to take a video attachment
Fixed a crash where the image picker grid could go out of bounds when selecting elements
Fixed a crash which could occur when a user provides a recovery password with a word that contains less than 3 characters
Fixed a potential issue where the dependency injection could result in a stale date being used in some places (removing the DI here, proper fix requires larger changes in another branch)
2023-07-20 12:29:56 +10:00
Morgan Pretty b7e77ea24b
Merge pull request #865 from oxen-io/dev
Release 2.3.0
2023-07-14 16:57:02 +10:00
Morgan Pretty 6ba9d1df89
Merge pull request #751 from mpretty-cyro/feature/updated-user-config-handling
Updated User Config Handling
2023-07-14 16:53:27 +10:00
Morgan Pretty 703b1d9788 CI tweaks and tweak for initial UX issue with 'blinded25' id
Added parallelisation for the unit tests
Added the SSH_KEY env variable for the 'Upload artifacts' step
Disabled xcbeautify for the prod build (as I expect it's suppressing the build error)
Disabled support for starting a conversation with a 'blinded25' id (would be invalid at this stage)
Fixed a broken unit test
2023-07-14 16:48:53 +10:00
Morgan Pretty bc5d8d0931 Cleaning up final things before release
Added basic support for the '25' blinded prefix
Fixed a unit test CI issue
2023-07-14 14:36:59 +10:00
Morgan Pretty f13f75eedf Fixed some bad CI script commas 2023-07-13 17:58:15 +10:00
Morgan Pretty c86cc0ed9c CI tweaks and incremented build number
Added the XCBeautify pod (so the CI doesn't need to separately install something)
Updated the CI build script to use XCBeautify
Fixed some broken unit tests
2023-07-13 17:57:08 +10:00
Morgan Pretty 970efbc3be Merge remote-tracking branch 'origin/feature/ci' into feature/updated-user-config-handling 2023-07-13 16:08:03 +10:00
Morgan Pretty 6e32e759c5 Added missing commas in CI config file 2023-07-13 16:03:00 +10:00
Morgan Pretty 69ddb782a1 Attempting to cache the Pods folder to speed up the CI
Fixed a CocoaPods warning
2023-07-13 16:01:57 +10:00
Morgan Pretty 9bdae9dee8 Fixed a typo in the Ci config 2023-07-13 15:40:32 +10:00
Morgan Pretty f15f16be70 More CI tweaks
Updated the Podfile to use the CocoaPods CDN (hopefully much faster than the master spec repo)
Removed the custom derivedDataPath (seemed to break the Copy Frameworks step of CocoaPods)
2023-07-13 15:35:35 +10:00
Morgan Pretty b72bf42605 Updated the CI and fixed a couple of config bugs
Updated to the 1.0.0 release of libSession
Set the User Config feature flag to July 31st 10am AEST
Shifted quote thumbnail generation out of the DBWrite thread
Stopped the CurrentUserPoller from polling the user config namespaces if the feature flag is off
Fixed an issue where the scrollToBottom behaviour could be a little buggy when an optimistic update is replaced with the proper change
Fixed an issue where the 'attachmentsNotUploaded' error wouldn't result in a message entering an error state
Fixed a bug where sync messages with attachments weren't being sent
2023-07-13 14:47:10 +10:00
Morgan Pretty 2833cef5e4 Tweaks to test the static upload script 2023-07-12 17:15:21 +10:00
Morgan Pretty c7f6b5a94e Replaced the 'ZXingObjC' dependency with a native implementation for scanning QR Codes 2023-07-12 17:13:59 +10:00
Morgan Pretty f623db678e Attempt to work around a stupid CocoaPods restriction 2023-07-12 15:43:36 +10:00
Morgan Pretty f8b69cd03c Disabling XCPretty due to permission issue 2023-07-12 15:36:12 +10:00
Morgan Pretty 5bd0d5d640 Attempting multiline bash command for xcpretty 2023-07-12 15:33:33 +10:00
Morgan Pretty 3c81e3a487 Changed the submodule to be via HTTPS instead of SSH
Cleaned out some old, unused references from project files
2023-07-12 15:28:28 +10:00
Morgan Pretty 8de4a66865 Reverting last change 2023-07-12 15:15:39 +10:00
Morgan Pretty c8c70c448e Tweaks to the submodule command 2023-07-12 15:13:42 +10:00
Morgan Pretty 0464439e8d Fixed some formatting errors 2023-07-12 15:05:51 +10:00
Morgan Pretty 7b06329454 Fixed an incorrect bash command 2023-07-12 15:04:54 +10:00
Morgan Pretty 43b2aaf8bb Trying to progress on the CI builds
Reworked the way libSession-util builds to use a static library and be less hacky
Updated to the latest version of WebRTC-lib (no longer includes bitcode)
Removed the 'skip_web_rtc_re_rsync' patch as it's no longer an issue since the bitcode was removed so the framework is much smaller
2023-07-12 15:03:42 +10:00
Morgan Pretty 868b4cc24e [WIP] Started looking at creating the CI config file 2023-07-11 12:16:00 +10:00
Morgan Pretty 38420997b0 Fixed a couple of bugs and made some performance tweaks
Cleaned up some duplicate poller logic (avoid going back to the main queue)
Updated the code to remove a profile image if a user sends a message which doesn't have a profile image (ie. they've explicitly removed it)
Fixed an issue where some more logic could incorrectly run in the DBWrite queue
Fixed a bug where the OpenGroupPoller could stop polling when getting an error
Fixed a bug where messages which had the same timestamp wouldn't get correctly marked as read when scrolling under the right circumstances
2023-07-10 17:56:58 +10:00
Morgan Pretty a5306f85b7 Added in a little defensive coding for config message processing
Updated the config 'pendingChanges' to use the readonly version of the conf (no use blocking access)
Added code to throw and log when the config processing exceeds 50000 loops (ie. infinite loop protection)
2023-07-07 15:19:13 +10:00
Morgan Pretty 0f52d358d4 Fixed an issue where return from background could hang
Stopped trying to run migrations if there aren't any to run (remove unneeded DBWrite thread use)
Shifted return from background migration running to a background thread to prevent hanging
Updated the slow write log to also output once the write completes
2023-07-07 14:55:03 +10:00
Morgan Pretty 6f4bdcdccb Moved some logic outside of DBWrite closures to prevent hangs
Updated the SessionApp.presentConversation function from using the DBWrite thread if it didn't need to
Updated the PagedDatabaseObserver to process database commits async on a serial queue to avoid holding up the DBWrite thread
Moved another Atomic mutation outside of a DBWrite closure
Refactored the PagedDatabaseObserver 'databaseDidCommit' logic to be much more straightforward
Tweaked a couple of flaky unit tests
2023-07-07 13:20:32 +10:00
Morgan Pretty a7761697a9 More performance logging and some minor optimisations
Added code to throttle the 'markAsRead' logic when scrolling to 100ms
Added a launch counter so we will always get error logs on launch if the database is suspended
Updated the logging to also indicate whether it's the DBWrite queue
Moved a couple of Atomic mutations outside of DB write closure on the off chance they are blocking
2023-07-06 15:39:41 +10:00
Morgan Pretty 0225f436bd Podfile tweaks to speed up sim builds, unit tests & minor bug fix
Added a patch to the Podfile to avoid rsync'ing and signing WebRTC-lib for simulator builds shaving off 10+ seconds of build time per target due to the sheer size of the WebRTC debug framework
Added some basic unit tests to validate the current search behaviour
Fixed some buggy search behaviours
2023-07-04 17:09:50 +10:00
Morgan Pretty 3151aa8901 Fixed an issue where the users push token might never get unregistered 2023-07-03 17:13:15 +10:00
Morgan Pretty f976d85c27 Fixed infinite loops introduced by the last change >_> 2023-07-03 12:33:26 +10:00
Morgan Pretty f45568644e Fixed a somehow reproducable crash
Fixed a crash when autoLoadNextPageIfNeeded was run after the table data was updated but before the tableView was reloaded resulting in a index out of bounds exception
2023-07-03 12:05:43 +10:00
Morgan Pretty 7b70f8d535 Increased build number 2023-07-03 10:45:13 +10:00
Morgan Pretty 30779bdf5b Removed an incorrect `AssertIsOnMainThread` 2023-07-03 10:40:54 +10:00
Morgan Pretty eac17678fc Fixed a few path issues in the build script submodule validation logic 2023-07-03 10:12:04 +10:00
Morgan Pretty 1ed86d483e Tweaks to the Build pre-action
Removed the flag to automatically reset and check out submodules (seemed too destructive for a default behaviour)
Updated all targets to run the 'Validate pre-build actions' script
Updated the build script to return a success instead of an error (forgot that this was the point of the 'Validate pre-build actions' script)
2023-07-03 09:54:04 +10:00
Morgan Pretty ec81236615 Fixed a few more threading-related bugs
Updated the libSession build script to reset and checkout submodules based on a flag (simplify the process)
Updated the share and notification extensions to generate the DSYM on debug builds to allow for better debugging
Added additional startup logging for debugging purposes
Tweaked the SNLog function to indicate when the log happens on the main thread (slightly less efficient but should help track down logic incorrectly running on the main thread)
Fixed a bug where we weren't recording the last PN server registration (so would re-register every time)
Fixed a bug where if the user sent the app to the background too quickly after launching the app wouldn't successfully startup when re-opening
Fixed a bug where the Notification and Share extensions would assert because they were dispatching the post-migration logic to the main thread (due to the threading changes in a previous release)
Fixed a bug where the Notification extension would incorrectly poll open groups on the main thread
2023-06-30 17:59:37 +10:00
Morgan Pretty d0be7f786c Fixed a hang, removed redundant libs, files and code
Fixed an issue where returning the app from the background would result in the app staying permanently on the splash screen
Included a CRC32 implementation so we can drop the CryptoSwift dependenciy (using CryptoKit everywhere else)
Removed 'SocketRocket' (unused)
Removed the `xcode_14_3_workaround` post-install hook (fixed with CocoaPods 1.12.1)
Removed the `enable_fts5_support` post-install hook (enabled by default since GRDB 6.7.0 so redundant)
Removed the `enable_whole_module_optimization_for_crypto_swift` post-install hook (dropped CryptoSwift support)
Cleared out a bunch of headers from the Signal-Bridging-header file (direct imports instead to reduce incremental build sizes)
Deleted some unused code
2023-06-29 16:58:23 +10:00
Morgan Pretty 5e2e103ee1 Resolved the remaining known internal testing issues
Removed the 'immediatelyOnMain' extensions as they would break in some cases (eg. upstream errors with multiple 'receive(on:)' calls) resulting in logic running on unexpected threads
Updated the ReplaySubject to add subscribers in an Atomic just to be safe
Updated the code to remove the invalid open group when the user receives an error after joining
Fixed a bug with editing closed group members
Fixed broken unit tests
2023-06-29 12:11:54 +10:00
Morgan Pretty 6cf7cc42ab Fixed up the remaining reported internal testing issues
Removed the 'readPublisherFlatMap/writePublisherFlatMap' functions as they easily resulted in behaviours which held up database threads
Tweaked the logic around starting the open group pollers to avoid an unlikely atomic lock blocks
Updated some logic to avoid accessing database read threads for longer than needed
Updated the OpenGroupManager to only update the 'seqNo' value for valid messages
Cleaned up some double Atomic wrapped instances which had some weird access behaviours
Fixed an issue where a database read thread could have been started within a database write thread
Fixed an issue where the ReplaySubject might not emit values in some cases
2023-06-28 18:03:40 +10:00
Morgan Pretty b6328f79b9 Reworked the app startup process
Shifted the initial HomeVC population to a background thread to avoid blocking launch processing
Added some logging for database 'ABORT' errors to better identify cases of deadlocks
Added a launch timeout modal to allow users to share their logs if the startup process happens to hang
Updated the notification handling (and cancelling) so it could run on background threads (seemed to take up a decent chunk of main thread time)
Fixed an issue where the IP2Country population was running sync which could cause a hang on startup
Fixed an issue where the code checking if the UIPasteBoard contained an image was explicitly advised against by the documentation (caused some reported hangs)
Fixed a hang which could be caused by a redundant function when the ImagePickerController appeared
2023-06-27 18:01:00 +10:00