Commit graph

3297 commits

Author SHA1 Message Date
Matthew Chen b2b62880c0 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen 77b72b6b06 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen da5ae63bbc Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen 28e26e1f75 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen 916d55c55d Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen 28f7142a59 Auto-migration to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen 6b39f73e65 Fix tests. 2018-05-30 15:05:02 -04:00
Matthew Chen 40ef287952 Avoid spurious animation in call view buttons. 2018-05-30 14:00:27 -04:00
Matthew Chen 5f593bd736 Revert "Add temporary verbose logging around message creation."
This reverts commit f26ad5cd34.
2018-05-29 14:01:11 -04:00
Matthew Chen 0aa8306036 Revert "Add temporary verbose logging around message creation."
This reverts commit 5b0d806a6d.
2018-05-29 14:01:04 -04:00
Matthew Chen 5b0d806a6d Add temporary verbose logging around message creation. 2018-05-29 13:42:49 -04:00
Matthew Chen f26ad5cd34 Add temporary verbose logging around message creation. 2018-05-29 11:49:42 -04:00
Matthew Chen 2a4ecd42c4 Fix crashes while deallocating PeerConnectionClient. 2018-05-29 10:02:16 -04:00
Matthew Chen 86e038436b Fix crashes while deallocating PeerConnectionClient. 2018-05-29 10:02:16 -04:00
Matthew Chen 8d9c811566 Fix crashes while deallocating PeerConnectionClient. 2018-05-29 10:02:16 -04:00
Matthew Chen fff9f74a05 Fix crashes while deallocating PeerConnectionClient. 2018-05-29 10:02:16 -04:00
Matthew Chen 08affb4400 Merge branch 'hotfix/2.25.2' 2018-05-29 10:01:33 -04:00
Matthew Chen fbd03a3fdc Apply design for call view back button. 2018-05-25 09:53:37 -04:00
Michael Kirk 9a34c6804c policy links
// FREEBIE
2018-05-25 09:22:53 -04:00
Michael Kirk caa9e3ca67 Show missed call when call times out
// FREEBIE
2018-05-25 09:19:45 -04:00
Michael Kirk b8707b6fa4 WIP: call view changes 2018-05-24 12:28:20 -04:00
Michael Kirk fe62a6ac92 CNContactController needs to be presented in a navcontroller with a
translucent navbar.

In cases where we were presenting modally, we can easily modify the
modal to have a translucent navbar.

In the one place we were pushing onto the SignalsNavigationController,
rather than modifying the SNC.isTranslucent and having to clean it up,
I've opted to convert to a modal presentation.

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 2709a91b5e Fixup attachment approval vis-a-vis call banner
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 4f80100234 Tapping on status bar returns to call
We want to render the return-to-call banner behind the status bar, so
the user can see the system clock, etc.

But normally, doing so would mean we wouldn't receive touches in the top
20px of the screen.

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 4c9808d1a1 Fix iPhoneX layout show status bar above call banner
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 778e11c2c3 cleanup ahead of PR
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 1b60716759 Stop worrying about notification order by using delegate pattern
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk d9d0227ce5 Align search bar to safe area insets
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 319a6ff765 fixup behavior on iOS10 2018-05-24 12:28:20 -04:00
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 33eb4c38cd Centralize translucency configuration
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 12c98f4340 cleanup and move to OWSNavigationController
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk a2b1793262 initial render is wrong, but settles somewhere nice
-[x] fix initial placement
-[x] add additional top safe area?

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 3a9391f4fb notes on what didn't work 2018-05-24 12:28:20 -04:00
Michael Kirk 4dbd14ac41 WIP navbar resize
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[x] disable conversation view call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 0e87cbe7a5 WIP navbar resize
-[ ] CallScreen
  -[x] functional button
  -[ ] needs design
  -[ ] disable other contact call buttons while in call
-[ ] iOS11
  -[x] resize nav content
  -[ ] background showing at top of all vc's
  -[] iPhoneX
    -[x] use differently sized banner for now
    -[] mimic X system design
-[ ] iOS10
  -[x] resize nav content
  -[ ] animation glitch while push/pop
-[ ] iOS9

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk ffe17a3fcc add guard to avoid redundant show, fix logic in existing guard when
hiding.

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 2258e18d34 rename for clarity
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 91cd1af3f9 Extract ReturnToCallViewController
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk a7252544b0 WIP: custom navbar
TODO:

Use custom navcontroller everywhere - no more UINavigationController

listen to notification for when call starts/ends and sizeToFit.
2018-05-24 12:28:20 -04:00
Michael Kirk 772af10e50 Resizing call banner window
problem is the navigation bar is now too tall, since it has room for
status.

We could shirnk the nav bar, but maybe it's easier to just have the call
banner in the navbar?

// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk e62fe87b01 show status bar *above* call window 2018-05-24 12:28:20 -04:00
Michael Kirk 94323baba8 tmp - mute hides callscreen 2018-05-24 12:28:20 -04:00
Matthew Chen a722bcde72 Fix call termination reference. 2018-05-24 12:18:39 -04:00
Matthew Chen 1343e4bc19 Preserve legacy outgoing message state; special case contact thread messages. 2018-05-23 10:23:46 -04:00
Matthew Chen bfb87582fe Respond to CR. 2018-05-22 15:44:08 -04:00
Matthew Chen 735b4e07b1 Respond to CR. 2018-05-22 15:44:08 -04:00
Matthew Chen 918abb02a1 Remove capture of self. 2018-05-22 15:44:08 -04:00
Matthew Chen 9c0c87a8c3 Remove capture of self. 2018-05-22 15:44:08 -04:00
Matthew Chen 7eab0569b6 PeerConnectionClient thread safety. 2018-05-22 15:44:08 -04:00