Commit graph

282 commits

Author SHA1 Message Date
Matthew Chen
15b52db8bf Respond to CR. 2018-09-20 08:55:19 -04:00
Matthew Chen
29bb69032a DRY up the debounce of db extension version increment. 2018-09-20 08:55:19 -04:00
Matthew Chen
3b2c5bfc7b Modify mock environments to register all db views. 2018-09-19 16:29:15 -04:00
Matthew Chen
e1db60c1c0 Rework creation of singletons. 2018-09-19 15:11:26 -04:00
Matthew Chen
69290f7ec8 Improve logging around failied keychain deletion. 2018-09-18 09:07:54 -04:00
Matt Rubin
d25579e478 Treat failure to delete a non-existent password as success
Fixes https://github.com/signalapp/Signal-iOS/issues/3876
2018-09-18 09:05:43 -04:00
Michael Kirk
9bca1c8e52 Add some missing nullability annotations 2018-09-17 10:10:32 -06:00
Michael Kirk
3df0e72eda Extract SPK rotation and CreatePreKey operations 2018-09-17 10:10:32 -06:00
Michael Kirk
286d3c8ce9 Serialize RefreshKeyOperation
TODO

-[] rotate signed prekey job
-[] verify current prekey w/ server
-[] create keys
2018-09-17 10:10:32 -06:00
Michael Kirk
1eb05c1d01 remove unused preKeyLastResort 2018-09-17 10:10:32 -06:00
Michael Kirk
920a82564f Merge tag '2.29.3.3' 2018-09-15 09:17:08 -05:00
Matthew Chen
e784f9feeb Move fakes to SSK/tests. 2018-09-14 14:05:43 -04:00
Michael Kirk
e4d12feeb9 rev gallery db extension since our isValid checks have changed 2018-09-07 16:37:00 -06:00
Matthew Chen
cc117b385c Modify environment accessors to use our 'shared' convention. 2018-09-07 16:20:59 -04:00
Matthew Chen
bd05cdc031 Rename TextSecureKitEnv to SSKEnvironment. 2018-09-07 16:19:00 -04:00
Matthew Chen
bcceda1861 Respond to CR. 2018-09-07 16:05:57 -04:00
Matthew Chen
cfb511aa57 Respond to CR. 2018-09-07 16:00:32 -04:00
Matthew Chen
eb616a3411 Respond to CR. 2018-09-07 15:37:40 -04:00
Matthew Chen
535241ef9e Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 2018-09-07 15:37:40 -04:00
Matthew Chen
399dd13cee Add test app context; use mock "document" and "shared data container" directories in tests, use mock keychain storage in tests. 2018-09-07 15:37:40 -04:00
Michael Kirk
c7662b5a86 Step 2/2 %s/OWSAssert/OWSAssertDebug for existing previous assert semantics
Going forward, we want to prefer safer asserts, but we don't want to blindly
apply crashing asserts across the codebase
2018-09-07 10:00:48 -06:00
Matthew Chen
f4d1f25656 Merge remote-tracking branch 'origin/release/2.29.1' 2018-09-04 09:27:41 -04:00
Michael Kirk
6821e4a3a5 Don't include invalid media in gallery 2018-08-30 19:21:45 -06:00
Matthew Chen
f473f60111 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
cc5a480baa Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
03829779cc Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
c0d486b1f1 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
3a50377902 Apply OWS log functions in Objective-C. 2018-08-27 12:58:52 -04:00
Matthew Chen
713606271c Rename fail macros in Obj-C. 2018-08-27 10:29:51 -04:00
Matthew Chen
5b50e81b4f Rename fail macros in Swift. 2018-08-27 10:27:48 -04:00
Matthew Chen
cf6f3841a8 Apply new Swift logging. 2018-08-27 10:02:28 -04:00
Michael Kirk
82e559d11b Use swift macros for main thread assert 2018-08-23 10:29:49 -06:00
Matthew Chen
b347c40c66 Clean up ahead of PR. 2018-08-16 12:21:03 -04:00
Matthew Chen
0a7b3537b5 Recreate message database view when message mappings are corrupt. 2018-08-16 12:21:03 -04:00
Michael Kirk
c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
2018-08-09 15:30:19 -06:00
Matthew Chen
db3df249bf Merge NSData categories. 2018-08-09 13:50:55 -04:00
Matthew Chen
2c9c028504 Clean up. 2018-08-09 09:51:23 -06:00
Matthew Chen
45e782c243 Revamp orphan data cleaner. 2018-08-07 13:07:26 -04:00
Michael Kirk
fc1ce02ae5 CR: Now that we have transaction semantics, this shouldn't happen.
// FREEBIE
2018-08-03 14:10:46 -06:00
Michael Kirk
1eb7fc986c YapDB introduced a method purpose built to do what we were approximating.
This seems a little more future proof / less error prone if we change the
registered extensions.
2018-08-03 14:09:35 -06:00
Michael Kirk
df01c7e63e Update to latest YapDB (with Signal patches applied)
Applied branches:

- mkirk/invalidFinalIndices
- mkirk/upstream-unencrypted-headers

Also fixed up test suite.
2018-08-03 14:09:35 -06:00
Matthew Chen
708ef6f7dd Fix NPE using mock for unknown database objects. 2018-07-23 16:42:11 -04:00
Matthew Chen
060e0fd062 Fix NPE using mock for unknown database objects. 2018-07-23 16:40:01 -04:00
Matthew Chen
03e5d2973b Delta contact intersections. 2018-07-18 14:27:40 -04:00
Michael Kirk
77997639f5 Use CurrentAppContext instead of compiler flag to affect test behavior 2018-07-18 10:24:08 -06:00
Michael Kirk
12ef25420a Fixup SSK tests 2018-07-17 19:32:44 -06:00
Michael Kirk
d591fb7f2c Fix some compiler warnings 2018-07-17 19:22:58 -06:00
Matthew Chen
158aa3abc4 Tweak system messages; incomplete vs. missed calls. 2018-07-11 15:34:16 -04:00
Matthew Chen
a6dbb7704a Remove overzealous assert in search finder. 2018-06-26 12:47:21 -06:00
Matthew Chen
700e9fa491 Improve logging around deserialization exceptions. 2018-06-22 09:49:57 -04:00