Commit graph

169 commits

Author SHA1 Message Date
Michael Kirk 1a92f414eb Revert "Disable dark theme in production."
This reverts commit 472a92a1a3.
2018-08-24 16:22:28 -06:00
Michael Kirk 1d2590fa12 Merge tag '2.29.0.17' 2018-08-24 16:22:07 -06:00
Matthew Chen cb827169fb Respond to CR. 2018-08-22 16:30:12 -04:00
Matthew Chen 472a92a1a3 Disable dark theme in production. 2018-08-22 16:07:09 -04:00
Michael Kirk 75bb9b60db Alternative dark theme search bar
Rather than our custom class, we can get pretty far using existing UISearchBar
styling, and then apply the final tweak, the search bar text field background
color by traversing the view.

This fixes a couple issues:

1. There was a small wavering in height of the custom search bar
2. When your table header view is a UISearchBar you get nice scroll "snapping"
   when showing/hiding the search bar.
2018-08-22 12:00:44 -06:00
Michael Kirk e435358bfd Revert "Add custom themed search bar."
This reverts commit 8daaef22da.
2018-08-22 12:00:44 -06:00
Michael Kirk b80d88c824 theme attachment approval keyboard
// FREEBIE
2018-08-20 12:26:48 -06:00
Matthew Chen 8daaef22da Add custom themed search bar. 2018-08-17 12:43:35 -04:00
Matthew Chen d62e07d6f1 Theme review. 2018-08-16 17:30:08 -04:00
Matthew Chen 4ea5d9b849 Theme review. 2018-08-16 17:30:07 -04:00
Matthew Chen a76d488e8b Fix QA issues in theme. 2018-08-15 17:09:59 -04:00
Michael Kirk 71cb90b575 Avoid incremental theme-redraws
IMO this feels more impressive
2018-08-10 17:00:35 -06:00
Michael Kirk 8829cdfb4b Toast view when tapped message doesn't exist, mark remotely sourced. 2018-08-10 16:55:54 -06:00
Michael Kirk 7a0d74c17e Use dark blur for navbar
In the light theme, using the "light" blur allows the bar to seem invisible
when over white content. Similarly for the "dark" blur over black content.
2018-08-10 16:52:55 -06:00
Michael Kirk ebd2e6d5ac Tweak theme 2018-08-09 16:43:25 -06:00
Michael Kirk c05700fd98 Log in OWSFail
step 1: rename OWSFail->OWSFailNoProdLog
step 2: rename OWSProdLogAndFail->OWSFail
step 3: Convert OWSFailNoProdLog->OWSFail where we want logging
step 4: Rename OWSCFail->OWSCFailNoProdLog
step 5: Rename OWSProdLogAndCFail -> OWSCFail
step 6: Convert OWSCFailNoProdLog -> OWSCFail where we want logging
2018-08-09 15:30:19 -06:00
Matthew Chen 3fc3425605 Theme search bars. 2018-08-09 14:02:29 -04:00
Matthew Chen adadf094d4 Enable theme. 2018-08-08 16:01:17 -04:00
Matthew Chen 5ef0b6d056 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen a56a16411f Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen a543cd5a4e Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen ce4fdd5135 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen d34f83b445 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen 4f8dbf39b5 Refine theme. 2018-08-08 15:04:23 -04:00
Matthew Chen fa8a07abf1 Respond to CR. 2018-07-26 10:54:45 -04:00
Matthew Chen 7759c9ca0f Refine theme. 2018-07-26 09:42:48 -04:00
Matthew Chen f795b12a86 Refine theme. 2018-07-26 09:42:48 -04:00
Matthew Chen 906d0b01a4 Fix build break. 2018-07-23 13:47:03 -04:00
Matthew Chen 819c2b1ceb Remove Twisted Oak. 2018-07-23 13:24:33 -04:00
Matthew Chen 2b1f928770 Respond to CR. 2018-07-20 15:47:37 -04:00
Matthew Chen 48975eaac8 Respond to CR. 2018-07-20 15:37:47 -04:00
Matthew Chen 8862f9a531 Refine views. 2018-07-20 15:26:46 -04:00
Michael Kirk d591fb7f2c Fix some compiler warnings 2018-07-17 19:22:58 -06:00
Matthew Chen 0c453c8d57 Fix content insets. 2018-07-17 14:51:10 -06:00
Michael Kirk 8da47b64d9 clarify different methods
These method names were too similar to existing methods in PureLayout, which
have slightly different behavior.

ows_autoPinToSuperviewEdges uses left/right, whereas PureLayouts uses
leading/trailing

ows_autoPinToSuperviewMargins uses our own constraint adding logic, which
behaves differently in some cases.
2018-07-16 10:20:05 -06:00
Matthew Chen 3729943cd3 Fix production build breakage. 2018-07-13 10:15:22 -04:00
Matthew Chen b2f42adb86 Respond to CR. 2018-07-13 09:32:30 -04:00
Matthew Chen 20d1d11259 Refine home view. 2018-07-13 09:28:09 -04:00
Matthew Chen 0c420ed28a Tweak appearance. 2018-07-12 09:29:46 -04:00
Michael Kirk c8b4e879e7 CR: remove unused font 2018-07-10 11:39:56 -06:00
Michael Kirk f22cb48f85 date break font/color to spec
// FREEBIE
2018-07-10 11:39:56 -06:00
Michael Kirk 998c2f392c CR: inline per code review 2018-07-10 11:33:24 -06:00
Michael Kirk 834021fe39 tweak selected color for homeview cells 2018-07-10 11:28:00 -06:00
Michael Kirk b0978abd01 use points not pixels when determining how short a device is 2018-07-10 09:45:27 -06:00
Matthew Chen 712d6d89e1 Tweak relative timestamps. 2018-07-09 16:33:03 -04:00
Matthew Chen a28a5251f6 Respond to CR. 2018-07-09 16:31:43 -04:00
Matthew Chen 5b5ef7e0bf Respond to CR. 2018-07-05 17:27:37 -04:00
Matthew Chen 19699fd45f Tweak message send failed indicator. 2018-07-05 16:30:55 -04:00
Michael Kirk 0f34f76611 Merge tag '2.27.1.1' 2018-07-03 18:19:01 -06:00
Michael Kirk b47062831f Don't block "register" button on iPad registration
On short devices, add a toolbar with a "dismiss" button to the number pad.
2018-07-03 18:11:14 -06:00
Matthew Chen 05b1b37eab Respond to CR. 2018-07-02 16:35:30 -04:00
Matthew Chen 1412998b4a Rework isRTL. 2018-07-02 15:27:24 -04:00
Michael Kirk 5719aba91a separate icon vs. title color for toolbars 2018-06-29 17:47:04 -06:00
Michael Kirk 126d41e542 Fixup "scroll down" button so it doesn't fall behind toolbar 2018-06-29 16:58:26 -06:00
Michael Kirk f8abe32ae9 more styling to new nav colors 2018-06-29 16:27:37 -06:00
Michael Kirk 5d6a988955 WIP navbar 2018-06-29 15:30:24 -06:00
Michael Kirk 16df4f589e conversation colors
// FREEBIE
2018-06-29 11:52:41 -06:00
Matthew Chen 24c4c4c098 Respond to CR. 2018-06-29 12:49:23 -04:00
Matthew Chen 87380894ba Tweak message cells. 2018-06-28 15:03:44 -04:00
Matthew Chen 17d4ccc489 Disable compact text layout. 2018-06-28 15:03:02 -04:00
Matthew Chen af4eb39a2d Respond to CR. 2018-06-28 13:20:01 -04:00
Matthew Chen ce9a9ec925 Tweak color palette. 2018-06-28 13:18:35 -04:00
Matthew Chen 8943669d88 Tweak colors. 2018-06-28 13:18:35 -04:00
Matthew Chen ac6f78a5fc Tweak message cells. 2018-06-25 09:26:41 -04:00
Michael Kirk cc1bde34cd Inform iPad users upon registration
// FREEBIE
2018-06-21 15:02:37 -06:00
Michael Kirk ffea3a020f WIP: FTS - wired up Search VC
-[] Backend
  -[] indexes e5.25
    -[x] wire up results: Contacts / Conversations / Messages actual: 3hr
    -[ ] group thread est: actual:
      -[x] group name actual: e.25
      -[ ] group member name: e.25
      -[ ] group member number: e.25
    -[ ] contact thread e.5
      -[ ] name
      -[ ] number
    -[ ] messages e1
      -[ ] content
-[] Frontend e10.75
  -[x] wire up VC's a.5
  -[x] show search results only when search box has content a.25
  -[] show search results: Contact / Conversation / Messages e2
  -[] tapping thread search result takes you to conversation e1
  -[] tapping message search result takes you to message e1
  -[] show snippet text for matched message e1
  -[] highlight matched text in thread e3
  -[] go to next search result in thread e2
2018-06-11 09:58:36 -04:00
Matthew Chen 3964b78ff7 Reduce usage of JSQ. 2018-06-01 17:44:18 -04:00
Óscar Morales Vivó 69b5272547 More code review polish. 2018-06-01 09:38:38 -04:00
Óscar Morales Vivó 4b98352a38 Changes suggested by code review. Added iPhone 4 screen size to iPhoneX test so Signal doesn't blow up in iPad's iPhone compatibility mode. 2018-06-01 09:38:38 -04:00
Matthew Chen f63d25a172 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Matthew Chen 28e26e1f75 Migrate to Swift 4. 2018-05-30 15:05:02 -04:00
Michael Kirk fc34a0643c CR: annotate device constants
// FREEBIE
2018-05-24 12:28:20 -04:00
Michael Kirk 29d08545e2 Use OWSNavigationController instead of UINavigationController
- [ ] document picker
- [ ] camera picker
- [ ] image picker
- [ ] restore "confirm to go back" behavior (interactive pop gesture?)

// FREEBIE
2018-05-24 12:28:20 -04:00
Matthew Chen 44ceee5849 Add contact share actions to conversation view and improve phone number parsing. 2018-05-08 17:22:34 -04:00
Matthew Chen 50c49baca8 Update design of 'approve contact share' view. 2018-05-07 16:18:22 -04:00
Matthew Chen f6d5b9197c Respond to CR. 2018-04-16 12:39:11 -04:00
Matthew Chen 115235d1b4 Fix animation glitch in blocking window. 2018-04-16 09:49:37 -04:00
Michael Kirk 13a432b9de Limit attachment caption length to 2k bytes
// FREEBIE
2018-04-13 17:57:09 -04:00
Matthew Chen a5a2f02edc Respond to CR. 2018-04-13 14:53:14 -04:00
Matthew Chen 644e78f19d Respond to CR. 2018-04-13 14:32:42 -04:00
Matthew Chen 759b2a332f Respond to CR. 2018-04-11 14:18:09 -04:00
Matthew Chen b8f8a3017a Apply design changes to home view. 2018-04-11 09:34:37 -04:00
Matthew Chen 180cbbcdb3 Don't use scaledFontForFont. 2018-04-10 09:55:25 -04:00
Matthew Chen ade2ee7216 Use dynamic type everywhere in conversation view. 2018-04-09 14:25:53 -04:00
Matthew Chen 71c5c3a4b7 Refine appearance of quoted reply message cells. 2018-04-05 10:39:07 -04:00
Matthew Chen 822aa64b14 Respond to CR. 2018-04-05 10:35:57 -04:00
Matthew Chen 10b4ade55a Refine appearance of quoted reply message cells. 2018-04-05 10:24:42 -04:00
Michael Kirk 6874a9e28e Convert to swift
// FREEBIE
2018-04-04 10:59:04 -04:00
Michael Kirk f441c6211d Format
// FREEBIE
2018-04-02 17:02:32 -04:00
Michael Kirk 6f1608f44b Conventional naming for out custom PureLayout methods.
This moves methods more in line with PureLayout conventions.

- Methods always specify if they pin to an edge vs margin

- `margin` is a reserved word which should only refer to layout margins.
  i.e. do not use it to refer to "inset" and "offset".

// FREEBIE
2018-04-02 17:02:32 -04:00
Matthew Chen 8e4f2ca0ed Rework proto schema changes for quoted replies.
Sketch out model changes for quoted replies.

Sketch out quoted reply input preview.

Send quoted messages protos.

Update models to reflect quoted messages.

Rework interaction initializers.

Rework interaction initializers.

Add debug UI methods for generating quoted reply variations.

Add debug UI methods for generating quoted reply variations.
2018-04-02 16:17:46 -04:00
Michael Kirk 352f5c1059 Prefer back button over dismiss
In some context this makes more sense, and it will never be confusing.

// FREEBIE
2018-03-20 11:12:11 -04:00
Michael Kirk 4ac9a1019b Media page view controller
First pass at a swipe-through media view for conversations.

Future work could include

- title label per item
  - sender name
  - date/time
- photo rail
- include caption

// FREEBIE
2018-03-16 15:55:34 -04:00
Matthew Chen 99aedca45f Strip out special casing for pre-iOS 9 users. 2018-02-26 14:13:38 -05:00
Matthew Chen d648a258d1 Merge branch 'hotfix/2.19.7' 2018-02-16 10:49:52 -05:00
Matthew Chen 48b6c3dafb Refine message date/time formatting. 2018-02-13 15:02:29 -05:00
Matthew Chen 6a7f06f940 Respond to CR. 2018-01-25 13:53:39 -05:00
Matthew Chen 56ef293ed1 Clean up ahead of PR. 2018-01-25 13:27:17 -05:00
Matthew Chen 069587b150 Add message approval view. 2018-01-25 13:27:16 -05:00
Matthew Chen 979386ee9e Improve handling of text and url shares. 2018-01-25 13:26:10 -05:00